Skip to content

F
Front-End
Unverified Commit 3bd1737c authored by Gary Qian's avatar Gary Qian Committed by GitHub
Browse files
Options

Partially Rollback caret change for Android (#32043)

parent 0a3df1b5
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 2 deletions
packages/flutter/lib/src/rendering/editable.dart
View file @ 3bd1737c
...@@ -1503,7 +1503,7 @@ class RenderEditable extends RenderBox { ...@@ -1503,7 +1503,7 @@ class RenderEditable extends RenderBox {
case TargetPlatform.iOS: case TargetPlatform.iOS:
return Rect.fromLTWH(0.0, 0.0, cursorWidth, preferredLineHeight + 2); return Rect.fromLTWH(0.0, 0.0, cursorWidth, preferredLineHeight + 2);
default: default:
return Rect.fromLTWH(0.0, 0.0, cursorWidth, preferredLineHeight - 2.0 * _kCaretHeightOffset); return Rect.fromLTWH(0.0, _kCaretHeightOffset, cursorWidth, preferredLineHeight - 2.0 * _kCaretHeightOffset);
} }
} }
@override @override
...@@ -1569,7 +1569,7 @@ class RenderEditable extends RenderBox { ...@@ -1569,7 +1569,7 @@ class RenderEditable extends RenderBox {
// TODO(garyq): See the TODO for _getCaretPrototype. // TODO(garyq): See the TODO for _getCaretPrototype.
caretRect = Rect.fromLTWH( caretRect = Rect.fromLTWH(
caretRect.left, caretRect.left,
caretRect.top, caretRect.top - _kCaretHeightOffset,
caretRect.width, caretRect.width,
_textPainter.getFullHeightForCaret(textPosition, _caretPrototype), _textPainter.getFullHeightForCaret(textPosition, _caretPrototype),
); );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab