Commit 3b3b0ff1 authored by Devon Carew's avatar Devon Carew

make sdb getprop less verbose (#4053)

parent 95f838b0
...@@ -56,14 +56,15 @@ class AndroidDevice extends Device { ...@@ -56,14 +56,15 @@ class AndroidDevice extends Device {
if (_properties == null) { if (_properties == null) {
_properties = <String, String>{}; _properties = <String, String>{};
try { List<String> propCommand = adbCommandForDevice(<String>['shell', 'getprop']);
String getpropOutput = runCheckedSync(adbCommandForDevice(<String>['shell', 'getprop'])); printTrace(propCommand.join(' '));
ProcessResult result = Process.runSync(propCommand.first, propCommand.sublist(1));
if (result.exitCode == 0) {
RegExp propertyExp = new RegExp(r'\[(.*?)\]: \[(.*?)\]'); RegExp propertyExp = new RegExp(r'\[(.*?)\]: \[(.*?)\]');
for (Match m in propertyExp.allMatches(getpropOutput)) for (Match match in propertyExp.allMatches(result.stdout))
_properties[m.group(1)] = m.group(2); _properties[match.group(1)] = match.group(2);
} catch (error, trace) { } else {
printError('Error retrieving device properties: $error'); printError('Error retrieving device properties for $name.');
printTrace(trace.toString());
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment