Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3ab799bb
Unverified
Commit
3ab799bb
authored
May 07, 2021
by
Michael Goderbauer
Committed by
GitHub
May 07, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Assert when duplicated keys are introduced in subsequent build (#81850)
parent
6849e4b7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
58 additions
and
10 deletions
+58
-10
framework.dart
packages/flutter/lib/src/widgets/framework.dart
+1
-0
framework_test.dart
packages/flutter/test/widgets/framework_test.dart
+6
-10
multichildobject_with_keys_test.dart
...flutter/test/widgets/multichildobject_with_keys_test.dart
+51
-0
No files found.
packages/flutter/lib/src/widgets/framework.dart
View file @
3ab799bb
...
@@ -6304,6 +6304,7 @@ class MultiChildRenderObjectElement extends RenderObjectElement {
...
@@ -6304,6 +6304,7 @@ class MultiChildRenderObjectElement extends RenderObjectElement {
void
update
(
MultiChildRenderObjectWidget
newWidget
)
{
void
update
(
MultiChildRenderObjectWidget
newWidget
)
{
super
.
update
(
newWidget
);
super
.
update
(
newWidget
);
assert
(
widget
==
newWidget
);
assert
(
widget
==
newWidget
);
assert
(!
debugChildrenHaveDuplicateKeys
(
widget
,
widget
.
children
));
_children
=
updateChildren
(
_children
,
widget
.
children
,
forgottenChildren:
_forgottenChildren
);
_children
=
updateChildren
(
_children
,
widget
.
children
,
forgottenChildren:
_forgottenChildren
);
_forgottenChildren
.
clear
();
_forgottenChildren
.
clear
();
}
}
...
...
packages/flutter/test/widgets/framework_test.dart
View file @
3ab799bb
...
@@ -512,11 +512,9 @@ void main() {
...
@@ -512,11 +512,9 @@ void main() {
expect
(
expect
(
exception
.
toString
(),
exception
.
toString
(),
equalsIgnoringHashCodes
(
equalsIgnoringHashCodes
(
'Multiple widgets used the same GlobalKey.
\n
'
'Duplicate keys found.
\n
'
'The key [GlobalKey#00000 problematic] was used by 2 widgets:
\n
'
'If multiple keyed nodes exist as children of another node, they must have unique keys.
\n
'
' SizedBox-[GlobalKey#00000 problematic]
\n
'
'Stack(alignment: AlignmentDirectional.topStart, textDirection: ltr, fit: loose) has multiple children with key [GlobalKey#00000 problematic].'
' Placeholder-[GlobalKey#00000 problematic]
\n
'
'A GlobalKey can only be specified on one widget at a time in the widget tree.'
,
),
),
);
);
});
});
...
@@ -541,11 +539,9 @@ void main() {
...
@@ -541,11 +539,9 @@ void main() {
expect
(
expect
(
exception
.
toString
(),
exception
.
toString
(),
equalsIgnoringHashCodes
(
equalsIgnoringHashCodes
(
'Multiple widgets used the same GlobalKey.
\n
'
'Duplicate keys found.
\n
'
'The key [GlobalKey#00000 problematic] was used by 2 widgets:
\n
'
'If multiple keyed nodes exist as children of another node, they must have unique keys.
\n
'
' Container-[GlobalKey#00000 problematic]
\n
'
'Stack(alignment: AlignmentDirectional.topStart, textDirection: ltr, fit: loose) has multiple children with key [GlobalKey#00000 problematic].'
' Placeholder-[GlobalKey#00000 problematic]
\n
'
'A GlobalKey can only be specified on one widget at a time in the widget tree.'
,
),
),
);
);
});
});
...
...
packages/flutter/test/widgets/multichildobject_with_keys_test.dart
View file @
3ab799bb
...
@@ -58,6 +58,57 @@ void main() {
...
@@ -58,6 +58,57 @@ void main() {
<
String
>[
'0'
,
'6'
,
'7'
,
'8'
,
'1'
,
'2'
,
'3'
,
'4'
,
'5'
],
<
String
>[
'0'
,
'6'
,
'7'
,
'8'
,
'1'
,
'2'
,
'3'
,
'4'
,
'5'
],
);
);
});
});
testWidgets
(
'Building a new MultiChildRenderObjectElement with children having duplicated keys throws'
,
(
WidgetTester
tester
)
async
{
const
ValueKey
<
int
>
duplicatedKey
=
ValueKey
<
int
>(
1
);
await
tester
.
pumpWidget
(
Column
(
children:
const
<
Widget
>[
Text
(
'Text 1'
,
textDirection:
TextDirection
.
ltr
,
key:
duplicatedKey
),
Text
(
'Text 2'
,
textDirection:
TextDirection
.
ltr
,
key:
duplicatedKey
),
],
));
expect
(
tester
.
takeException
(),
isA
<
FlutterError
>().
having
(
(
FlutterError
error
)
=>
error
.
message
,
'error.message'
,
startsWith
(
'Duplicate keys found.'
),
),
);
});
testWidgets
(
'Updating a MultiChildRenderObjectElement to have children with duplicated keys throws'
,
(
WidgetTester
tester
)
async
{
// Regression test for https://github.com/flutter/flutter/issues/81541
const
ValueKey
<
int
>
key1
=
ValueKey
<
int
>(
1
);
const
ValueKey
<
int
>
key2
=
ValueKey
<
int
>(
2
);
Future
<
void
>
_buildWithKey
(
Key
key
)
{
return
tester
.
pumpWidget
(
Column
(
children:
<
Widget
>[
const
Text
(
'Text 1'
,
textDirection:
TextDirection
.
ltr
,
key:
key1
),
Text
(
'Text 2'
,
textDirection:
TextDirection
.
ltr
,
key:
key
),
],
));
}
// Initial build with two different keys.
await
_buildWithKey
(
key2
);
expect
(
tester
.
takeException
(),
isNull
);
// Subsequent build with duplicated keys.
await
_buildWithKey
(
key1
);
expect
(
tester
.
takeException
(),
isA
<
FlutterError
>().
having
(
(
FlutterError
error
)
=>
error
.
message
,
'error.message'
,
startsWith
(
'Duplicate keys found.'
),
),
);
});
}
}
// Do not use tester.renderObjectList(find.byType(RenderParagraph). That returns
// Do not use tester.renderObjectList(find.byType(RenderParagraph). That returns
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment