Unverified Commit 37a86c48 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

Revert "[flutter_tools] Put a heap size limit on the frontend_server" (#58525)

* Revert "[flutter_tools] Put a heap size limit on the frontend_server (#58039)"
parent 74a2e6a5
...@@ -263,11 +263,6 @@ class KernelCompiler { ...@@ -263,11 +263,6 @@ class KernelCompiler {
} }
final List<String> command = <String>[ final List<String> command = <String>[
engineDartPath, engineDartPath,
'--disable-dart-dev',
// This limit is in place to help track down
// https://github.com/flutter/flutter/issues/54420. It should be removed
// when the underlying issue is identified and fixed.
'--old_gen_heap_size=2000',
frontendServer, frontendServer,
'--sdk-root', '--sdk-root',
sdkRoot, sdkRoot,
...@@ -653,11 +648,6 @@ class DefaultResidentCompiler implements ResidentCompiler { ...@@ -653,11 +648,6 @@ class DefaultResidentCompiler implements ResidentCompiler {
); );
final List<String> command = <String>[ final List<String> command = <String>[
globals.artifacts.getArtifactPath(Artifact.engineDartBinary), globals.artifacts.getArtifactPath(Artifact.engineDartBinary),
'--disable-dart-dev',
// This limit is in place to help track down
// https://github.com/flutter/flutter/issues/54420. It should be removed
// when the underlying issue is identified and fixed.
'--old_gen_heap_size=2000',
frontendServer, frontendServer,
'--sdk-root', '--sdk-root',
sdkRoot, sdkRoot,
......
...@@ -86,8 +86,6 @@ void main() { ...@@ -86,8 +86,6 @@ void main() {
processManager = FakeProcessManager.list(<FakeCommand>[ processManager = FakeProcessManager.list(<FakeCommand>[
FakeCommand(command: <String>[ FakeCommand(command: <String>[
artifacts.getArtifactPath(Artifact.engineDartBinary), artifacts.getArtifactPath(Artifact.engineDartBinary),
'--disable-dart-dev',
'--old_gen_heap_size=2000',
artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk), artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
'--sdk-root', '--sdk-root',
artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/', artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/',
...@@ -117,8 +115,6 @@ void main() { ...@@ -117,8 +115,6 @@ void main() {
processManager = FakeProcessManager.list(<FakeCommand>[ processManager = FakeProcessManager.list(<FakeCommand>[
FakeCommand(command: <String>[ FakeCommand(command: <String>[
artifacts.getArtifactPath(Artifact.engineDartBinary), artifacts.getArtifactPath(Artifact.engineDartBinary),
'--disable-dart-dev',
'--old_gen_heap_size=2000',
artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk), artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
'--sdk-root', '--sdk-root',
artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/', artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/',
...@@ -148,8 +144,6 @@ void main() { ...@@ -148,8 +144,6 @@ void main() {
processManager = FakeProcessManager.list(<FakeCommand>[ processManager = FakeProcessManager.list(<FakeCommand>[
FakeCommand(command: <String>[ FakeCommand(command: <String>[
artifacts.getArtifactPath(Artifact.engineDartBinary), artifacts.getArtifactPath(Artifact.engineDartBinary),
'--disable-dart-dev',
'--old_gen_heap_size=2000',
artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk), artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
'--sdk-root', '--sdk-root',
artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/', artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/',
...@@ -180,8 +174,6 @@ void main() { ...@@ -180,8 +174,6 @@ void main() {
processManager = FakeProcessManager.list(<FakeCommand>[ processManager = FakeProcessManager.list(<FakeCommand>[
FakeCommand(command: <String>[ FakeCommand(command: <String>[
artifacts.getArtifactPath(Artifact.engineDartBinary), artifacts.getArtifactPath(Artifact.engineDartBinary),
'--disable-dart-dev',
'--old_gen_heap_size=2000',
artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk), artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
'--sdk-root', '--sdk-root',
artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/', artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/',
...@@ -214,8 +206,6 @@ void main() { ...@@ -214,8 +206,6 @@ void main() {
processManager = FakeProcessManager.list(<FakeCommand>[ processManager = FakeProcessManager.list(<FakeCommand>[
FakeCommand(command: <String>[ FakeCommand(command: <String>[
artifacts.getArtifactPath(Artifact.engineDartBinary), artifacts.getArtifactPath(Artifact.engineDartBinary),
'--disable-dart-dev',
'--old_gen_heap_size=2000',
artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk), artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
'--sdk-root', '--sdk-root',
artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/', artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/',
...@@ -246,8 +236,6 @@ void main() { ...@@ -246,8 +236,6 @@ void main() {
processManager = FakeProcessManager.list(<FakeCommand>[ processManager = FakeProcessManager.list(<FakeCommand>[
FakeCommand(command: <String>[ FakeCommand(command: <String>[
artifacts.getArtifactPath(Artifact.engineDartBinary), artifacts.getArtifactPath(Artifact.engineDartBinary),
'--disable-dart-dev',
'--old_gen_heap_size=2000',
artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk), artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
'--sdk-root', '--sdk-root',
artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/', artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/',
...@@ -290,8 +278,6 @@ void main() { ...@@ -290,8 +278,6 @@ void main() {
processManager = FakeProcessManager.list(<FakeCommand>[ processManager = FakeProcessManager.list(<FakeCommand>[
FakeCommand(command: <String>[ FakeCommand(command: <String>[
artifacts.getArtifactPath(Artifact.engineDartBinary), artifacts.getArtifactPath(Artifact.engineDartBinary),
'--disable-dart-dev',
'--old_gen_heap_size=2000',
artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk), artifacts.getArtifactPath(Artifact.frontendServerSnapshotForEngineDartSdk),
'--sdk-root', '--sdk-root',
artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/', artifacts.getArtifactPath(Artifact.flutterPatchedSdkPath) + '/',
......
...@@ -76,37 +76,6 @@ void main() { ...@@ -76,37 +76,6 @@ void main() {
Platform: kNoColorTerminalPlatform, Platform: kNoColorTerminalPlatform,
}); });
testUsingContext('passes VM heap size limit', () async {
when(mockFrontendServer.stdout)
.thenAnswer((Invocation invocation) => Stream<List<int>>.fromFuture(
Future<List<int>>.value(utf8.encode(
'result abc\nline1\nline2\nabc\nabc /path/to/main.dart.dill 0'
))
));
final KernelCompiler kernelCompiler = await kernelCompilerFactory.create(null);
final CompilerOutput output = await kernelCompiler.compile(sdkRoot: '/path/to/sdkroot',
mainPath: '/path/to/main.dart',
buildMode: BuildMode.debug,
trackWidgetCreation: false,
dartDefines: const <String>[],
packageConfig: PackageConfig.empty,
packagesPath: '.packages',
);
expect(mockFrontendServerStdIn.getAndClear(), isEmpty);
expect(testLogger.errorText, equals('\nCompiler message:\nline1\nline2\n'));
expect(output.outputFilename, equals('/path/to/main.dart.dill'));
final VerificationResult argVerification = verify(mockProcessManager.start(captureAny));
expect(argVerification.captured.single, containsAll(<String>[
'--disable-dart-dev',
'--old_gen_heap_size=2000',
]));
}, overrides: <Type, Generator>{
ProcessManager: () => mockProcessManager,
OutputPreferences: () => OutputPreferences(showColor: false),
Platform: kNoColorTerminalPlatform,
});
testUsingContext('passes correct AOT config to kernel compiler in aot/profile mode', () async { testUsingContext('passes correct AOT config to kernel compiler in aot/profile mode', () async {
when(mockFrontendServer.stdout) when(mockFrontendServer.stdout)
.thenAnswer((Invocation invocation) => Stream<List<int>>.fromFuture( .thenAnswer((Invocation invocation) => Stream<List<int>>.fromFuture(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment