Unverified Commit 377dfbd9 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

dont fail build if codegen fails (#29818)

parent 91b71ba9
...@@ -5,7 +5,6 @@ ...@@ -5,7 +5,6 @@
import 'package:meta/meta.dart'; import 'package:meta/meta.dart';
import 'artifacts.dart'; import 'artifacts.dart';
import 'base/common.dart';
import 'base/context.dart'; import 'base/context.dart';
import 'base/file_system.dart'; import 'base/file_system.dart';
import 'base/platform.dart'; import 'base/platform.dart';
...@@ -109,7 +108,8 @@ class CodeGeneratingKernelCompiler implements KernelCompiler { ...@@ -109,7 +108,8 @@ class CodeGeneratingKernelCompiler implements KernelCompiler {
codegenDaemon.startBuild(); codegenDaemon.startBuild();
await for (CodegenStatus codegenStatus in codegenDaemon.buildResults) { await for (CodegenStatus codegenStatus in codegenDaemon.buildResults) {
if (codegenStatus == CodegenStatus.Failed) { if (codegenStatus == CodegenStatus.Failed) {
throwToolExit('Code generation failed'); printError('Code generation failed, build may have compile errors.');
break;
} }
if (codegenStatus == CodegenStatus.Succeeded) { if (codegenStatus == CodegenStatus.Succeeded) {
break; break;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment