Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3712ea63
Unverified
Commit
3712ea63
authored
Sep 12, 2019
by
Emmanuel Garcia
Committed by
GitHub
Sep 12, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Flip the default for proguard (#40282)
parent
07dad466
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
8 additions
and
2 deletions
+8
-2
build_apk.dart
packages/flutter_tools/lib/src/commands/build_apk.dart
+1
-1
build_appbundle.dart
packages/flutter_tools/lib/src/commands/build_appbundle.dart
+1
-1
build_apk_test.dart
...ter_tools/test/general.shard/commands/build_apk_test.dart
+3
-0
build_appbundle_test.dart
...ols/test/general.shard/commands/build_appbundle_test.dart
+3
-0
No files found.
packages/flutter_tools/lib/src/commands/build_apk.dart
View file @
3712ea63
...
@@ -30,7 +30,7 @@ class BuildApkCommand extends BuildSubCommand {
...
@@ -30,7 +30,7 @@ class BuildApkCommand extends BuildSubCommand {
)
)
..
addFlag
(
'proguard'
,
..
addFlag
(
'proguard'
,
negatable:
true
,
negatable:
true
,
defaultsTo:
tru
e
,
defaultsTo:
fals
e
,
help:
'Whether to enable Proguard on release mode. '
help:
'Whether to enable Proguard on release mode. '
'To learn more, see: https://flutter.dev/docs/deployment/android#enabling-proguard'
,
'To learn more, see: https://flutter.dev/docs/deployment/android#enabling-proguard'
,
)
)
...
...
packages/flutter_tools/lib/src/commands/build_appbundle.dart
View file @
3712ea63
...
@@ -24,7 +24,7 @@ class BuildAppBundleCommand extends BuildSubCommand {
...
@@ -24,7 +24,7 @@ class BuildAppBundleCommand extends BuildSubCommand {
..
addFlag
(
'track-widget-creation'
,
negatable:
false
,
hide:
!
verboseHelp
)
..
addFlag
(
'track-widget-creation'
,
negatable:
false
,
hide:
!
verboseHelp
)
..
addFlag
(
'proguard'
,
..
addFlag
(
'proguard'
,
negatable:
true
,
negatable:
true
,
defaultsTo:
tru
e
,
defaultsTo:
fals
e
,
help:
'Whether to enable Proguard on release mode. '
help:
'Whether to enable Proguard on release mode. '
'To learn more, see: https://flutter.dev/docs/deployment/android#enabling-proguard'
,
'To learn more, see: https://flutter.dev/docs/deployment/android#enabling-proguard'
,
)
)
...
...
packages/flutter_tools/test/general.shard/commands/build_apk_test.dart
View file @
3712ea63
...
@@ -165,6 +165,7 @@ void main() {
...
@@ -165,6 +165,7 @@ void main() {
GradleUtils:
()
=>
GradleUtils
(),
GradleUtils:
()
=>
GradleUtils
(),
ProcessManager:
()
=>
mockProcessManager
,
ProcessManager:
()
=>
mockProcessManager
,
},
},
skip:
true
,
timeout:
allowForCreateFlutterProject
);
timeout:
allowForCreateFlutterProject
);
testUsingContext
(
'proguard is disabled when --no-proguard is passed'
,
()
async
{
testUsingContext
(
'proguard is disabled when --no-proguard is passed'
,
()
async
{
...
@@ -197,6 +198,7 @@ void main() {
...
@@ -197,6 +198,7 @@ void main() {
GradleUtils:
()
=>
GradleUtils
(),
GradleUtils:
()
=>
GradleUtils
(),
ProcessManager:
()
=>
mockProcessManager
,
ProcessManager:
()
=>
mockProcessManager
,
},
},
skip:
true
,
timeout:
allowForCreateFlutterProject
);
timeout:
allowForCreateFlutterProject
);
testUsingContext
(
'guides the user when proguard fails'
,
()
async
{
testUsingContext
(
'guides the user when proguard fails'
,
()
async
{
...
@@ -255,6 +257,7 @@ void main() {
...
@@ -255,6 +257,7 @@ void main() {
ProcessManager:
()
=>
mockProcessManager
,
ProcessManager:
()
=>
mockProcessManager
,
Usage:
()
=>
mockUsage
,
Usage:
()
=>
mockUsage
,
},
},
skip:
true
,
timeout:
allowForCreateFlutterProject
);
timeout:
allowForCreateFlutterProject
);
});
});
}
}
...
...
packages/flutter_tools/test/general.shard/commands/build_appbundle_test.dart
View file @
3712ea63
...
@@ -152,6 +152,7 @@ void main() {
...
@@ -152,6 +152,7 @@ void main() {
GradleUtils:
()
=>
GradleUtils
(),
GradleUtils:
()
=>
GradleUtils
(),
ProcessManager:
()
=>
mockProcessManager
,
ProcessManager:
()
=>
mockProcessManager
,
},
},
skip:
true
,
timeout:
allowForCreateFlutterProject
);
timeout:
allowForCreateFlutterProject
);
testUsingContext
(
'proguard is disabled when --no-proguard is passed'
,
()
async
{
testUsingContext
(
'proguard is disabled when --no-proguard is passed'
,
()
async
{
...
@@ -186,6 +187,7 @@ void main() {
...
@@ -186,6 +187,7 @@ void main() {
GradleUtils:
()
=>
GradleUtils
(),
GradleUtils:
()
=>
GradleUtils
(),
ProcessManager:
()
=>
mockProcessManager
,
ProcessManager:
()
=>
mockProcessManager
,
},
},
skip:
true
,
timeout:
allowForCreateFlutterProject
);
timeout:
allowForCreateFlutterProject
);
testUsingContext
(
'guides the user when proguard fails'
,
()
async
{
testUsingContext
(
'guides the user when proguard fails'
,
()
async
{
...
@@ -244,6 +246,7 @@ void main() {
...
@@ -244,6 +246,7 @@ void main() {
ProcessManager:
()
=>
mockProcessManager
,
ProcessManager:
()
=>
mockProcessManager
,
Usage:
()
=>
mockUsage
,
Usage:
()
=>
mockUsage
,
},
},
skip:
true
,
timeout:
allowForCreateFlutterProject
);
timeout:
allowForCreateFlutterProject
);
});
});
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment