Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
33e61d1c
Commit
33e61d1c
authored
Jan 28, 2020
by
Jonah Williams
Committed by
Flutter GitHub Bot
Jan 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] open chrome with unresolve hostname (#49625)
parent
6f0136cc
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
3 additions
and
15 deletions
+3
-15
web_fs.dart
packages/flutter_tools/lib/src/build_runner/web_fs.dart
+1
-4
devfs_web.dart
packages/flutter_tools/lib/src/web/devfs_web.dart
+1
-7
web_fs_test.dart
...ges/flutter_tools/test/general.shard/web/web_fs_test.dart
+1
-4
No files found.
packages/flutter_tools/lib/src/build_runner/web_fs.dart
View file @
33e61d1c
...
...
@@ -340,10 +340,7 @@ class WebFs {
client
,
server
,
dwds
,
// Format ipv6 hosts according to RFC 5952.
internetAddress
.
type
==
InternetAddressType
.
IPv4
?
'http://
${internetAddress.address}
:
$hostPort
'
:
'http://[
${internetAddress.address}
]:
$hostPort
'
,
'http://
$effectiveHostname
:
$hostPort
'
,
assetServer
,
buildInfo
.
isDebug
,
flutterProject
,
...
...
packages/flutter_tools/lib/src/web/devfs_web.dart
View file @
33e61d1c
...
...
@@ -276,13 +276,7 @@ class WebDevFS implements DevFS {
@override
Future
<
Uri
>
create
()
async
{
_webAssetServer
=
await
WebAssetServer
.
start
(
hostname
,
port
);
final
InternetAddress
internetAddress
=
_webAssetServer
.
internetAddress
;
// Format ipv6 hosts according to RFC 5952.
return
Uri
.
parse
(
internetAddress
.
type
==
InternetAddressType
.
IPv4
?
'http://
${internetAddress.address}
:
$port
'
:
'http://[
${internetAddress.address}
]:
$port
'
);
return
Uri
.
parse
(
'http://
$hostname
:
$port
'
);
}
@override
...
...
packages/flutter_tools/test/general.shard/web/web_fs_test.dart
View file @
33e61d1c
...
...
@@ -181,10 +181,7 @@ void main() {
dartDefines:
const
<
String
>[],
);
// Might be either ipv4 or ipv6 for localhost.
final
bool
hasExpectedUri
=
webFs
.
uri
.
toString
().
contains
(
'[::1]:1234'
)
||
webFs
.
uri
.
toString
().
contains
(
'127.0.0.1:1234'
);
expect
(
hasExpectedUri
,
true
);
expect
(
webFs
.
uri
.
toString
(),
contains
(
'localhost'
));
expect
(
lastPort
,
1234
);
}));
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment