Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
325bfcc7
Commit
325bfcc7
authored
Aug 04, 2015
by
Adam Barth
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix RenderViewport's hit testing
We were subtracting the scrollOffset when we were supposed to add it.
parent
78e18a5d
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
3 additions
and
3 deletions
+3
-3
box.dart
packages/flutter/lib/rendering/box.dart
+3
-3
No files found.
packages/flutter/lib/rendering/box.dart
View file @
325bfcc7
...
@@ -1240,11 +1240,11 @@ class RenderViewport extends RenderBox with RenderObjectWithChildMixin<RenderBox
...
@@ -1240,11 +1240,11 @@ class RenderViewport extends RenderBox with RenderObjectWithChildMixin<RenderBox
if
(
child
!=
null
)
{
if
(
child
!=
null
)
{
assert
(
child
.
parentData
is
BoxParentData
);
assert
(
child
.
parentData
is
BoxParentData
);
Rect
childBounds
=
child
.
parentData
.
position
&
child
.
size
;
Rect
childBounds
=
child
.
parentData
.
position
&
child
.
size
;
if
(
childBounds
.
contains
(
position
+
-
scrollOffset
))
Point
transformedPosition
=
position
+
scrollOffset
;
child
.
hitTest
(
result
,
position:
position
+
scrollOffset
);
if
(
childBounds
.
contains
(
transformedPosition
))
child
.
hitTest
(
result
,
position:
transformedPosition
);
}
}
}
}
}
}
class
RenderImage
extends
RenderBox
{
class
RenderImage
extends
RenderBox
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment