Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3236957f
Unverified
Commit
3236957f
authored
Mar 19, 2024
by
goodmost
Committed by
GitHub
Mar 19, 2024
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
chore: fix some comments (#145397)
fix some comments
parent
28498fe1
Changes
12
Hide whitespace changes
Inline
Side-by-side
Showing
12 changed files
with
19 additions
and
19 deletions
+19
-19
main_test.dart
...n_tests/android_verified_input/test_driver/main_test.dart
+1
-1
README.md
dev/integration_tests/external_textures/README.md
+1
-1
text_editing_controller.1_test.dart
...widgets/editable_text/text_editing_controller.1_test.dart
+1
-1
date_picker.dart
packages/flutter/lib/src/cupertino/date_picker.dart
+1
-1
date_picker_theme.dart
packages/flutter/lib/src/material/date_picker_theme.dart
+1
-1
radio_list_tile.dart
packages/flutter/lib/src/material/radio_list_tile.dart
+1
-1
time_picker_theme.dart
packages/flutter/lib/src/material/time_picker_theme.dart
+2
-2
box.dart
packages/flutter/lib/src/rendering/box.dart
+2
-2
lookup_boundary_test.dart
packages/flutter/test/widgets/lookup_boundary_test.dart
+1
-1
generate_localizations_test.dart
...tools/test/general.shard/generate_localizations_test.dart
+2
-2
xcode_debug_test.dart
...lutter_tools/test/general.shard/ios/xcode_debug_test.dart
+5
-5
native_assets_host_test.dart
...general.shard/isolated/macos/native_assets_host_test.dart
+1
-1
No files found.
dev/integration_tests/android_verified_input/test_driver/main_test.dart
View file @
3236957f
...
...
@@ -28,7 +28,7 @@ Future<void> main() async {
// to be verified.
final
Future
<
String
>
inputEventWasVerified
=
driver
.
requestData
(
'input_was_verified'
);
// Keep issu
e
ing taps until we get the requested data. The actual setup
// Keep issuing taps until we get the requested data. The actual setup
// of the platform view is asynchronous so we might have to tap more than
// once to get a response.
bool
stop
=
false
;
...
...
dev/integration_tests/external_textures/README.md
View file @
3236957f
...
...
@@ -24,7 +24,7 @@ subtle translation issues.
## How it works
-
Each
`lib/*_main.dart`
file is a Flutter app instrumenting a test case.
-
There is a co
o
responding
`test_driver/*_test.dart`
that runs assertions.
-
There is a co
r
responding
`test_driver/*_test.dart`
that runs assertions.
To run the test cases locally, use
`flutter drive`
[
^2
]
:
...
...
examples/api/test/widgets/editable_text/text_editing_controller.1_test.dart
View file @
3236957f
...
...
@@ -7,7 +7,7 @@ import 'package:flutter_api_samples/widgets/editable_text/text_editing_controlle
import
'package:flutter_test/flutter_test.dart'
;
void
main
(
)
{
testWidgets
(
'Initial selection is colla
sp
ed at offset 0'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'Initial selection is colla
ps
ed at offset 0'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
const
example
.
TextEditingControllerExampleApp
(),
);
...
...
packages/flutter/lib/src/cupertino/date_picker.dart
View file @
3236957f
...
...
@@ -405,7 +405,7 @@ class CupertinoDatePicker extends StatefulWidget {
/// Defaults to null, which disables background painting entirely.
final
Color
?
backgroundColor
;
/// Whether to
to
show day of week alongside day. Defaults to false.
/// Whether to show day of week alongside day. Defaults to false.
final
bool
showDayOfWeek
;
/// {@macro flutter.cupertino.picker.itemExtent}
...
...
packages/flutter/lib/src/material/date_picker_theme.dart
View file @
3236957f
...
...
@@ -333,7 +333,7 @@ class DatePickerThemeData with Diagnosticable {
final
MaterialStateProperty
<
Color
?>?
rangeSelectionOverlayColor
;
/// Overrides the default color used to paint the horizontal divider
/// below the header text when dialog is in
in
portrait orientation
/// below the header text when dialog is in portrait orientation
/// and vertical divider when the dialog is in landscape orientation.
final
Color
?
dividerColor
;
...
...
packages/flutter/lib/src/material/radio_list_tile.dart
View file @
3236957f
...
...
@@ -35,7 +35,7 @@ enum _RadioType { material, adaptive }
///
/// The [selected] property on this widget is similar to the [ListTile.selected]
/// property. The [fillColor] in the selected state is used for the selected item's
/// text color. I
t
it is null, the [activeColor] is used.
/// text color. I
f
it is null, the [activeColor] is used.
///
/// This widget does not coordinate the [selected] state and the
/// [checked] state; to have the list tile appear selected when the
...
...
packages/flutter/lib/src/material/time_picker_theme.dart
View file @
3236957f
...
...
@@ -271,7 +271,7 @@ class TimePickerThemeData with Diagnosticable {
/// `RoundedRectangleBorder(borderRadius: BorderRadius.all(Radius.circular(4.0)))`.
final
ShapeBorder
?
shape
;
/// The color of the time selector sep
e
rator between the hour and minute controls.
/// The color of the time selector sep
a
rator between the hour and minute controls.
///
/// if this is null, the time picker defaults to the overall theme's
/// [ColorScheme.onSurface].
...
...
@@ -280,7 +280,7 @@ class TimePickerThemeData with Diagnosticable {
/// [hourMinuteTextColor].
final
MaterialStateProperty
<
Color
?>?
timeSelectorSeparatorColor
;
/// Used to configure the text style for the time selector sep
e
rator between the hour
/// Used to configure the text style for the time selector sep
a
rator between the hour
/// and minute controls.
///
/// If this is null, the time picker defaults to the overall theme's
...
...
packages/flutter/lib/src/rendering/box.dart
View file @
3236957f
...
...
@@ -2074,11 +2074,11 @@ abstract class RenderBox extends RenderObject {
/// would results in UI changes when [paint] is called, or hit-testing behavior
/// changes when [hitTest] is called. Moreover, accessing the current layout
/// of this [RenderBox] or child [RenderBox]es (including accessing [size], or
/// `child.size`) usually indicates a bug in the implementaion, as the current
/// `child.size`) usually indicates a bug in the implementa
t
ion, as the current
/// layout is typically calculated using a set of [BoxConstraints] that's
/// different from the `constraints` given as the first parameter. To get the
/// size of this [RenderBox] or a child [RenderBox] in this method's
/// implementatin, use the [getDryLayout] method instead.
/// implementati
o
n, use the [getDryLayout] method instead.
///
/// The implementation must return a value that represents the distance from
/// the top of the box to the first baseline of the box's contents, for the
...
...
packages/flutter/test/widgets/lookup_boundary_test.dart
View file @
3236957f
...
...
@@ -173,7 +173,7 @@ void main() {
expect
(
tester
.
state
<
_DidChangeDependencySpyState
>(
find
.
byType
(
DidChangeDependencySpy
)).
didChangeDependenciesCount
,
3
);
});
testWidgets
(
'causes didChangeDependencies to be called on move even if dependency was non-exist
a
nt'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'causes didChangeDependencies to be called on move even if dependency was non-exist
e
nt'
,
(
WidgetTester
tester
)
async
{
MyInheritedWidget
?
inheritedWidget
;
final
Key
globalKey
=
GlobalKey
();
...
...
packages/flutter_tools/test/general.shard/generate_localizations_test.dart
View file @
3236957f
...
...
@@ -2522,10 +2522,10 @@ NumberFormat.decimalPatternDigits(
testWithoutContext('
dollar
signs
are
escaped
properly
when
there
is
a
select
clause
', () {
const String dollarSignWithSelect = r'''
{
"dollarSignWithSelect"
:
"
$nice_bug
\n
Hello Bug! Manif
i
station #1 {selectPlaceholder, select, case{message} other{messageOther}}"
"dollarSignWithSelect"
:
"
$nice_bug
\n
Hello Bug! Manif
e
station #1 {selectPlaceholder, select, case{message} other{messageOther}}"
}
''';
setupLocalizations(<String, String>{ '
en
': dollarSignWithSelect });
expect(getGeneratedFileContent(locale: '
en
'), contains(r'
\
$nice_bug
\
nHello
Bug
!
Manif
i
station
#
1
$_temp0
'));
expect(getGeneratedFileContent(locale: '
en
'), contains(r'
\
$nice_bug
\
nHello
Bug
!
Manif
e
station
#
1
$_temp0
'));
});
testWithoutContext('
can
generate
method
with
named
parameter
', () {
...
...
packages/flutter_tools/test/general.shard/ios/xcode_debug_test.dart
View file @
3236957f
...
...
@@ -275,13 +275,13 @@ void main() {
'open'
,
<
String
>[
'-a'
,
'/non_exist
a
nt_path'
,
'/non_exist
e
nt_path'
,
'-g'
,
'-j'
,
'-F'
,
xcworkspace
.
path
,
],
'The application /non_exist
a
nt_path cannot be opened for an unexpected reason'
,
'The application /non_exist
e
nt_path cannot be opened for an unexpected reason'
,
),
),
]);
...
...
@@ -304,7 +304,7 @@ void main() {
expect
(
logger
.
errorText
,
contains
(
'The application /non_exist
a
nt_path cannot be opened for an unexpected reason'
),
contains
(
'The application /non_exist
e
nt_path cannot be opened for an unexpected reason'
),
);
expect
(
fakeProcessManager
,
hasNoRemainingExpectations
);
expect
(
status
,
false
);
...
...
@@ -807,7 +807,7 @@ void main() {
expect
(
status
,
isTrue
);
});
testWithoutContext
(
'prints error message when deleting temporary directory that is nonexist
a
nt'
,
()
async
{
testWithoutContext
(
'prints error message when deleting temporary directory that is nonexist
e
nt'
,
()
async
{
final
Xcode
xcode
=
setupXcode
(
fakeProcessManager:
fakeProcessManager
,
fileSystem:
fileSystem
,
...
...
@@ -914,7 +914,7 @@ void main() {
expect
(
exitStatus
,
isTrue
);
});
testWithoutContext
(
'does not crash when deleting temporary directory that is nonexist
a
nt when force exiting'
,
()
async
{
testWithoutContext
(
'does not crash when deleting temporary directory that is nonexist
e
nt when force exiting'
,
()
async
{
final
Xcode
xcode
=
setupXcode
(
fakeProcessManager:
FakeProcessManager
.
any
(),
fileSystem:
fileSystem
,
...
...
packages/flutter_tools/test/general.shard/isolated/macos/native_assets_host_test.dart
View file @
3236957f
...
...
@@ -38,7 +38,7 @@ void main() {
);
});
test
(
'framework name
name confi
licts'
,
()
{
test
(
'framework name
conf
licts'
,
()
{
final
Set
<
String
>
alreadyTakenNames
=
<
String
>{};
expect
(
frameworkUri
(
'libfoo.dylib'
,
alreadyTakenNames
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment