Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3145c835
Unverified
Commit
3145c835
authored
Nov 05, 2020
by
Jenn Magder
Committed by
GitHub
Nov 05, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Deprecate build ios-framework --universal (#69720)
parent
ae0a9cb5
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
8 deletions
+15
-8
build_ios_framework_module_test.dart
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
+2
-1
build_ios_framework.dart
...s/flutter_tools/lib/src/commands/build_ios_framework.dart
+13
-7
No files found.
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
View file @
3145c835
...
@@ -67,7 +67,7 @@ Future<void> main() async {
...
@@ -67,7 +67,7 @@ Future<void> main() async {
'build'
,
'build'
,
options:
<
String
>[
options:
<
String
>[
'ios-framework'
,
'ios-framework'
,
'--
xcframework
'
,
'--
universal
'
,
'--output=
$outputDirectoryName
'
'--output=
$outputDirectoryName
'
],
],
);
);
...
@@ -352,6 +352,7 @@ Future<void> main() async {
...
@@ -352,6 +352,7 @@ Future<void> main() async {
options:
<
String
>[
options:
<
String
>[
'ios-framework'
,
'ios-framework'
,
'--cocoapods'
,
'--cocoapods'
,
'--universal'
,
'--force'
,
// Allow podspec creation on master.
'--force'
,
// Allow podspec creation on master.
'--output=
$cocoapodsOutputDirectoryName
'
'--output=
$cocoapodsOutputDirectoryName
'
],
],
...
...
packages/flutter_tools/lib/src/commands/build_ios_framework.dart
View file @
3145c835
...
@@ -74,16 +74,17 @@ class BuildIOSFrameworkCommand extends BuildSubCommand {
...
@@ -74,16 +74,17 @@ class BuildIOSFrameworkCommand extends BuildSubCommand {
'By default, all build configurations are built.'
'By default, all build configurations are built.'
)
)
..
addFlag
(
'universal'
,
..
addFlag
(
'universal'
,
help:
'Produce universal frameworks that include all valid architectures. '
help:
'
(Deprecated)
Produce universal frameworks that include all valid architectures. '
'This
is true by default
.'
,
'This
option will be removed in a future version of Flutter
.'
,
defaultsTo
:
true
,
negatable
:
true
,
negatable:
true
hide:
true
,
)
)
..
addFlag
(
'xcframework'
,
..
addFlag
(
'xcframework'
,
help:
'Produce xcframeworks that include all valid architectures (Xcode 11 or later).'
,
help:
'Produce xcframeworks that include all valid architectures.'
,
defaultsTo:
true
,
)
)
..
addFlag
(
'cocoapods'
,
..
addFlag
(
'cocoapods'
,
help:
'Produce a Flutter.podspec instead of an engine Flutter.framework (recommended if host app uses CocoaPods).'
,
help:
'Produce a Flutter.podspec instead of an engine Flutter.
xc
framework (recommended if host app uses CocoaPods).'
,
)
)
..
addOption
(
'output'
,
..
addOption
(
'output'
,
abbr:
'o'
,
abbr:
'o'
,
...
@@ -152,11 +153,16 @@ class BuildIOSFrameworkCommand extends BuildSubCommand {
...
@@ -152,11 +153,16 @@ class BuildIOSFrameworkCommand extends BuildSubCommand {
}
}
if
(!
boolArg
(
'universal'
)
&&
!
boolArg
(
'xcframework'
))
{
if
(!
boolArg
(
'universal'
)
&&
!
boolArg
(
'xcframework'
))
{
throwToolExit
(
'--
universal or --xcframework
is required.'
);
throwToolExit
(
'--
xcframework or --universal
is required.'
);
}
}
if
(
boolArg
(
'xcframework'
)
&&
globals
.
xcode
.
majorVersion
<
11
)
{
if
(
boolArg
(
'xcframework'
)
&&
globals
.
xcode
.
majorVersion
<
11
)
{
throwToolExit
(
'--xcframework requires Xcode 11.'
);
throwToolExit
(
'--xcframework requires Xcode 11.'
);
}
}
if
(
boolArg
(
'universal'
))
{
globals
.
printError
(
'--universal has been deprecated to support Apple '
'Silicon ARM simulators and will be removed in a future version of '
'Flutter. Use --xcframework instead.'
);
}
if
(
buildInfos
.
isEmpty
)
{
if
(
buildInfos
.
isEmpty
)
{
throwToolExit
(
'At least one of "--debug" or "--profile", or "--release" is required.'
);
throwToolExit
(
'At least one of "--debug" or "--profile", or "--release" is required.'
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment