[flutter_tools] Remove --enable-background-compilation (#94012)

packages/flutter_tools/lib/src/android/android_device.dart

@@ -629,7 +629,6 @@ class AndroidDevice extends Device {
       'shell', 'am', 'start',
       '-a', 'android.intent.action.RUN',
       '-f', '0x20000000', // FLAG_ACTIVITY_SINGLE_TOP
-      '--ez', 'enable-background-compilation', 'true',
       '--ez', 'enable-dart-profiling', 'true',
       if (traceStartup)
         ...<String>['--ez', 'trace-startup', 'true'],

packages/flutter_tools/lib/src/custom_devices/custom_device.dart

@@ -280,7 +280,7 @@ class CustomDeviceAppSession {
   /// [debuggingOptions] and [route] can be null.
   ///
   /// For example, `_getEngineOptions(null, false, null)` will return
-  /// `['enable-dart-profiling=true', 'enable-background-compilation=true']`
+  /// `['enable-dart-profiling=true']`
   List<String> _getEngineOptions(DebuggingOptions debuggingOptions, bool traceStartup, String? route) {
     final List<String> options = <String>[];
 
@@ -289,7 +289,6 @@ class CustomDeviceAppSession {
     }
 
     addFlag('enable-dart-profiling=true');
-    addFlag('enable-background-compilation=true');
 
     if (traceStartup) {
       addFlag('trace-startup=true');
@@ -363,7 +362,7 @@ class CustomDeviceAppSession {
   /// [debuggingOptions] and [route] can be null.
   ///
   /// For example, `_getEngineOptionsForCmdline(null, false, null)` will return
-  /// `--enable-dart-profiling=true --enable-background-compilation=true`
+  /// `--enable-dart-profiling=true`
   String _getEngineOptionsForCmdline(DebuggingOptions debuggingOptions, bool traceStartup, String? route) {
     return _getEngineOptions(debuggingOptions, traceStartup, route).map((String e) => '--$e').join(' ');
   }

packages/flutter_tools/lib/src/desktop_device.dart

@@ -235,7 +235,6 @@ abstract class DesktopDevice extends Device {
     }
 
     addFlag('enable-dart-profiling=true');
-    addFlag('enable-background-compilation=true');
 
     if (traceStartup) {
       addFlag('trace-startup=true');

packages/flutter_tools/test/general.shard/android/android_device_start_test.dart

@@ -103,7 +103,6 @@ void main() {
           'android.intent.action.RUN',
           '-f',
           '0x20000000',
-          '--ez', 'enable-background-compilation', 'true',
           '--ez', 'enable-dart-profiling', 'true',
           'FlutterActivity',
         ],
@@ -231,7 +230,6 @@ void main() {
         '-f',
         '0x20000000',
         // The DebuggingOptions arguments go here.
-        '--ez', 'enable-background-compilation', 'true',
         '--ez', 'enable-dart-profiling', 'true',
         '--ez', 'enable-software-rendering', 'true',
         '--ez', 'skia-deterministic-rendering', 'true',

packages/flutter_tools/test/general.shard/desktop_device_test.dart

@@ -144,26 +144,25 @@ void main() {
         completer: completer,
         environment: const <String, String>{
           'FLUTTER_ENGINE_SWITCH_1': 'enable-dart-profiling=true',
-          'FLUTTER_ENGINE_SWITCH_2': 'enable-background-compilation=true',
-          'FLUTTER_ENGINE_SWITCH_3': 'trace-startup=true',
-          'FLUTTER_ENGINE_SWITCH_4': 'enable-software-rendering=true',
-          'FLUTTER_ENGINE_SWITCH_5': 'skia-deterministic-rendering=true',
-          'FLUTTER_ENGINE_SWITCH_6': 'trace-skia=true',
-          'FLUTTER_ENGINE_SWITCH_7': 'trace-allowlist=foo,bar',
-          'FLUTTER_ENGINE_SWITCH_8': 'trace-skia-allowlist=skia.a,skia.b',
-          'FLUTTER_ENGINE_SWITCH_9': 'trace-systrace=true',
-          'FLUTTER_ENGINE_SWITCH_10': 'endless-trace-buffer=true',
-          'FLUTTER_ENGINE_SWITCH_11': 'dump-skp-on-shader-compilation=true',
-          'FLUTTER_ENGINE_SWITCH_12': 'cache-sksl=true',
-          'FLUTTER_ENGINE_SWITCH_13': 'purge-persistent-cache=true',
-          'FLUTTER_ENGINE_SWITCH_14': 'enable-checked-mode=true',
-          'FLUTTER_ENGINE_SWITCH_15': 'verify-entry-points=true',
-          'FLUTTER_ENGINE_SWITCH_16': 'start-paused=true',
-          'FLUTTER_ENGINE_SWITCH_17': 'disable-service-auth-codes=true',
-          'FLUTTER_ENGINE_SWITCH_18': 'dart-flags=--null_assertions',
-          'FLUTTER_ENGINE_SWITCH_19': 'use-test-fonts=true',
-          'FLUTTER_ENGINE_SWITCH_20': 'verbose-logging=true',
-          'FLUTTER_ENGINE_SWITCHES': '20'
+          'FLUTTER_ENGINE_SWITCH_2': 'trace-startup=true',
+          'FLUTTER_ENGINE_SWITCH_3': 'enable-software-rendering=true',
+          'FLUTTER_ENGINE_SWITCH_4': 'skia-deterministic-rendering=true',
+          'FLUTTER_ENGINE_SWITCH_5': 'trace-skia=true',
+          'FLUTTER_ENGINE_SWITCH_6': 'trace-allowlist=foo,bar',
+          'FLUTTER_ENGINE_SWITCH_7': 'trace-skia-allowlist=skia.a,skia.b',
+          'FLUTTER_ENGINE_SWITCH_8': 'trace-systrace=true',
+          'FLUTTER_ENGINE_SWITCH_9': 'endless-trace-buffer=true',
+          'FLUTTER_ENGINE_SWITCH_10': 'dump-skp-on-shader-compilation=true',
+          'FLUTTER_ENGINE_SWITCH_11': 'cache-sksl=true',
+          'FLUTTER_ENGINE_SWITCH_12': 'purge-persistent-cache=true',
+          'FLUTTER_ENGINE_SWITCH_13': 'enable-checked-mode=true',
+          'FLUTTER_ENGINE_SWITCH_14': 'verify-entry-points=true',
+          'FLUTTER_ENGINE_SWITCH_15': 'start-paused=true',
+          'FLUTTER_ENGINE_SWITCH_16': 'disable-service-auth-codes=true',
+          'FLUTTER_ENGINE_SWITCH_17': 'dart-flags=--null_assertions',
+          'FLUTTER_ENGINE_SWITCH_18': 'use-test-fonts=true',
+          'FLUTTER_ENGINE_SWITCH_19': 'verbose-logging=true',
+          'FLUTTER_ENGINE_SWITCHES': '19'
         }
       ),
     ]);
@@ -207,11 +206,10 @@ void main() {
         completer: completer,
         environment: const <String, String>{
           'FLUTTER_ENGINE_SWITCH_1': 'enable-dart-profiling=true',
-          'FLUTTER_ENGINE_SWITCH_2': 'enable-background-compilation=true',
-          'FLUTTER_ENGINE_SWITCH_3': 'trace-startup=true',
-          'FLUTTER_ENGINE_SWITCH_4': 'trace-allowlist=foo,bar',
-          'FLUTTER_ENGINE_SWITCH_5': 'cache-sksl=true',
-          'FLUTTER_ENGINE_SWITCHES': '5'
+          'FLUTTER_ENGINE_SWITCH_2': 'trace-startup=true',
+          'FLUTTER_ENGINE_SWITCH_3': 'trace-allowlist=foo,bar',
+          'FLUTTER_ENGINE_SWITCH_4': 'cache-sksl=true',
+          'FLUTTER_ENGINE_SWITCHES': '4'
         }
       ),
     ]);