Unverified Commit 2e8c3468 authored by Tim Maffett's avatar Tim Maffett Committed by GitHub

fix devtool instructional messages after `flutter build ... --analyze-size `. ...

fix devtool instructional messages after `flutter build ... --analyze-size `.  Fixes #122229 (#122230)

fix devtool instructional messages after `flutter build ... --analyze-size `.  Fixes #122229
parent 01367d52
...@@ -550,8 +550,7 @@ class AndroidGradleBuilder implements AndroidBuilder { ...@@ -550,8 +550,7 @@ class AndroidGradleBuilder implements AndroidBuilder {
.trim(); .trim();
_logger.printStatus( _logger.printStatus(
'\nTo analyze your app size in Dart DevTools, run the following command:\n' '\nTo analyze your app size in Dart DevTools, run the following command:\n'
'flutter pub global activate devtools; flutter pub global run devtools ' 'dart devtools --appSizeBase=$relativeAppSizePath'
'--appSizeBase=$relativeAppSizePath'
); );
} }
......
...@@ -716,8 +716,7 @@ abstract class _BuildIOSSubCommand extends BuildSubCommand { ...@@ -716,8 +716,7 @@ abstract class _BuildIOSSubCommand extends BuildSubCommand {
final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim(); final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim();
globals.printStatus( globals.printStatus(
'\nTo analyze your app size in Dart DevTools, run the following command:\n' '\nTo analyze your app size in Dart DevTools, run the following command:\n'
'flutter pub global activate devtools; flutter pub global run devtools ' 'dart devtools --appSizeBase=$relativeAppSizePath'
'--appSizeBase=$relativeAppSizePath'
); );
} }
......
...@@ -105,8 +105,7 @@ Future<void> buildLinux( ...@@ -105,8 +105,7 @@ Future<void> buildLinux(
final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim(); final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim();
globals.printStatus( globals.printStatus(
'\nTo analyze your app size in Dart DevTools, run the following command:\n' '\nTo analyze your app size in Dart DevTools, run the following command:\n'
'flutter pub global activate devtools; flutter pub global run devtools ' 'dart devtools --appSizeBase=$relativeAppSizePath'
'--appSizeBase=$relativeAppSizePath'
); );
} }
} }
......
...@@ -176,8 +176,7 @@ Future<void> buildMacOS({ ...@@ -176,8 +176,7 @@ Future<void> buildMacOS({
final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim(); final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim();
globals.printStatus( globals.printStatus(
'\nTo analyze your app size in Dart DevTools, run the following command:\n' '\nTo analyze your app size in Dart DevTools, run the following command:\n'
'flutter pub global activate devtools; flutter pub global run devtools ' 'dart devtools --appSizeBase=$relativeAppSizePath'
'--appSizeBase=$relativeAppSizePath'
); );
} }
globals.flutterUsage.sendTiming('build', 'xcode-macos', Duration(milliseconds: sw.elapsedMilliseconds)); globals.flutterUsage.sendTiming('build', 'xcode-macos', Duration(milliseconds: sw.elapsedMilliseconds));
......
...@@ -121,8 +121,7 @@ Future<void> buildWindows(WindowsProject windowsProject, BuildInfo buildInfo, { ...@@ -121,8 +121,7 @@ Future<void> buildWindows(WindowsProject windowsProject, BuildInfo buildInfo, {
final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim(); final String relativeAppSizePath = outputFile.path.split('.flutter-devtools/').last.trim();
globals.printStatus( globals.printStatus(
'\nTo analyze your app size in Dart DevTools, run the following command:\n' '\nTo analyze your app size in Dart DevTools, run the following command:\n'
'flutter pub global activate devtools; flutter pub global run devtools ' 'dart devtools --appSizeBase=$relativeAppSizePath'
'--appSizeBase=$relativeAppSizePath'
); );
} }
} }
......
...@@ -366,7 +366,7 @@ void main() { ...@@ -366,7 +366,7 @@ void main() {
); );
expect(testLogger.statusText, contains('A summary of your iOS bundle analysis can be found at')); expect(testLogger.statusText, contains('A summary of your iOS bundle analysis can be found at'));
expect(testLogger.statusText, contains('flutter pub global activate devtools; flutter pub global run devtools --appSizeBase=')); expect(testLogger.statusText, contains('dart devtools --appSizeBase='));
expect(usage.events, contains( expect(usage.events, contains(
const TestUsageEvent('code-size-analysis', 'ios'), const TestUsageEvent('code-size-analysis', 'ios'),
)); ));
......
...@@ -674,7 +674,7 @@ void main() { ...@@ -674,7 +674,7 @@ void main() {
); );
expect(testLogger.statusText, contains('A summary of your iOS bundle analysis can be found at')); expect(testLogger.statusText, contains('A summary of your iOS bundle analysis can be found at'));
expect(testLogger.statusText, contains('flutter pub global activate devtools; flutter pub global run devtools --appSizeBase=')); expect(testLogger.statusText, contains('dart devtools --appSizeBase='));
expect(usage.events, contains( expect(usage.events, contains(
const TestUsageEvent('code-size-analysis', 'ios'), const TestUsageEvent('code-size-analysis', 'ios'),
)); ));
......
...@@ -647,7 +647,7 @@ set(BINARY_NAME "fizz_bar") ...@@ -647,7 +647,7 @@ set(BINARY_NAME "fizz_bar")
); );
expect(testLogger.statusText, contains('A summary of your Linux bundle analysis can be found at')); expect(testLogger.statusText, contains('A summary of your Linux bundle analysis can be found at'));
expect(testLogger.statusText, contains('flutter pub global activate devtools; flutter pub global run devtools --appSizeBase=')); expect(testLogger.statusText, contains('dart devtools --appSizeBase='));
expect(usage.events, contains( expect(usage.events, contains(
const TestUsageEvent('code-size-analysis', 'linux'), const TestUsageEvent('code-size-analysis', 'linux'),
)); ));
......
...@@ -520,7 +520,7 @@ STDERR STUFF ...@@ -520,7 +520,7 @@ STDERR STUFF
); );
expect(testLogger.statusText, contains('A summary of your macOS bundle analysis can be found at')); expect(testLogger.statusText, contains('A summary of your macOS bundle analysis can be found at'));
expect(testLogger.statusText, contains('flutter pub global activate devtools; flutter pub global run devtools --appSizeBase=')); expect(testLogger.statusText, contains('dart devtools --appSizeBase='));
expect(usage.events, contains( expect(usage.events, contains(
const TestUsageEvent('code-size-analysis', 'macos'), const TestUsageEvent('code-size-analysis', 'macos'),
)); ));
......
...@@ -921,7 +921,7 @@ if %errorlevel% neq 0 goto :VCEnd</Command> ...@@ -921,7 +921,7 @@ if %errorlevel% neq 0 goto :VCEnd</Command>
); );
expect(testLogger.statusText, contains('A summary of your Windows bundle analysis can be found at')); expect(testLogger.statusText, contains('A summary of your Windows bundle analysis can be found at'));
expect(testLogger.statusText, contains('flutter pub global activate devtools; flutter pub global run devtools --appSizeBase=')); expect(testLogger.statusText, contains('dart devtools --appSizeBase='));
expect(usage.events, contains( expect(usage.events, contains(
const TestUsageEvent('code-size-analysis', 'windows'), const TestUsageEvent('code-size-analysis', 'windows'),
)); ));
......
...@@ -15,7 +15,7 @@ import 'test_utils.dart'; ...@@ -15,7 +15,7 @@ import 'test_utils.dart';
const String apkDebugMessage = 'A summary of your APK analysis can be found at: '; const String apkDebugMessage = 'A summary of your APK analysis can be found at: ';
const String iosDebugMessage = 'A summary of your iOS bundle analysis can be found at: '; const String iosDebugMessage = 'A summary of your iOS bundle analysis can be found at: ';
const String macOSDebugMessage = 'A summary of your macOS bundle analysis can be found at: '; const String macOSDebugMessage = 'A summary of your macOS bundle analysis can be found at: ';
const String runDevToolsMessage = 'flutter pub global activate devtools; flutter pub global run devtools '; const String runDevToolsMessage = 'dart devtools ';
void main() { void main() {
testWithoutContext('--analyze-size flag produces expected output on hello_world for Android', () async { testWithoutContext('--analyze-size flag produces expected output on hello_world for Android', () async {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment