Unverified Commit 2530f4c5 authored by Michael Goderbauer's avatar Michael Goderbauer Committed by GitHub

Fix some issues flagged by unawaited_futures lint (#77844)

parent 32474dca
...@@ -791,7 +791,7 @@ void main() { ...@@ -791,7 +791,7 @@ void main() {
expect(repeating.animationBehavior, AnimationBehavior.preserve); expect(repeating.animationBehavior, AnimationBehavior.preserve);
}); });
test('AnimationBehavior.preserve runs at normal speed when animatingTo', () async { test('AnimationBehavior.preserve runs at normal speed when animatingTo', () {
debugSemanticsDisableAnimations = true; debugSemanticsDisableAnimations = true;
final AnimationController controller = AnimationController( final AnimationController controller = AnimationController(
vsync: const TestVSync(), vsync: const TestVSync(),
...@@ -816,7 +816,7 @@ void main() { ...@@ -816,7 +816,7 @@ void main() {
debugSemanticsDisableAnimations = false; debugSemanticsDisableAnimations = false;
}); });
test('AnimationBehavior.normal runs at 20x speed when animatingTo', () async { test('AnimationBehavior.normal runs at 20x speed when animatingTo', () {
debugSemanticsDisableAnimations = true; debugSemanticsDisableAnimations = true;
final AnimationController controller = AnimationController( final AnimationController controller = AnimationController(
vsync: const TestVSync(), vsync: const TestVSync(),
......
...@@ -1193,7 +1193,7 @@ void main() { ...@@ -1193,7 +1193,7 @@ void main() {
await tester.pumpWidget(buildCheckbox(false)); await tester.pumpWidget(buildCheckbox(false));
expect(find.byType(Checkbox), findsNothing); expect(find.byType(Checkbox), findsNothing);
// Release pointer after widget disappeared. // Release pointer after widget disappeared.
gesture.up(); await gesture.up();
}); });
} }
......
...@@ -106,7 +106,7 @@ void main() { ...@@ -106,7 +106,7 @@ void main() {
final RenderObject inkFeatures = tester.allRenderObjects.firstWhere((RenderObject object) => object.runtimeType.toString() == '_RenderInkFeatures'); final RenderObject inkFeatures = tester.allRenderObjects.firstWhere((RenderObject object) => object.runtimeType.toString() == '_RenderInkFeatures');
expect(inkFeatures, paints..rect(color: hoverColor)); expect(inkFeatures, paints..rect(color: hoverColor));
gesture.removePointer(); await gesture.removePointer();
}); });
testWidgets('OutlineButton changes mouse cursor when hovered', (WidgetTester tester) async { testWidgets('OutlineButton changes mouse cursor when hovered', (WidgetTester tester) async {
......
...@@ -187,7 +187,7 @@ void main() { ...@@ -187,7 +187,7 @@ void main() {
final RenderObject inkFeatures = tester.allRenderObjects.firstWhere((RenderObject object) => object.runtimeType.toString() == '_RenderInkFeatures'); final RenderObject inkFeatures = tester.allRenderObjects.firstWhere((RenderObject object) => object.runtimeType.toString() == '_RenderInkFeatures');
expect(inkFeatures, paints..rect(color: hoverColor)); expect(inkFeatures, paints..rect(color: hoverColor));
gesture.removePointer(); await gesture.removePointer();
}); });
testWidgets('Does OutlinedButton work with focus', (WidgetTester tester) async { testWidgets('Does OutlinedButton work with focus', (WidgetTester tester) async {
......
...@@ -1101,6 +1101,6 @@ void main() { ...@@ -1101,6 +1101,6 @@ void main() {
await tester.pumpWidget(buildRadio(false)); await tester.pumpWidget(buildRadio(false));
expect(find.byKey(key), findsNothing); expect(find.byKey(key), findsNothing);
// Release pointer after widget disappeared. // Release pointer after widget disappeared.
gesture.up(); await gesture.up();
}); });
} }
...@@ -1631,6 +1631,6 @@ void main() { ...@@ -1631,6 +1631,6 @@ void main() {
await tester.pumpWidget(buildSwitch(false)); await tester.pumpWidget(buildSwitch(false));
expect(find.byType(Switch), findsNothing); expect(find.byType(Switch), findsNothing);
// Release pointer after widget disappeared. // Release pointer after widget disappeared.
gesture.up(); await gesture.up();
}); });
} }
...@@ -8817,14 +8817,14 @@ void main() { ...@@ -8817,14 +8817,14 @@ void main() {
// Regression test for https://github.com/flutter/flutter/issues/54729 // Regression test for https://github.com/flutter/flutter/issues/54729
// If the intrinsic height does not match that of the height after // If the intrinsic height does not match that of the height after
// performLayout, this will fail. // performLayout, this will fail.
tester.pumpWidget(_buildTest(isDense: false)); await tester.pumpWidget(_buildTest(isDense: false));
}); });
testWidgets('When isDense, intrinsic height can go below kMinInteractiveDimension height', (WidgetTester tester) async { testWidgets('When isDense, intrinsic height can go below kMinInteractiveDimension height', (WidgetTester tester) async {
// Regression test for https://github.com/flutter/flutter/issues/54729 // Regression test for https://github.com/flutter/flutter/issues/54729
// If the intrinsic height does not match that of the height after // If the intrinsic height does not match that of the height after
// performLayout, this will fail. // performLayout, this will fail.
tester.pumpWidget(_buildTest(isDense: true)); await tester.pumpWidget(_buildTest(isDense: true));
}); });
}); });
}); });
......
...@@ -857,7 +857,7 @@ void main() { ...@@ -857,7 +857,7 @@ void main() {
// keep holding the long press, should still show tooltip // keep holding the long press, should still show tooltip
await tester.pump(kLongPressTimeout); await tester.pump(kLongPressTimeout);
expect(find.text(tooltipText), findsOneWidget); expect(find.text(tooltipText), findsOneWidget);
gesture.up(); await gesture.up();
}); });
testWidgets('Tooltip shows/hides when hovered', (WidgetTester tester) async { testWidgets('Tooltip shows/hides when hovered', (WidgetTester tester) async {
......
...@@ -303,7 +303,7 @@ void main() { ...@@ -303,7 +303,7 @@ void main() {
} }
testWidgets('layoutChild on non existent child', (WidgetTester tester) async { testWidgets('layoutChild on non existent child', (WidgetTester tester) async {
expectFlutterErrorMessage( await expectFlutterErrorMessage(
tester: tester, tester: tester,
delegate: ZeroAndOneIdLayoutDelegate(), delegate: ZeroAndOneIdLayoutDelegate(),
message: message:
...@@ -315,7 +315,7 @@ void main() { ...@@ -315,7 +315,7 @@ void main() {
}); });
testWidgets('layoutChild more than once', (WidgetTester tester) async { testWidgets('layoutChild more than once', (WidgetTester tester) async {
expectFlutterErrorMessage( await expectFlutterErrorMessage(
tester: tester, tester: tester,
delegate: DuplicateLayoutDelegate(), delegate: DuplicateLayoutDelegate(),
message: message:
...@@ -327,7 +327,7 @@ void main() { ...@@ -327,7 +327,7 @@ void main() {
}); });
testWidgets('layoutChild on invalid size constraint', (WidgetTester tester) async { testWidgets('layoutChild on invalid size constraint', (WidgetTester tester) async {
expectFlutterErrorMessage( await expectFlutterErrorMessage(
tester: tester, tester: tester,
delegate: InvalidConstraintsChildLayoutDelegate(), delegate: InvalidConstraintsChildLayoutDelegate(),
message: message:
...@@ -346,7 +346,7 @@ void main() { ...@@ -346,7 +346,7 @@ void main() {
}); });
testWidgets('positionChild on non existent child', (WidgetTester tester) async { testWidgets('positionChild on non existent child', (WidgetTester tester) async {
expectFlutterErrorMessage( await expectFlutterErrorMessage(
tester: tester, tester: tester,
delegate: NonExistentPositionDelegate(), delegate: NonExistentPositionDelegate(),
message: message:
...@@ -358,7 +358,7 @@ void main() { ...@@ -358,7 +358,7 @@ void main() {
}); });
testWidgets("_callPerformLayout on child that doesn't have id", (WidgetTester tester) async { testWidgets("_callPerformLayout on child that doesn't have id", (WidgetTester tester) async {
expectFlutterErrorMessage( await expectFlutterErrorMessage(
widget: Center( widget: Center(
child: CustomMultiChildLayout( child: CustomMultiChildLayout(
children: <Widget>[LayoutWithMissingId(child: Container(width: 100))], children: <Widget>[LayoutWithMissingId(child: Container(width: 100))],
...@@ -381,7 +381,7 @@ void main() { ...@@ -381,7 +381,7 @@ void main() {
}); });
testWidgets('performLayout did not layout a child', (WidgetTester tester) async { testWidgets('performLayout did not layout a child', (WidgetTester tester) async {
expectFlutterErrorMessage( await expectFlutterErrorMessage(
widget: Center( widget: Center(
child: CustomMultiChildLayout( child: CustomMultiChildLayout(
children: <Widget>[ children: <Widget>[
...@@ -403,7 +403,7 @@ void main() { ...@@ -403,7 +403,7 @@ void main() {
}); });
testWidgets('performLayout did not layout multiple child', (WidgetTester tester) async { testWidgets('performLayout did not layout multiple child', (WidgetTester tester) async {
expectFlutterErrorMessage( await expectFlutterErrorMessage(
widget: Center( widget: Center(
child: CustomMultiChildLayout( child: CustomMultiChildLayout(
children: <Widget>[ children: <Widget>[
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment