Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
24f63e2b
Commit
24f63e2b
authored
Aug 13, 2016
by
Devon Carew
Committed by
GitHub
Aug 13, 2016
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
show better errors for gradle build failures (#5374)
parent
3e27acd7
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
19 additions
and
12 deletions
+19
-12
executable.dart
packages/flutter_tools/lib/executable.dart
+2
-2
gradle.dart
packages/flutter_tools/lib/src/android/gradle.dart
+14
-9
logger.dart
packages/flutter_tools/lib/src/base/logger.dart
+3
-1
No files found.
packages/flutter_tools/lib/executable.dart
View file @
24f63e2b
...
...
@@ -106,8 +106,8 @@ Future<Null> main(List<String> args) async {
flutterUsage
.
sendException
(
error
,
chain
);
if
(
Platform
.
environment
.
containsKey
(
'FLUTTER_DEV'
)
||
isRunningOnBot
)
{
//
If we're working on the tools themselves, just print the stack trace
.
if
(
isRunningOnBot
)
{
//
Print the stack trace on the bots - don't write a crash report
.
stderr
.
writeln
(
'
$error
'
);
stderr
.
writeln
(
chain
.
terse
.
toString
());
}
else
{
...
...
packages/flutter_tools/lib/src/android/gradle.dart
View file @
24f63e2b
...
...
@@ -130,15 +130,20 @@ Future<int> buildGradleProject(BuildMode buildMode) async {
}
// Run 'gradle wrapper'.
Status
status
=
logger
.
startProgress
(
'Running
\'
gradle wrapper
\'
...'
);
int
exitcode
=
await
runCommandAndStreamOutput
(
<
String
>[
gradle
,
'wrapper'
],
workingDirectory:
'android'
,
allowReentrantFlutter:
true
);
status
.
stop
(
showElapsedTime:
true
);
if
(
exitcode
!=
0
)
return
exitcode
;
try
{
Status
status
=
logger
.
startProgress
(
'Running
\'
gradle wrapper
\'
...'
);
int
exitcode
=
await
runCommandAndStreamOutput
(
<
String
>[
gradle
,
'wrapper'
],
workingDirectory:
'android'
,
allowReentrantFlutter:
true
);
status
.
stop
(
showElapsedTime:
true
);
if
(
exitcode
!=
0
)
return
exitcode
;
}
catch
(
error
)
{
printError
(
'
$error
'
);
return
1
;
}
gradlew
=
locateProjectGradlew
();
if
(
gradlew
==
null
)
{
...
...
packages/flutter_tools/lib/src/base/logger.dart
View file @
24f63e2b
...
...
@@ -6,6 +6,8 @@ import 'dart:async';
import
'dart:convert'
show
ASCII
;
import
'dart:io'
;
import
'package:stack_trace/stack_trace.dart'
;
final
AnsiTerminal
terminal
=
new
AnsiTerminal
();
abstract
class
Logger
{
...
...
@@ -55,7 +57,7 @@ class StdoutLogger extends Logger {
stderr
.
writeln
(
message
);
if
(
stackTrace
!=
null
)
stderr
.
writeln
(
stackTrace
);
stderr
.
writeln
(
new
Chain
.
forTrace
(
stackTrace
).
terse
.
toString
()
);
}
@override
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment