Unverified Commit 2459f5c5 authored by Chris Yang's avatar Chris Yang Committed by GitHub

plugin template min flutter sdk version to 1.20 (#62605)

parent e8ad863a
...@@ -6,7 +6,7 @@ homepage: ...@@ -6,7 +6,7 @@ homepage:
environment: environment:
sdk: ">=2.7.0 <3.0.0" sdk: ">=2.7.0 <3.0.0"
flutter: ">=1.17.0 <2.0.0" flutter: ">=1.20.0 <2.0.0"
dependencies: dependencies:
flutter: flutter:
......
...@@ -23,6 +23,7 @@ import 'package:flutter_tools/src/project.dart'; ...@@ -23,6 +23,7 @@ import 'package:flutter_tools/src/project.dart';
import 'package:flutter_tools/src/version.dart'; import 'package:flutter_tools/src/version.dart';
import 'package:mockito/mockito.dart'; import 'package:mockito/mockito.dart';
import 'package:process/process.dart'; import 'package:process/process.dart';
import 'package:pub_semver/pub_semver.dart';
import 'package:pubspec_parse/pubspec_parse.dart'; import 'package:pubspec_parse/pubspec_parse.dart';
import '../../src/common.dart'; import '../../src/common.dart';
...@@ -1966,6 +1967,21 @@ void main() { ...@@ -1966,6 +1967,21 @@ void main() {
Logger: () => logger, Logger: () => logger,
}); });
testUsingContext('newly created plugin has min flutter sdk version as 1.20.0', () async {
Cache.flutterRoot = '../..';
when(mockFlutterVersion.frameworkRevision).thenReturn(frameworkRevision);
when(mockFlutterVersion.channel).thenReturn(frameworkChannel);
final CreateCommand command = CreateCommand();
final CommandRunner<void> runner = createTestCommandRunner(command);
await runner.run(<String>['create', '--no-pub', '--template=plugin', projectDir.path]);
final String rawPubspec = await projectDir.childFile('pubspec.yaml').readAsString();
final Pubspec pubspec = Pubspec.parse(rawPubspec);
final Map<String, VersionConstraint> env = pubspec.environment;
expect(env['flutter'].allows(Version(1, 20, 0)), true);
expect(env['flutter'].allows(Version(1, 19, 0)), false);
});
} }
Future<void> _createProject( Future<void> _createProject(
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment