Commit 2432b520 authored by Chris Bracken's avatar Chris Bracken Committed by GitHub

Improve flutter doctor messages for ios-deploy (#7962)

Differentiate between the not-installed and the out-of-date scenario.
parent f1f53460
...@@ -122,10 +122,17 @@ class IOSWorkflow extends DoctorValidator implements Workflow { ...@@ -122,10 +122,17 @@ class IOSWorkflow extends DoctorValidator implements Workflow {
} }
if (!hasIDeviceId || !_iosDeployIsInstalledAndMeetsVersionCheck) { if (!hasIDeviceId || !_iosDeployIsInstalledAndMeetsVersionCheck) {
brewStatus = ValidationType.partial; brewStatus = ValidationType.partial;
messages.add(new ValidationMessage.error( if (hasIosDeploy) {
'ios-deploy version >= $iosDeployMinimumVersion not available; this is used to deploy to connected iOS devices.\n' messages.add(new ValidationMessage.error(
'Install via \'brew install ios-deploy\'.' 'ios-deploy out of date: $iosDeployMinimumVersion is required.\n'
)); 'Upgrade via \'brew upgrade ios-deploy\'.'
));
} else {
messages.add(new ValidationMessage.error(
'ios-deploy not installed: $iosDeployMinimumVersion is required.\n'
'Install via \'brew install ios-deploy\'.'
));
}
} else { } else {
// Check for compatibility between libimobiledevice and Xcode. // Check for compatibility between libimobiledevice and Xcode.
// TODO(cbracken) remove this check once libimobiledevice > 1.2.0 is released. // TODO(cbracken) remove this check once libimobiledevice > 1.2.0 is released.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment