Unverified Commit 231a0550 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

[devicelab] fix web twc task missing display (#56623)

parent c5709251
...@@ -9,5 +9,5 @@ import 'package:flutter_devicelab/tasks/track_widget_creation_enabled_task.dart' ...@@ -9,5 +9,5 @@ import 'package:flutter_devicelab/tasks/track_widget_creation_enabled_task.dart'
/// Verify that twc can be enabled/disabled on the web. /// Verify that twc can be enabled/disabled on the web.
Future<void> main() async { Future<void> main() async {
await task(TrackWidgetCreationEnabledTask('chrome').task); await task(TrackWidgetCreationEnabledTask('chrome', <String>['--web-run-headless']).task);
} }
...@@ -18,9 +18,13 @@ final Directory integrationTestDir = Directory( ...@@ -18,9 +18,13 @@ final Directory integrationTestDir = Directory(
/// Verifies that track-widget-creation can be enabled and disabled. /// Verifies that track-widget-creation can be enabled and disabled.
class TrackWidgetCreationEnabledTask { class TrackWidgetCreationEnabledTask {
TrackWidgetCreationEnabledTask([this.deviceIdOverride]); TrackWidgetCreationEnabledTask([
this.deviceIdOverride,
this.additionalArgs = const <String>[],
]);
String deviceIdOverride; String deviceIdOverride;
final List<String> additionalArgs;
Future<TaskResult> task() async { Future<TaskResult> task() async {
final File file = File(path.join(integrationTestDir.path, 'info')); final File file = File(path.join(integrationTestDir.path, 'info'));
...@@ -39,6 +43,7 @@ class TrackWidgetCreationEnabledTask { ...@@ -39,6 +43,7 @@ class TrackWidgetCreationEnabledTask {
final Process runProcess = await startProcess( final Process runProcess = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
flutterCommandArgs('run', <String>[ flutterCommandArgs('run', <String>[
...?additionalArgs,
'--vmservice-out-file=info', '--vmservice-out-file=info',
'--track-widget-creation', '--track-widget-creation',
'-v', '-v',
...@@ -73,6 +78,7 @@ class TrackWidgetCreationEnabledTask { ...@@ -73,6 +78,7 @@ class TrackWidgetCreationEnabledTask {
final Process runProcess = await startProcess( final Process runProcess = await startProcess(
path.join(flutterDirectory.path, 'bin', 'flutter'), path.join(flutterDirectory.path, 'bin', 'flutter'),
flutterCommandArgs('run', <String>[ flutterCommandArgs('run', <String>[
...?additionalArgs,
'--vmservice-out-file=info', '--vmservice-out-file=info',
'--no-track-widget-creation', '--no-track-widget-creation',
'-v', '-v',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment