Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
231a0550
Unverified
Commit
231a0550
authored
May 08, 2020
by
Jonah Williams
Committed by
GitHub
May 08, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[devicelab] fix web twc task missing display (#56623)
parent
c5709251
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
2 deletions
+8
-2
web_enable_twc.dart
dev/devicelab/bin/tasks/web_enable_twc.dart
+1
-1
track_widget_creation_enabled_task.dart
...vicelab/lib/tasks/track_widget_creation_enabled_task.dart
+7
-1
No files found.
dev/devicelab/bin/tasks/web_enable_twc.dart
View file @
231a0550
...
...
@@ -9,5 +9,5 @@ import 'package:flutter_devicelab/tasks/track_widget_creation_enabled_task.dart'
/// Verify that twc can be enabled/disabled on the web.
Future
<
void
>
main
()
async
{
await
task
(
TrackWidgetCreationEnabledTask
(
'chrome'
).
task
);
await
task
(
TrackWidgetCreationEnabledTask
(
'chrome'
,
<
String
>[
'--web-run-headless'
]
).
task
);
}
dev/devicelab/lib/tasks/track_widget_creation_enabled_task.dart
View file @
231a0550
...
...
@@ -18,9 +18,13 @@ final Directory integrationTestDir = Directory(
/// Verifies that track-widget-creation can be enabled and disabled.
class
TrackWidgetCreationEnabledTask
{
TrackWidgetCreationEnabledTask
([
this
.
deviceIdOverride
]);
TrackWidgetCreationEnabledTask
([
this
.
deviceIdOverride
,
this
.
additionalArgs
=
const
<
String
>[],
]);
String
deviceIdOverride
;
final
List
<
String
>
additionalArgs
;
Future
<
TaskResult
>
task
()
async
{
final
File
file
=
File
(
path
.
join
(
integrationTestDir
.
path
,
'info'
));
...
...
@@ -39,6 +43,7 @@ class TrackWidgetCreationEnabledTask {
final
Process
runProcess
=
await
startProcess
(
path
.
join
(
flutterDirectory
.
path
,
'bin'
,
'flutter'
),
flutterCommandArgs
(
'run'
,
<
String
>[
...?
additionalArgs
,
'--vmservice-out-file=info'
,
'--track-widget-creation'
,
'-v'
,
...
...
@@ -73,6 +78,7 @@ class TrackWidgetCreationEnabledTask {
final
Process
runProcess
=
await
startProcess
(
path
.
join
(
flutterDirectory
.
path
,
'bin'
,
'flutter'
),
flutterCommandArgs
(
'run'
,
<
String
>[
...?
additionalArgs
,
'--vmservice-out-file=info'
,
'--no-track-widget-creation'
,
'-v'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment