Unverified Commit 22cbef30 authored by Eilidh Southren's avatar Eilidh Southren Committed by GitHub

[CP] Fix Snackbar TalkBack regression (#116417)

* Add M2 defaults and template skeleton

* add MaterialStateColor functionality to ActionTextColor (issue #110402)

* Add M2 defaults and template skeleton

* updated material 3 tokens

* Updated snackbar demo

* add theme tests

* add gen defaults

* formatting

* more whitespace fixes

* add widget type

* update docs

* code review changes

* Add line overflow functionality

* whitespace fixes

* update M3 animation

* whitespace fixes

* add insetPadding param

* Modifed icon parameter to showCloseIcon

* white space fixes

* test fixes

* rename iconColor to closeIconColor

* debug test fix

* de-britishification

* g3fix

* g3fix

* debug test fix

* Fix Snackbar talkback regression

* fix merge weirdness

* test fix

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error

* fix linux analysis error
parent e59a388b
...@@ -628,9 +628,7 @@ class _SnackBarState extends State<SnackBar> { ...@@ -628,9 +628,7 @@ class _SnackBarState extends State<SnackBar> {
Widget snackBar = Padding( Widget snackBar = Padding(
padding: padding, padding: padding,
child: SingleChildScrollView( child: Wrap(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[ children: <Widget>[
Row( Row(
children: <Widget>[ children: <Widget>[
...@@ -656,7 +654,7 @@ class _SnackBarState extends State<SnackBar> { ...@@ -656,7 +654,7 @@ class _SnackBarState extends State<SnackBar> {
children: maybeActionAndIcon), children: maybeActionAndIcon),
), ),
], ],
),
), ),
); );
......
...@@ -316,24 +316,7 @@ void main() { ...@@ -316,24 +316,7 @@ void main() {
' TextButtonTheme\n' ' TextButtonTheme\n'
' Padding\n' ' Padding\n'
' Row\n' ' Row\n'
' Column\n' ' Wrap\n'
' _SingleChildViewport\n'
' IgnorePointer-[GlobalKey#d48e8]\n'
' Semantics\n'
' Listener\n'
' _GestureSemantics\n'
' RawGestureDetector-[LabeledGlobalKey<RawGestureDetectorState>#0c3e0]\n'
' Listener\n'
' _ScrollableScope\n'
' _ScrollSemantics-[GlobalKey#349b8]\n'
' NotificationListener<ScrollMetricsNotification>\n'
' RepaintBoundary\n'
' CustomPaint\n'
' RepaintBoundary\n'
' NotificationListener<ScrollNotification>\n'
' GlowingOverscrollIndicator\n'
' Scrollable\n'
' SingleChildScrollView\n'
' Padding\n' ' Padding\n'
' MediaQuery\n' ' MediaQuery\n'
' Padding\n' ' Padding\n'
...@@ -395,7 +378,7 @@ void main() { ...@@ -395,7 +378,7 @@ void main() {
' Directionality\n' ' Directionality\n'
' [root]\n' ' [root]\n'
' Typically, the ScaffoldMessenger widget is introduced by the\n' ' Typically, the ScaffoldMessenger widget is introduced by the\n'
' MaterialApp at the top of your application widget tree.\n', ' MaterialApp at the top of your application widget tree.\n'
)); ));
}); });
} }
...@@ -1276,6 +1276,10 @@ void main() { ...@@ -1276,6 +1276,10 @@ void main() {
await tester.pumpAndSettle(); await tester.pumpAndSettle();
expect(tester.getSemantics(find.text('snack')), matchesSemantics( expect(tester.getSemantics(find.text('snack')), matchesSemantics(
isLiveRegion: true,
hasDismissAction: true,
hasScrollDownAction: true,
hasScrollUpAction: true,
label: 'snack', label: 'snack',
textDirection: TextDirection.ltr, textDirection: TextDirection.ltr,
)); ));
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment