Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
21ca1f9b
Unverified
Commit
21ca1f9b
authored
Oct 22, 2020
by
Jonah Williams
Committed by
GitHub
Oct 22, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] use --no-print-incremental-dependencies for non-resident and test compiles (#68678)
parent
4af67428
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
21 additions
and
7 deletions
+21
-7
compile.dart
packages/flutter_tools/lib/src/compile.dart
+13
-7
test_compiler.dart
packages/flutter_tools/lib/src/test/test_compiler.dart
+1
-0
common_test.dart
.../test/general.shard/build_system/targets/common_test.dart
+7
-0
No files found.
packages/flutter_tools/lib/src/compile.dart
View file @
21ca1f9b
...
...
@@ -237,6 +237,7 @@ class KernelCompiler {
'--sdk-root'
,
sdkRoot
,
'--target=
$targetModel
'
,
'--no-print-incremental-dependencies'
,
'-Ddart.developer.causal_async_stacks=
${buildMode == BuildMode.debug}
'
,
for
(
final
Object
dartDefine
in
dartDefines
)
'-D
$dartDefine
'
,
...
...
@@ -397,9 +398,11 @@ class _RejectRequest extends _CompilationRequest {
abstract
class
ResidentCompiler
{
factory
ResidentCompiler
(
String
sdkRoot
,
{
@required
BuildMode
buildMode
,
Logger
logger
,
// TODO(jonahwilliams): migrate to @required after google3
ProcessManager
processManager
,
// TODO(jonahwilliams): migrate to @required after google3
Artifacts
artifacts
,
// TODO(jonahwilliams): migrate to @required after google3
@required
Logger
logger
,
@required
ProcessManager
processManager
,
@required
Artifacts
artifacts
,
@required
Platform
platform
,
bool
testCompilation
,
bool
trackWidgetCreation
,
String
packagesPath
,
List
<
String
>
fileSystemRoots
,
...
...
@@ -411,7 +414,6 @@ abstract class ResidentCompiler {
String
platformDill
,
List
<
String
>
dartDefines
,
String
librariesSpec
,
@required
Platform
platform
,
})
=
DefaultResidentCompiler
;
// TODO(jonahwilliams): find a better way to configure additional file system
...
...
@@ -496,10 +498,11 @@ class DefaultResidentCompiler implements ResidentCompiler {
DefaultResidentCompiler
(
String
sdkRoot
,
{
@required
this
.
buildMode
,
@required
Logger
logger
,
@required
ProcessManager
processManager
,
@required
Artifacts
artifacts
,
@required
Platform
platform
,
Logger
logger
,
// TODO(jonahwilliams): migrate to @required after google3
ProcessManager
processManager
,
// TODO(jonahwilliams): migrate to @required after google3
Artifacts
artifacts
,
// TODO(jonahwilliams): migrate to @required after google3
this
.
testCompilation
=
false
,
this
.
trackWidgetCreation
=
true
,
this
.
packagesPath
,
this
.
fileSystemRoots
,
...
...
@@ -526,6 +529,7 @@ class DefaultResidentCompiler implements ResidentCompiler {
final
Artifacts
_artifacts
;
final
Platform
_platform
;
final
bool
testCompilation
;
final
BuildMode
buildMode
;
final
bool
trackWidgetCreation
;
final
String
packagesPath
;
...
...
@@ -642,6 +646,8 @@ class DefaultResidentCompiler implements ResidentCompiler {
'--sdk-root'
,
sdkRoot
,
'--incremental'
,
if
(
testCompilation
)
'--no-print-incremental-dependencies'
,
'--target=
$targetModel
'
,
// TODO(jonahwilliams): remove once this becomes the default behavior
// in the frontend_server.
...
...
packages/flutter_tools/lib/src/test/test_compiler.dart
View file @
21ca1f9b
...
...
@@ -109,6 +109,7 @@ class TestCompiler {
packagesPath:
globalPackagesPath
,
extraFrontEndOptions:
extraFrontEndOptions
,
platform:
globals
.
platform
,
testCompilation:
true
,
);
return
residentCompiler
;
}
...
...
packages/flutter_tools/test/general.shard/build_system/targets/common_test.dart
View file @
21ca1f9b
...
...
@@ -88,6 +88,7 @@ void main() {
mode:
BuildMode
.
profile
,
)
+
'/'
,
'--target=flutter'
,
'--no-print-incremental-dependencies'
,
'-Ddart.developer.causal_async_stacks=false'
,
...
buildModeOptions
(
BuildMode
.
profile
),
'--aot'
,
...
...
@@ -124,6 +125,7 @@ void main() {
mode:
BuildMode
.
profile
,
)
+
'/'
,
'--target=flutter'
,
'--no-print-incremental-dependencies'
,
'-Ddart.developer.causal_async_stacks=false'
,
...
buildModeOptions
(
BuildMode
.
profile
),
'--aot'
,
...
...
@@ -160,6 +162,7 @@ void main() {
mode:
BuildMode
.
profile
,
)
+
'/'
,
'--target=flutter'
,
'--no-print-incremental-dependencies'
,
'-Ddart.developer.causal_async_stacks=false'
,
...
buildModeOptions
(
BuildMode
.
profile
),
'--aot'
,
...
...
@@ -197,6 +200,7 @@ void main() {
mode:
BuildMode
.
profile
,
)
+
'/'
,
'--target=flutter'
,
'--no-print-incremental-dependencies'
,
'-Ddart.developer.causal_async_stacks=false'
,
...
buildModeOptions
(
BuildMode
.
profile
),
'--aot'
,
...
...
@@ -236,6 +240,7 @@ void main() {
mode:
BuildMode
.
debug
,
)
+
'/'
,
'--target=flutter'
,
'--no-print-incremental-dependencies'
,
'-Ddart.developer.causal_async_stacks=true'
,
...
buildModeOptions
(
BuildMode
.
debug
),
'--no-link-platform'
,
...
...
@@ -273,6 +278,7 @@ void main() {
mode:
BuildMode
.
debug
,
)
+
'/'
,
'--target=flutter'
,
'--no-print-incremental-dependencies'
,
'-Ddart.developer.causal_async_stacks=true'
,
...
buildModeOptions
(
BuildMode
.
debug
),
'--packages'
,
...
...
@@ -322,6 +328,7 @@ void main() {
mode:
BuildMode
.
debug
,
)
+
'/'
,
'--target=flutter'
,
'--no-print-incremental-dependencies'
,
'-Ddart.developer.causal_async_stacks=true'
,
...
buildModeOptions
(
BuildMode
.
debug
),
'--track-widget-creation'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment