Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
1ee87990
Unverified
Commit
1ee87990
authored
Feb 02, 2023
by
Eilidh Southren
Committed by
GitHub
Feb 02, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "[Re-land] Exposed tooltip longPress (#118796)" (#119832)
This reverts commit
d2788080
.
parent
9eafbcc8
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
3 additions
and
28 deletions
+3
-28
tooltip.dart
packages/flutter/lib/src/material/tooltip.dart
+1
-1
back_button_test.dart
packages/flutter/test/material/back_button_test.dart
+0
-2
calendar_date_picker_test.dart
...ages/flutter/test/material/calendar_date_picker_test.dart
+0
-2
chip_test.dart
packages/flutter/test/material/chip_test.dart
+1
-4
date_picker_test.dart
packages/flutter/test/material/date_picker_test.dart
+0
-2
floating_action_button_test.dart
...es/flutter/test/material/floating_action_button_test.dart
+0
-1
search_test.dart
packages/flutter/test/material/search_test.dart
+1
-4
tooltip_test.dart
packages/flutter/test/material/tooltip_test.dart
+0
-6
tooltip_theme_test.dart
packages/flutter/test/material/tooltip_theme_test.dart
+0
-6
No files found.
packages/flutter/lib/src/material/tooltip.dart
View file @
1ee87990
...
@@ -751,7 +751,7 @@ class TooltipState extends State<Tooltip> with SingleTickerProviderStateMixin {
...
@@ -751,7 +751,7 @@ class TooltipState extends State<Tooltip> with SingleTickerProviderStateMixin {
behavior:
HitTestBehavior
.
opaque
,
behavior:
HitTestBehavior
.
opaque
,
onLongPress:
(
_triggerMode
==
TooltipTriggerMode
.
longPress
)
?
_handlePress
:
null
,
onLongPress:
(
_triggerMode
==
TooltipTriggerMode
.
longPress
)
?
_handlePress
:
null
,
onTap:
(
_triggerMode
==
TooltipTriggerMode
.
tap
)
?
_handleTap
:
null
,
onTap:
(
_triggerMode
==
TooltipTriggerMode
.
tap
)
?
_handleTap
:
null
,
excludeFromSemantics:
_excludeFromSemantics
,
excludeFromSemantics:
true
,
child:
result
,
child:
result
,
);
);
// Only check for hovering if there is a mouse connected.
// Only check for hovering if there is a mouse connected.
...
...
packages/flutter/test/material/back_button_test.dart
View file @
1ee87990
...
@@ -172,7 +172,6 @@ void main() {
...
@@ -172,7 +172,6 @@ void main() {
hasEnabledState:
true
,
hasEnabledState:
true
,
isEnabled:
true
,
isEnabled:
true
,
hasTapAction:
true
,
hasTapAction:
true
,
hasLongPressAction:
true
,
isFocusable:
true
,
isFocusable:
true
,
));
));
handle
.
dispose
();
handle
.
dispose
();
...
@@ -217,7 +216,6 @@ void main() {
...
@@ -217,7 +216,6 @@ void main() {
hasEnabledState:
true
,
hasEnabledState:
true
,
isEnabled:
true
,
isEnabled:
true
,
hasTapAction:
true
,
hasTapAction:
true
,
hasLongPressAction:
true
,
isFocusable:
true
,
isFocusable:
true
,
));
));
handle
.
dispose
();
handle
.
dispose
();
...
...
packages/flutter/test/material/calendar_date_picker_test.dart
View file @
1ee87990
...
@@ -672,7 +672,6 @@ void main() {
...
@@ -672,7 +672,6 @@ void main() {
tooltip:
'Previous month'
,
tooltip:
'Previous month'
,
isButton:
true
,
isButton:
true
,
hasTapAction:
true
,
hasTapAction:
true
,
hasLongPressAction:
true
,
isEnabled:
true
,
isEnabled:
true
,
hasEnabledState:
true
,
hasEnabledState:
true
,
isFocusable:
true
,
isFocusable:
true
,
...
@@ -681,7 +680,6 @@ void main() {
...
@@ -681,7 +680,6 @@ void main() {
tooltip:
'Next month'
,
tooltip:
'Next month'
,
isButton:
true
,
isButton:
true
,
hasTapAction:
true
,
hasTapAction:
true
,
hasLongPressAction:
true
,
isEnabled:
true
,
isEnabled:
true
,
hasEnabledState:
true
,
hasEnabledState:
true
,
isFocusable:
true
,
isFocusable:
true
,
...
...
packages/flutter/test/material/chip_test.dart
View file @
1ee87990
...
@@ -2047,10 +2047,7 @@ void main() {
...
@@ -2047,10 +2047,7 @@ void main() {
children:
<
TestSemantics
>[
children:
<
TestSemantics
>[
TestSemantics
(
TestSemantics
(
tooltip:
'Delete'
,
tooltip:
'Delete'
,
actions:
<
SemanticsAction
>[
actions:
<
SemanticsAction
>[
SemanticsAction
.
tap
],
SemanticsAction
.
tap
,
SemanticsAction
.
longPress
],
textDirection:
TextDirection
.
ltr
,
textDirection:
TextDirection
.
ltr
,
flags:
<
SemanticsFlag
>[
flags:
<
SemanticsFlag
>[
SemanticsFlag
.
isButton
,
SemanticsFlag
.
isButton
,
...
...
packages/flutter/test/material/date_picker_test.dart
View file @
1ee87990
...
@@ -833,7 +833,6 @@ void main() {
...
@@ -833,7 +833,6 @@ void main() {
tooltip:
'Switch to input'
,
tooltip:
'Switch to input'
,
isButton:
true
,
isButton:
true
,
hasTapAction:
true
,
hasTapAction:
true
,
hasLongPressAction:
true
,
isEnabled:
true
,
isEnabled:
true
,
hasEnabledState:
true
,
hasEnabledState:
true
,
isFocusable:
true
,
isFocusable:
true
,
...
@@ -877,7 +876,6 @@ void main() {
...
@@ -877,7 +876,6 @@ void main() {
tooltip:
'Switch to calendar'
,
tooltip:
'Switch to calendar'
,
isButton:
true
,
isButton:
true
,
hasTapAction:
true
,
hasTapAction:
true
,
hasLongPressAction:
true
,
isEnabled:
true
,
isEnabled:
true
,
hasEnabledState:
true
,
hasEnabledState:
true
,
isFocusable:
true
,
isFocusable:
true
,
...
...
packages/flutter/test/material/floating_action_button_test.dart
View file @
1ee87990
...
@@ -700,7 +700,6 @@ void main() {
...
@@ -700,7 +700,6 @@ void main() {
tooltip:
'Add Photo'
,
tooltip:
'Add Photo'
,
actions:
<
SemanticsAction
>[
actions:
<
SemanticsAction
>[
SemanticsAction
.
tap
,
SemanticsAction
.
tap
,
SemanticsAction
.
longPress
,
],
],
flags:
<
SemanticsFlag
>[
flags:
<
SemanticsFlag
>[
SemanticsFlag
.
hasEnabledState
,
SemanticsFlag
.
hasEnabledState
,
...
...
packages/flutter/test/material/search_test.dart
View file @
1ee87990
...
@@ -620,10 +620,7 @@ void main() {
...
@@ -620,10 +620,7 @@ void main() {
SemanticsFlag
.
isEnabled
,
SemanticsFlag
.
isEnabled
,
SemanticsFlag
.
isFocusable
,
SemanticsFlag
.
isFocusable
,
],
],
actions:
<
SemanticsAction
>[
actions:
<
SemanticsAction
>[
SemanticsAction
.
tap
],
SemanticsAction
.
tap
,
SemanticsAction
.
longPress
,
],
tooltip:
'Back'
,
tooltip:
'Back'
,
textDirection:
TextDirection
.
ltr
,
textDirection:
TextDirection
.
ltr
,
),
),
...
...
packages/flutter/test/material/tooltip_test.dart
View file @
1ee87990
...
@@ -1416,9 +1416,6 @@ void main() {
...
@@ -1416,9 +1416,6 @@ void main() {
id:
1
,
id:
1
,
tooltip:
'TIP'
,
tooltip:
'TIP'
,
textDirection:
TextDirection
.
ltr
,
textDirection:
TextDirection
.
ltr
,
actions:
<
SemanticsAction
>[
SemanticsAction
.
longPress
,
],
),
),
],
],
);
);
...
@@ -1619,9 +1616,6 @@ void main() {
...
@@ -1619,9 +1616,6 @@ void main() {
tooltip:
'Foo'
,
tooltip:
'Foo'
,
label:
'Bar'
,
label:
'Bar'
,
textDirection:
TextDirection
.
ltr
,
textDirection:
TextDirection
.
ltr
,
actions:
<
SemanticsAction
>[
SemanticsAction
.
longPress
,
],
),
),
],
],
),
),
...
...
packages/flutter/test/material/tooltip_theme_test.dart
View file @
1ee87990
...
@@ -1075,9 +1075,6 @@ void main() {
...
@@ -1075,9 +1075,6 @@ void main() {
tooltip:
'Foo'
,
tooltip:
'Foo'
,
label:
'Bar'
,
label:
'Bar'
,
textDirection:
TextDirection
.
ltr
,
textDirection:
TextDirection
.
ltr
,
actions:
<
SemanticsAction
>[
SemanticsAction
.
longPress
,
],
),
),
],
],
),
),
...
@@ -1121,9 +1118,6 @@ void main() {
...
@@ -1121,9 +1118,6 @@ void main() {
tooltip:
'Foo'
,
tooltip:
'Foo'
,
label:
'Bar'
,
label:
'Bar'
,
textDirection:
TextDirection
.
ltr
,
textDirection:
TextDirection
.
ltr
,
actions:
<
SemanticsAction
>[
SemanticsAction
.
longPress
,
],
),
),
],
],
),
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment