Unverified Commit 1781d5c9 authored by Ian Hickson's avatar Ian Hickson Committed by GitHub

Clean up test infrastructure (#41880)

parent 863fb2f2
This diff is collapsed.
...@@ -2,3 +2,6 @@ This directory contains tools and resources that the Flutter team uses ...@@ -2,3 +2,6 @@ This directory contains tools and resources that the Flutter team uses
during development of the framework. The tools in this directory during development of the framework. The tools in this directory
should not be necessary for developing Flutter applications, though of should not be necessary for developing Flutter applications, though of
course they may be interesting if you are curious. course they may be interesting if you are curious.
The tests in this directory are run in the `framework_tests_misc-*`
shards.
#!/bin/bash #!/bin/bash
set -e set -e
# This script is only meant to be run by the Cirrus CI system, not locally.
# It must be run from the root of the Flutter repo.
function error() { function error() {
echo "$@" 1>&2 echo "$@" 1>&2
} }
# This script is only meant to be run by the Cirrus CI system, not locally.
# It must be run from the root of the Flutter repo.
function accept_android_licenses() { function accept_android_licenses() {
yes "y" | flutter doctor --android-licenses > /dev/null 2>&1 yes "y" | flutter doctor --android-licenses > /dev/null 2>&1
} }
echo "Flutter SDK directory is: $PWD" echo "Flutter SDK directory is: $PWD"
# Run flutter to download dependencies and precompile things, and to disable
# analytics on the bots.
echo "Downloading build dependencies and pre-compiling Flutter snapshot"
./bin/flutter config --no-analytics
# Run doctor, to print it to the log for debugging purposes.
./bin/flutter doctor -v
# Accept licenses. # Accept licenses.
echo "Accepting Android licenses." echo "Accepting Android licenses."
accept_android_licenses || (error "Accepting Android licenses failed." && false) accept_android_licenses || (error "Accepting Android licenses failed." && false)
# Run pub get in all the repo packages.
echo "Updating packages for Flutter."
./bin/flutter update-packages
...@@ -24,88 +24,90 @@ set -x ...@@ -24,88 +24,90 @@ set -x
cd "$FLUTTER_ROOT" cd "$FLUTTER_ROOT"
if [[ "$SHARD" = "deploy_gallery" ]]; then version="$(<version)"
version="$(<version)" if [[ "$OS" == "linux" ]]; then
if [[ "$OS" == "linux" ]]; then echo "Building Flutter Gallery $version for Android..."
echo "Building Flutter Gallery $version for Android..." # ANDROID_SDK_ROOT must be set in the env.
(
# ANDROID_SDK_ROOT must be set in the env. cd examples/flutter_gallery
( flutter build apk --release -t lib/main_publish.dart
cd examples/flutter_gallery )
flutter build apk --release -t lib/main_publish.dart echo "Android Flutter Gallery built"
) if [[ -z "$CIRRUS_PR" && "$CIRRUS_BRANCH" == "dev" && "$version" != *"pre"* ]]; then
echo "Android Flutter Gallery built" echo "Deploying Flutter Gallery $version to Play Store..."
if [[ -z "$CIRRUS_PR" && "$CIRRUS_BRANCH" == "dev" && "$version" != *"pre"* ]]; then set +x # Don't echo back the below.
echo "Deploying Flutter Gallery $version to Play Store..." if [ -n "$ANDROID_GALLERY_UPLOAD_KEY" ]; then
set +x # Don't echo back the below. echo "$ANDROID_GALLERY_UPLOAD_KEY" | base64 --decode > /root/.android/debug.keystore
if [ -n "$ANDROID_GALLERY_UPLOAD_KEY" ]; then
echo "$ANDROID_GALLERY_UPLOAD_KEY" | base64 --decode > /root/.android/debug.keystore
fi
set -x
(
cd examples/flutter_gallery/android
fastlane deploy_play_store
)
else
echo "Not deployed: Flutter Gallery is only deployed to the Play Store on merged and tagged dev branch commits"
fi fi
elif [[ "$OS" == "darwin" ]]; then set -x
echo "Building Flutter Gallery $version for iOS..."
( (
cd examples/flutter_gallery cd examples/flutter_gallery/android
flutter build ios --release --no-codesign -t lib/main_publish.dart fastlane deploy_play_store
)
else
echo "(Not deploying; Flutter Gallery is only deployed to Play store for tagged dev branch commits.)"
fi
elif [[ "$OS" == "darwin" ]]; then
echo "Building Flutter Gallery $version for iOS..."
(
cd examples/flutter_gallery
flutter build ios --release --no-codesign -t lib/main_publish.dart
# flutter build ios will run CocoaPods script. Check generated locations. # flutter build ios will run CocoaPods script. Check generated locations.
if [[ ! -d "ios/Pods" ]]; then if [[ ! -d "ios/Pods" ]]; then
echo "Error: pod install failed to setup plugins" echo "Error: pod install failed to setup plugins"
exit 1 exit 1
fi fi
if [[ ! -d "ios/.symlinks/plugins" ]]; then if [[ ! -d "ios/.symlinks/plugins" ]]; then
echo "Error: pod install failed to setup plugin symlinks" echo "Error: pod install failed to setup plugin symlinks"
exit 1 exit 1
fi fi
if [[ -d "ios/.symlinks/flutter" ]]; then if [[ -d "ios/.symlinks/flutter" ]]; then
echo "Error: pod install created flutter symlink" echo "Error: pod install created flutter symlink"
exit 1 exit 1
fi fi
if [[ ! -d "build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets" ]]; then if [[ ! -d "build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets" ]]; then
echo "Error: flutter_assets not assembled" echo "Error: flutter_assets not assembled"
exit 1 exit 1
fi fi
if [[ if [[
-d "build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets/isolate_snapshot_data" || -d "build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets/isolate_snapshot_data" ||
-d "build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets/kernel_blob.bin" || -d "build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets/kernel_blob.bin" ||
-d "build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets/vm_snapshot_data" -d "build/ios/iphoneos/Runner.app/Frameworks/App.framework/flutter_assets/vm_snapshot_data"
]]; then ]]; then
echo "Error: compiled debug version of app with --release flag" echo "Error: compiled debug version of app with --release flag"
exit 1 exit 1
fi fi
) )
echo "iOS Flutter Gallery built" echo "iOS Flutter Gallery built"
if [[ -z "$CIRRUS_PR" ]]; then if [[ -z "$CIRRUS_PR" ]]; then
if [[ "$CIRRUS_BRANCH" == "dev" && "$version" != *"pre"* ]]; then if [[ "$CIRRUS_BRANCH" == "dev" && "$version" != *"pre"* ]]; then
echo "Archiving with distribution profile and deploying to TestFlight..." echo "Archiving with distribution profile and deploying to TestFlight..."
( (
cd examples/flutter_gallery/ios cd examples/flutter_gallery/ios
export DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS="-t DAV" export DELIVER_ITMSTRANSPORTER_ADDITIONAL_UPLOAD_PARAMETERS="-t DAV"
fastlane build_and_deploy_testflight upload:true fastlane build_and_deploy_testflight upload:true
) )
else
echo "Archiving with distribution profile..."
(
cd examples/flutter_gallery/ios
fastlane build_and_deploy_testflight
)
echo "Archive is only deployed to TestFlight on tagged dev branch commits"
fi
else else
echo "Not deployed: Flutter Gallery is only deployed to TestFlight on merged and tagged dev branch commits" # On iOS the signing can break as well, so we verify this regularly (not just
# on tagged dev branch commits). We can only do this post-merge, though, because
# the secrets aren't available on PRs.
echo "Testing archiving with distribution profile..."
(
cd examples/flutter_gallery/ios
fastlane build_and_deploy_testflight
)
echo "(Not deploying; Flutter Gallery is only deployed to TestFlight for tagged dev branch commits.)"
fi fi
else
echo "(Not archiving or deploying; Flutter Gallery archiving is only tested post-commit.)"
fi fi
else else
echo "Doing nothing: not on the 'deploy_gallery' SHARD." echo "Unknown OS: $OS"
echo "Aborted."
exit 1
fi fi
...@@ -95,7 +95,6 @@ Future<void> runCommand(String executable, List<String> arguments, { ...@@ -95,7 +95,6 @@ Future<void> runCommand(String executable, List<String> arguments, {
OutputMode outputMode = OutputMode.print, OutputMode outputMode = OutputMode.print,
CapturedOutput output, CapturedOutput output,
bool skip = false, bool skip = false,
bool expectFlaky = false,
bool Function(String) removeLine, bool Function(String) removeLine,
}) async { }) async {
assert((outputMode == OutputMode.capture) == (output != null), assert((outputMode == OutputMode.capture) == (output != null),
...@@ -145,10 +144,6 @@ Future<void> runCommand(String executable, List<String> arguments, { ...@@ -145,10 +144,6 @@ Future<void> runCommand(String executable, List<String> arguments, {
output.stderr = _flattenToString(await savedStderr); output.stderr = _flattenToString(await savedStderr);
} }
// If the test is flaky we don't care about the actual exit.
if (expectFlaky)
return;
if ((exitCode == 0) == expectNonZeroExit || (expectedExitCode != null && exitCode != expectedExitCode)) { if ((exitCode == 0) == expectNonZeroExit || (expectedExitCode != null && exitCode != expectedExitCode)) {
if (failureMessage != null) { if (failureMessage != null) {
print(failureMessage); print(failureMessage);
......
This diff is collapsed.
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:io';
import 'common.dart';
void main() {
test('BOT variable is set on bots', () {
expect(Platform.environment['BOT'], 'true');
});
}
// Copyright 2017 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:io';
import 'package:path/path.dart' as path;
import 'common.dart';
void main() {
test('We are in a directory with a space in it', () async {
// The Flutter SDK should be in a directory with a space in it, to make sure
// our tools support that.
final String expectedName = Platform.environment['FLUTTER_SDK_PATH_WITH_SPACE'];
expect(expectedName, 'flutter sdk');
expect(expectedName, contains(' '));
final List<String> parts = path.split(Directory.current.absolute.path);
expect(parts.reversed.take(3), <String>['bots', 'dev', expectedName]);
});
}
...@@ -29,7 +29,11 @@ void main() { ...@@ -29,7 +29,11 @@ void main() {
]; ];
for (String version in valid_versions) { for (String version in valid_versions) {
when(file.readAsString()).thenAnswer((Invocation invocation) => Future<String>.value(version)); when(file.readAsString()).thenAnswer((Invocation invocation) => Future<String>.value(version));
expect(await verifyVersion(version, file), isTrue, reason: '$version is invalid'); expect(
await verifyVersion(file),
isNull,
reason: '$version is valid but verifyVersionFile said it was bad',
);
} }
}); });
...@@ -41,10 +45,15 @@ void main() { ...@@ -41,10 +45,15 @@ void main() {
'1.2.3-pre', '1.2.3-pre',
'1.2.3-pre.1+hotfix.1', '1.2.3-pre.1+hotfix.1',
' 1.2.3', ' 1.2.3',
'1.2.3-hotfix.1',
]; ];
for (String version in invalid_versions) { for (String version in invalid_versions) {
when(file.readAsString()).thenAnswer((Invocation invocation) => Future<String>.value(version)); when(file.readAsString()).thenAnswer((Invocation invocation) => Future<String>.value(version));
expect(await verifyVersion(version, file), isFalse); expect(
await verifyVersion(file),
'The version logic generated an invalid version string: "$version".',
reason: '$version is invalid but verifyVersionFile said it was fine',
);
} }
}); });
}); });
......
tags: # package:test configuration
"no_coverage": # https://github.com/dart-lang/test/blob/master/pkgs/test/doc/configuration.md
"create":
"integration": # Some of our tests take an absurdly long time to run, and on some
# hosts they can take even longer due to the host suddenly being
# overloaded. For this reason, we set the test timeout to
# significantly more than it would be by default, and we never set the
# timeouts in the tests themselves.
timeout: 15m
...@@ -135,7 +135,7 @@ void main() { ...@@ -135,7 +135,7 @@ void main() {
return _updateIdeConfig( return _updateIdeConfig(
expectedContents: expectedContents, expectedContents: expectedContents,
); );
}, timeout: const Timeout.factor(2.0)); });
testUsingContext('creates non-existent files', () async { testUsingContext('creates non-existent files', () async {
final Map<String, String> templateManifest = _getManifest( final Map<String, String> templateManifest = _getManifest(
...@@ -155,7 +155,7 @@ void main() { ...@@ -155,7 +155,7 @@ void main() {
return _updateIdeConfig( return _updateIdeConfig(
expectedContents: expectedContents, expectedContents: expectedContents,
); );
}, timeout: const Timeout.factor(2.0)); });
testUsingContext('overwrites existing files with --overwrite', () async { testUsingContext('overwrites existing files with --overwrite', () async {
final Map<String, String> templateManifest = _getManifest( final Map<String, String> templateManifest = _getManifest(
...@@ -181,7 +181,7 @@ void main() { ...@@ -181,7 +181,7 @@ void main() {
args: <String>['--overwrite'], args: <String>['--overwrite'],
expectedContents: expectedContents, expectedContents: expectedContents,
); );
}, timeout: const Timeout.factor(2.0)); });
testUsingContext('only adds new templates without --overwrite', () async { testUsingContext('only adds new templates without --overwrite', () async {
final Map<String, String> templateManifest = _getManifest( final Map<String, String> templateManifest = _getManifest(
...@@ -212,7 +212,7 @@ void main() { ...@@ -212,7 +212,7 @@ void main() {
args: <String>['--update-templates'], args: <String>['--update-templates'],
expectedContents: expectedContents, expectedContents: expectedContents,
); );
}, timeout: const Timeout.factor(2.0)); });
testUsingContext('update all templates with --overwrite', () async { testUsingContext('update all templates with --overwrite', () async {
final Map<String, String> templateManifest = _getManifest( final Map<String, String> templateManifest = _getManifest(
...@@ -239,7 +239,7 @@ void main() { ...@@ -239,7 +239,7 @@ void main() {
args: <String>['--update-templates', '--overwrite'], args: <String>['--update-templates', '--overwrite'],
expectedContents: expectedContents, expectedContents: expectedContents,
); );
}, timeout: const Timeout.factor(2.0)); });
testUsingContext('removes deleted imls with --overwrite', () async { testUsingContext('removes deleted imls with --overwrite', () async {
final Map<String, String> templateManifest = _getManifest( final Map<String, String> templateManifest = _getManifest(
...@@ -275,7 +275,7 @@ void main() { ...@@ -275,7 +275,7 @@ void main() {
args: <String>['--update-templates', '--overwrite'], args: <String>['--update-templates', '--overwrite'],
expectedContents: expectedContents, expectedContents: expectedContents,
); );
}, timeout: const Timeout.factor(2.0)); });
testUsingContext('removes deleted imls with --overwrite, including empty parent dirs', () async { testUsingContext('removes deleted imls with --overwrite, including empty parent dirs', () async {
final Map<String, String> templateManifest = _getManifest( final Map<String, String> templateManifest = _getManifest(
...@@ -316,7 +316,7 @@ void main() { ...@@ -316,7 +316,7 @@ void main() {
args: <String>['--update-templates', '--overwrite'], args: <String>['--update-templates', '--overwrite'],
expectedContents: expectedContents, expectedContents: expectedContents,
); );
}, timeout: const Timeout.factor(2.0)); });
}); });
} }
...@@ -16,9 +16,6 @@ import 'package:flutter_tools/src/runner/flutter_command.dart'; ...@@ -16,9 +16,6 @@ import 'package:flutter_tools/src/runner/flutter_command.dart';
import '../../src/common.dart'; import '../../src/common.dart';
import '../../src/context.dart'; import '../../src/context.dart';
/// Test case timeout for tests involving project analysis.
const Timeout allowForSlowAnalyzeTests = Timeout.factor(5.0);
final Generator _kNoColorTerminalPlatform = () => FakePlatform.fromPlatform(const LocalPlatform())..stdoutSupportsAnsi = false; final Generator _kNoColorTerminalPlatform = () => FakePlatform.fromPlatform(const LocalPlatform())..stdoutSupportsAnsi = false;
final Map<Type, Generator> noColorTerminalOverride = <Type, Generator>{ final Map<Type, Generator> noColorTerminalOverride = <Type, Generator>{
Platform: _kNoColorTerminalPlatform, Platform: _kNoColorTerminalPlatform,
...@@ -54,7 +51,7 @@ void main() { ...@@ -54,7 +51,7 @@ void main() {
], ],
); );
expect(libMain.existsSync(), isTrue); expect(libMain.existsSync(), isTrue);
}, timeout: allowForRemotePubInvocation, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -65,7 +62,7 @@ void main() { ...@@ -65,7 +62,7 @@ void main() {
arguments: <String>['analyze'], arguments: <String>['analyze'],
statusTextContains: <String>['No issues found!'], statusTextContains: <String>['No issues found!'],
); );
}, timeout: allowForSlowAnalyzeTests, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -80,6 +77,7 @@ void main() { ...@@ -80,6 +77,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
// Analyze in the current directory - no arguments // Analyze in the current directory - no arguments
testUsingContext('working directory with errors', () async { testUsingContext('working directory with errors', () async {
// Break the code to produce the "The parameter 'onPressed' is required" hint // Break the code to produce the "The parameter 'onPressed' is required" hint
...@@ -110,7 +108,7 @@ void main() { ...@@ -110,7 +108,7 @@ void main() {
exitMessageContains: '2 issues found.', exitMessageContains: '2 issues found.',
toolExit: true, toolExit: true,
); );
}, timeout: allowForSlowAnalyzeTests, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
...noColorTerminalOverride, ...noColorTerminalOverride,
}); });
...@@ -140,7 +138,7 @@ void main() { ...@@ -140,7 +138,7 @@ void main() {
exitMessageContains: '3 issues found.', exitMessageContains: '3 issues found.',
toolExit: true, toolExit: true,
); );
}, timeout: allowForSlowAnalyzeTests, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
...noColorTerminalOverride ...noColorTerminalOverride
}); });
......
...@@ -73,7 +73,7 @@ void main() { ...@@ -73,7 +73,7 @@ void main() {
expect(await command.usageValues, expect(await command.usageValues,
containsPair(CustomDimensions.commandBuildBundleIsModule, 'true')); containsPair(CustomDimensions.commandBuildBundleIsModule, 'true'));
}, timeout: allowForCreateFlutterProject); });
testUsingContext('bundle getUsage indicate that project is not a module', () async { testUsingContext('bundle getUsage indicate that project is not a module', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -83,7 +83,7 @@ void main() { ...@@ -83,7 +83,7 @@ void main() {
expect(await command.usageValues, expect(await command.usageValues,
containsPair(CustomDimensions.commandBuildBundleIsModule, 'false')); containsPair(CustomDimensions.commandBuildBundleIsModule, 'false'));
}, timeout: allowForCreateFlutterProject); });
testUsingContext('bundle getUsage indicate the target platform', () async { testUsingContext('bundle getUsage indicate the target platform', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -93,7 +93,7 @@ void main() { ...@@ -93,7 +93,7 @@ void main() {
expect(await command.usageValues, expect(await command.usageValues,
containsPair(CustomDimensions.commandBuildBundleTargetPlatform, 'android-arm')); containsPair(CustomDimensions.commandBuildBundleTargetPlatform, 'android-arm'));
}, timeout: allowForCreateFlutterProject); });
testUsingContext('bundle fails to build for Windows if feature is disabled', () async { testUsingContext('bundle fails to build for Windows if feature is disabled', () async {
fs.file('lib/main.dart').createSync(recursive: true); fs.file('lib/main.dart').createSync(recursive: true);
......
...@@ -207,7 +207,7 @@ void main() { ...@@ -207,7 +207,7 @@ void main() {
expectDependenciesResolved(projectPath); expectDependenciesResolved(projectPath);
expectZeroPluginsInjected(projectPath); expectZeroPluginsInjected(projectPath);
}, timeout: allowForRemotePubInvocation, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -220,7 +220,7 @@ void main() { ...@@ -220,7 +220,7 @@ void main() {
expectDependenciesResolved(projectPath); expectDependenciesResolved(projectPath);
expectZeroPluginsInjected(projectPath); expectZeroPluginsInjected(projectPath);
}, timeout: allowForCreateFlutterProject, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -234,7 +234,7 @@ void main() { ...@@ -234,7 +234,7 @@ void main() {
expect(await getCommand.usageValues, expect(await getCommand.usageValues,
containsPair(CustomDimensions.commandPackagesNumberPlugins, '0')); containsPair(CustomDimensions.commandPackagesNumberPlugins, '0'));
}, timeout: allowForCreateFlutterProject, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -248,7 +248,7 @@ void main() { ...@@ -248,7 +248,7 @@ void main() {
expect(await getCommand.usageValues, expect(await getCommand.usageValues,
containsPair(CustomDimensions.commandPackagesProjectModule, 'false')); containsPair(CustomDimensions.commandPackagesProjectModule, 'false'));
}, timeout: allowForCreateFlutterProject, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -262,7 +262,7 @@ void main() { ...@@ -262,7 +262,7 @@ void main() {
expect(await getCommand.usageValues, expect(await getCommand.usageValues,
containsPair(CustomDimensions.commandPackagesProjectModule, 'true')); containsPair(CustomDimensions.commandPackagesProjectModule, 'true'));
}, timeout: allowForCreateFlutterProject, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -275,7 +275,7 @@ void main() { ...@@ -275,7 +275,7 @@ void main() {
expectDependenciesResolved(projectPath); expectDependenciesResolved(projectPath);
expectZeroPluginsInjected(projectPath); expectZeroPluginsInjected(projectPath);
}, timeout: allowForRemotePubInvocation, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -288,7 +288,7 @@ void main() { ...@@ -288,7 +288,7 @@ void main() {
expectDependenciesResolved(projectPath); expectDependenciesResolved(projectPath);
expectModulePluginInjected(projectPath); expectModulePluginInjected(projectPath);
}, timeout: allowForRemotePubInvocation, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
...@@ -309,7 +309,7 @@ void main() { ...@@ -309,7 +309,7 @@ void main() {
expectDependenciesResolved(exampleProjectPath); expectDependenciesResolved(exampleProjectPath);
expectPluginInjected(exampleProjectPath); expectPluginInjected(exampleProjectPath);
}, timeout: allowForRemotePubInvocation, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
Pub: () => const Pub(), Pub: () => const Pub(),
}); });
}); });
......
...@@ -57,7 +57,7 @@ void main() { ...@@ -57,7 +57,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
AndroidBuilder: () => FakeAndroidBuilder(), AndroidBuilder: () => FakeAndroidBuilder(),
}, timeout: allowForCreateFlutterProject); });
testUsingContext('indicate that project is a plugin', () async { testUsingContext('indicate that project is a plugin', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -69,7 +69,7 @@ void main() { ...@@ -69,7 +69,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
AndroidBuilder: () => FakeAndroidBuilder(), AndroidBuilder: () => FakeAndroidBuilder(),
}, timeout: allowForCreateFlutterProject); });
testUsingContext('indicate the target platform', () async { testUsingContext('indicate the target platform', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -82,7 +82,7 @@ void main() { ...@@ -82,7 +82,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
AndroidBuilder: () => FakeAndroidBuilder(), AndroidBuilder: () => FakeAndroidBuilder(),
}, timeout: allowForCreateFlutterProject); });
}); });
group('Gradle', () { group('Gradle', () {
......
...@@ -48,7 +48,7 @@ void main() { ...@@ -48,7 +48,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
AndroidBuilder: () => FakeAndroidBuilder(), AndroidBuilder: () => FakeAndroidBuilder(),
}, timeout: allowForCreateFlutterProject); });
testUsingContext('split per abi', () async { testUsingContext('split per abi', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -65,7 +65,7 @@ void main() { ...@@ -65,7 +65,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
AndroidBuilder: () => FakeAndroidBuilder(), AndroidBuilder: () => FakeAndroidBuilder(),
}, timeout: allowForCreateFlutterProject); });
testUsingContext('build type', () async { testUsingContext('build type', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -92,7 +92,7 @@ void main() { ...@@ -92,7 +92,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
AndroidBuilder: () => FakeAndroidBuilder(), AndroidBuilder: () => FakeAndroidBuilder(),
}, timeout: allowForCreateFlutterProject); });
}); });
group('Gradle', () { group('Gradle', () {
...@@ -223,8 +223,7 @@ flutter: ...@@ -223,8 +223,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
GradleUtils: () => GradleUtils(), GradleUtils: () => GradleUtils(),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
}, });
timeout: allowForCreateFlutterProject);
testUsingContext('shrinking is disabled when --no-shrink is passed', () async { testUsingContext('shrinking is disabled when --no-shrink is passed', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -255,8 +254,7 @@ flutter: ...@@ -255,8 +254,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
GradleUtils: () => GradleUtils(), GradleUtils: () => GradleUtils(),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
}, });
timeout: allowForCreateFlutterProject);
testUsingContext('guides the user when the shrinker fails', () async { testUsingContext('guides the user when the shrinker fails', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -312,8 +310,7 @@ flutter: ...@@ -312,8 +310,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
Usage: () => mockUsage, Usage: () => mockUsage,
}, });
timeout: allowForCreateFlutterProject);
testUsingContext('reports when the app isn\'t using AndroidX', () async { testUsingContext('reports when the app isn\'t using AndroidX', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -366,8 +363,7 @@ flutter: ...@@ -366,8 +363,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
Usage: () => mockUsage, Usage: () => mockUsage,
}, });
timeout: allowForCreateFlutterProject);
testUsingContext('reports when the app is using AndroidX', () async { testUsingContext('reports when the app is using AndroidX', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -422,8 +418,7 @@ flutter: ...@@ -422,8 +418,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
Usage: () => mockUsage, Usage: () => mockUsage,
}, });
timeout: allowForCreateFlutterProject);
}); });
} }
......
...@@ -48,7 +48,7 @@ void main() { ...@@ -48,7 +48,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
AndroidBuilder: () => FakeAndroidBuilder(), AndroidBuilder: () => FakeAndroidBuilder(),
}, timeout: allowForCreateFlutterProject); });
testUsingContext('build type', () async { testUsingContext('build type', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -75,7 +75,7 @@ void main() { ...@@ -75,7 +75,7 @@ void main() {
}, overrides: <Type, Generator>{ }, overrides: <Type, Generator>{
AndroidBuilder: () => FakeAndroidBuilder(), AndroidBuilder: () => FakeAndroidBuilder(),
}, timeout: allowForCreateFlutterProject); });
}); });
group('Gradle', () { group('Gradle', () {
...@@ -212,8 +212,7 @@ flutter: ...@@ -212,8 +212,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
GradleUtils: () => GradleUtils(), GradleUtils: () => GradleUtils(),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
}, });
timeout: allowForCreateFlutterProject);
testUsingContext('shrinking is disabled when --no-shrink is passed', () async { testUsingContext('shrinking is disabled when --no-shrink is passed', () async {
final String projectPath = await createProject( final String projectPath = await createProject(
...@@ -246,8 +245,7 @@ flutter: ...@@ -246,8 +245,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
GradleUtils: () => GradleUtils(), GradleUtils: () => GradleUtils(),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
}, });
timeout: allowForCreateFlutterProject);
testUsingContext('guides the user when the shrinker fails', () async { testUsingContext('guides the user when the shrinker fails', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -303,8 +301,7 @@ flutter: ...@@ -303,8 +301,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
Usage: () => mockUsage, Usage: () => mockUsage,
}, });
timeout: allowForCreateFlutterProject);
testUsingContext('reports when the app isn\'t using AndroidX', () async { testUsingContext('reports when the app isn\'t using AndroidX', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -357,8 +354,7 @@ flutter: ...@@ -357,8 +354,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
Usage: () => mockUsage, Usage: () => mockUsage,
}, });
timeout: allowForCreateFlutterProject);
testUsingContext('reports when the app is using AndroidX', () async { testUsingContext('reports when the app is using AndroidX', () async {
final String projectPath = await createProject(tempDir, final String projectPath = await createProject(tempDir,
...@@ -413,8 +409,7 @@ flutter: ...@@ -413,8 +409,7 @@ flutter:
FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir), FlutterProjectFactory: () => FakeFlutterProjectFactory(tempDir),
ProcessManager: () => mockProcessManager, ProcessManager: () => mockProcessManager,
Usage: () => mockUsage, Usage: () => mockUsage,
}, });
timeout: allowForCreateFlutterProject);
}); });
} }
......
...@@ -2,13 +2,9 @@ ...@@ -2,13 +2,9 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Integration tests which invoke flutter instead of unit testing the code
// will not produce meaningful coverage information - we can measure coverage
// from the isolate running the test, but not from the isolate started via
// the command line process.
@Tags(<String>['no_coverage'])
import 'dart:async'; import 'dart:async';
import 'dart:convert'; import 'dart:convert';
import 'dart:io';
import 'package:file/file.dart'; import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart'; import 'package:flutter_tools/src/base/file_system.dart';
...@@ -21,79 +17,58 @@ import 'test_driver.dart'; ...@@ -21,79 +17,58 @@ import 'test_driver.dart';
import 'test_utils.dart'; import 'test_utils.dart';
void main() { void main() {
group('daemon_mode', () { test('device.getDevices', () async {
Directory tempDir; final Directory tempDir = createResolvedTempDirectorySync('daemon_mode_test.');
final BasicProject _project = BasicProject();
Process process;
setUp(() async {
tempDir = createResolvedTempDirectorySync('daemon_mode_test.');
await _project.setUpIn(tempDir);
});
tearDown(() async {
tryToDelete(tempDir);
process?.kill();
});
test('device.getDevices', () async {
final String flutterBin =
fs.path.join(getFlutterRoot(), 'bin', 'flutter');
const ProcessManager processManager = LocalProcessManager();
process = await processManager.start(
<String>[flutterBin, '--show-test-device', 'daemon'],
workingDirectory: tempDir.path);
final StreamController<String> stdout =
StreamController<String>.broadcast();
transformToLines(process.stdout)
.listen((String line) => stdout.add(line));
final Stream<Map<String, dynamic>> stream = final BasicProject _project = BasicProject();
stdout.stream.where((String line) { await _project.setUpIn(tempDir);
final Map<String, dynamic> response = parseFlutterResponse(line);
// ignore 'Starting device daemon...' final String flutterBin = fs.path.join(getFlutterRoot(), 'bin', 'flutter');
if (response == null) {
return false; const ProcessManager processManager = LocalProcessManager();
} final Process process = await processManager.start(
// TODO(devoncarew): Remove this after #25440 lands. <String>[flutterBin, '--show-test-device', 'daemon'],
if (response['event'] == 'daemon.showMessage') { workingDirectory: tempDir.path,
return false; );
}
return true; final StreamController<String> stdout = StreamController<String>.broadcast();
}).map(parseFlutterResponse); transformToLines(process.stdout).listen((String line) => stdout.add(line));
final Stream<Map<String, dynamic>> stream = stdout
Map<String, dynamic> response = await stream.first; .stream
expect(response['event'], 'daemon.connected'); .map<Map<String, dynamic>>(parseFlutterResponse)
.where((Map<String, dynamic> value) => value != null);
// start listening for devices
process.stdin.writeln('[${jsonEncode(<String, dynamic>{ Map<String, dynamic> response = await stream.first;
'id': 1, expect(response['event'], 'daemon.connected');
'method': 'device.enable',
})}]'); // start listening for devices
response = await stream.first; process.stdin.writeln('[${jsonEncode(<String, dynamic>{
expect(response['id'], 1); 'id': 1,
expect(response['error'], isNull); 'method': 'device.enable',
})}]');
// [{"event":"device.added","params":{"id":"flutter-tester","name": response = await stream.first;
// "Flutter test device","platform":"flutter-tester","emulator":false}}] expect(response['id'], 1);
response = await stream.first; expect(response['error'], isNull);
expect(response['event'], 'device.added');
// [{"event":"device.added","params":{"id":"flutter-tester","name":
// get the list of all devices // "Flutter test device","platform":"flutter-tester","emulator":false}}]
process.stdin.writeln('[${jsonEncode(<String, dynamic>{ response = await stream.first;
'id': 2, expect(response['event'], 'device.added');
'method': 'device.getDevices',
})}]'); // get the list of all devices
response = await stream.first; process.stdin.writeln('[${jsonEncode(<String, dynamic>{
expect(response['id'], 2); 'id': 2,
expect(response['error'], isNull); 'method': 'device.getDevices',
})}]');
final dynamic result = response['result']; response = await stream.first;
expect(result, isList); expect(response['id'], 2);
expect(result, isNotEmpty); expect(response['error'], isNull);
});
}, timeout: const Timeout.factor(10), tags: <String>['integration']); // This test uses the `flutter` tool, which could be blocked behind the startup lock for a long time. final dynamic result = response['result'];
expect(result, isList);
expect(result, isNotEmpty);
tryToDelete(tempDir);
process.kill();
});
} }
...@@ -2,11 +2,8 @@ ...@@ -2,11 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Integration tests which invoke flutter instead of unit testing the code import 'dart:io';
// will not produce meaningful coverage information - we can measure coverage
// from the isolate running the test, but not from the isolate started via
// the command line process.
@Tags(<String>['no_coverage'])
import 'package:file/file.dart'; import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart'; import 'package:flutter_tools/src/base/file_system.dart';
...@@ -16,43 +13,37 @@ import 'test_driver.dart'; ...@@ -16,43 +13,37 @@ import 'test_driver.dart';
import 'test_utils.dart'; import 'test_utils.dart';
void main() { void main() {
group('debugger', () { test('can step over statements', () async {
Directory tempDir; final Directory tempDir = createResolvedTempDirectorySync('debugger_stepping_test.');
final SteppingProject _project = SteppingProject(); final SteppingProject _project = SteppingProject();
FlutterRunTestDriver _flutter; await _project.setUpIn(tempDir);
setUp(() async { final FlutterRunTestDriver _flutter = FlutterRunTestDriver(tempDir);
tempDir = createResolvedTempDirectorySync('debugger_stepping_test.');
await _project.setUpIn(tempDir); await _flutter.run(withDebugger: true, startPaused: true);
_flutter = FlutterRunTestDriver(tempDir); await _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine);
}); await _flutter.resume();
await _flutter.waitForPause(); // Now we should be on the breakpoint.
tearDown(() async {
await _flutter.stop(); expect((await _flutter.getSourceLocation()).line, equals(_project.breakpointLine));
tryToDelete(tempDir);
}); // Issue 5 steps, ensuring that we end up on the annotated lines each time.
for (int i = 1; i <= _project.numberOfSteps; i += 1) {
test('can step over statements', () async { await _flutter.stepOverOrOverAsyncSuspension();
await _flutter.run(withDebugger: true, startPaused: true); final SourcePosition location = await _flutter.getSourceLocation();
await _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine); final int actualLine = location.line;
await _flutter.resume();
await _flutter.waitForPause(); // Now we should be on the breakpoint. // Get the line we're expected to stop at by searching for the comment
// within the source code.
expect((await _flutter.getSourceLocation()).line, equals(_project.breakpointLine)); final int expectedLine = _project.lineForStep(i);
// Issue 5 steps, ensuring that we end up on the annotated lines each time. expect(actualLine, equals(expectedLine),
for (int i = 1; i <= _project.numberOfSteps; i += 1) { reason: 'After $i steps, debugger should stop at $expectedLine but stopped at $actualLine'
await _flutter.stepOverOrOverAsyncSuspension(); );
final SourcePosition location = await _flutter.getSourceLocation(); }
final int actualLine = location.line;
await _flutter.stop();
// Get the line we're expected to stop at by searching for the comment tryToDelete(tempDir);
// within the source code. });
final int expectedLine = _project.lineForStep(i);
expect(actualLine, equals(expectedLine),
reason: 'After $i steps, debugger should stop at $expectedLine but stopped at $actualLine');
}
});
}, timeout: const Timeout.factor(10), tags: <String>['integration']); // The DevFS sync takes a really long time, so these tests can be slow.
} }
...@@ -2,12 +2,8 @@ ...@@ -2,12 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Integration tests which invoke flutter instead of unit testing the code
// will not produce meaningful coverage information - we can measure coverage
// from the isolate running the test, but not from the isolate started via
// the command line process.
@Tags(<String>['no_coverage'])
import 'dart:async'; import 'dart:async';
import 'dart:io';
import 'package:file/file.dart'; import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart'; import 'package:flutter_tools/src/base/file_system.dart';
...@@ -20,120 +16,133 @@ import 'test_data/tests_project.dart'; ...@@ -20,120 +16,133 @@ import 'test_data/tests_project.dart';
import 'test_driver.dart'; import 'test_driver.dart';
import 'test_utils.dart'; import 'test_utils.dart';
void main() { void batch1() {
group('flutter run expression evaluation', () { final BasicProject _project = BasicProject();
Directory tempDir; Directory tempDir;
final BasicProject _project = BasicProject(); FlutterRunTestDriver _flutter;
FlutterRunTestDriver _flutter;
Future<void> initProject() async {
setUp(() async { tempDir = createResolvedTempDirectorySync('run_expression_eval_test.');
tempDir = createResolvedTempDirectorySync('run_expression_eval_test.'); await _project.setUpIn(tempDir);
await _project.setUpIn(tempDir); _flutter = FlutterRunTestDriver(tempDir);
_flutter = FlutterRunTestDriver(tempDir); }
});
Future<void> cleanProject() async {
tearDown(() async { await _flutter.stop();
await _flutter.stop(); tryToDelete(tempDir);
tryToDelete(tempDir); }
});
Future<void> breakInBuildMethod(FlutterTestDriver flutter) async {
Future<void> breakInBuildMethod(FlutterTestDriver flutter) async { await _flutter.breakAt(
await _flutter.breakAt( _project.buildMethodBreakpointUri,
_project.buildMethodBreakpointUri, _project.buildMethodBreakpointLine,
_project.buildMethodBreakpointLine, );
); }
}
Future<void> breakInTopLevelFunction(FlutterTestDriver flutter) async {
Future<void> breakInTopLevelFunction(FlutterTestDriver flutter) async { await _flutter.breakAt(
await _flutter.breakAt( _project.topLevelFunctionBreakpointUri,
_project.topLevelFunctionBreakpointUri, _project.topLevelFunctionBreakpointLine,
_project.topLevelFunctionBreakpointLine, );
); }
}
test('flutter run expression evaluation - can evaluate trivial expressions in top level function', () async {
test('can evaluate trivial expressions in top level function', () async { await initProject();
await _flutter.run(withDebugger: true); await _flutter.run(withDebugger: true);
await breakInTopLevelFunction(_flutter); await breakInTopLevelFunction(_flutter);
await evaluateTrivialExpressions(_flutter); await evaluateTrivialExpressions(_flutter);
}); await cleanProject();
});
test('can evaluate trivial expressions in build method', () async {
await _flutter.run(withDebugger: true); test('flutter run expression evaluation - can evaluate trivial expressions in build method', () async {
await breakInBuildMethod(_flutter); await initProject();
await evaluateTrivialExpressions(_flutter); await _flutter.run(withDebugger: true);
}); await breakInBuildMethod(_flutter);
await evaluateTrivialExpressions(_flutter);
test('can evaluate complex expressions in top level function', () async { await cleanProject();
await _flutter.run(withDebugger: true); });
await breakInTopLevelFunction(_flutter);
await evaluateComplexExpressions(_flutter); test('flutter run expression evaluation - can evaluate complex expressions in top level function', () async {
}); await initProject();
await _flutter.run(withDebugger: true);
test('can evaluate complex expressions in build method', () async { await breakInTopLevelFunction(_flutter);
await _flutter.run(withDebugger: true); await evaluateComplexExpressions(_flutter);
await breakInBuildMethod(_flutter); await cleanProject();
await evaluateComplexExpressions(_flutter); });
});
test('flutter run expression evaluation - can evaluate complex expressions in build method', () async {
test('can evaluate expressions returning complex objects in top level function', () async { await initProject();
await _flutter.run(withDebugger: true); await _flutter.run(withDebugger: true);
await breakInTopLevelFunction(_flutter); await breakInBuildMethod(_flutter);
await evaluateComplexReturningExpressions(_flutter); await evaluateComplexExpressions(_flutter);
}); await cleanProject();
});
test('can evaluate expressions returning complex objects in build method', () async {
await _flutter.run(withDebugger: true); test('flutter run expression evaluation - can evaluate expressions returning complex objects in top level function', () async {
await breakInBuildMethod(_flutter); await initProject();
await evaluateComplexReturningExpressions(_flutter); await _flutter.run(withDebugger: true);
}); await breakInTopLevelFunction(_flutter);
}, timeout: const Timeout.factor(10), tags: <String>['integration']); // The DevFS sync takes a really long time, so these tests can be slow. await evaluateComplexReturningExpressions(_flutter);
await cleanProject();
group('flutter test expression evaluation', () { });
Directory tempDir;
final TestsProject _project = TestsProject(); test('flutter run expression evaluation - can evaluate expressions returning complex objects in build method', () async {
FlutterTestTestDriver _flutter; await initProject();
await _flutter.run(withDebugger: true);
setUp(() async { await breakInBuildMethod(_flutter);
tempDir = createResolvedTempDirectorySync('test_expression_eval_test.'); await evaluateComplexReturningExpressions(_flutter);
await _project.setUpIn(tempDir); await cleanProject();
_flutter = FlutterTestTestDriver(tempDir); });
}); }
tearDown(() async { void batch2() {
await _flutter.quit(); final TestsProject _project = TestsProject();
tryToDelete(tempDir); Directory tempDir;
}); FlutterTestTestDriver _flutter;
test('can evaluate trivial expressions in a test', () async { Future<void> initProject() async {
await _flutter.test( tempDir = createResolvedTempDirectorySync('test_expression_eval_test.');
withDebugger: true, await _project.setUpIn(tempDir);
beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine), _flutter = FlutterTestTestDriver(tempDir);
); }
await _flutter.waitForPause();
await evaluateTrivialExpressions(_flutter); Future<void> cleanProject() async {
await _flutter.resume(); await _flutter?.quit();
}); tryToDelete(tempDir);
}
test('can evaluate complex expressions in a test', () async {
await _flutter.test( test('flutter test expression evaluation - can evaluate trivial expressions in a test', () async {
withDebugger: true, await initProject();
beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine), await _flutter.test(
); withDebugger: true,
await _flutter.waitForPause(); beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine),
await evaluateComplexExpressions(_flutter); );
await _flutter.resume(); await _flutter.waitForPause();
}); await evaluateTrivialExpressions(_flutter);
await cleanProject();
test('can evaluate expressions returning complex objects in a test', () async { });
await _flutter.test(
withDebugger: true, test('flutter test expression evaluation - can evaluate complex expressions in a test', () async {
beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine), await initProject();
); await _flutter.test(
await _flutter.waitForPause(); withDebugger: true,
await evaluateComplexReturningExpressions(_flutter); beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine),
await _flutter.resume(); );
}); await _flutter.waitForPause();
}, timeout: const Timeout.factor(10), tags: <String>['integration']); // The DevFS sync takes a really long time, so these tests can be slow. await evaluateComplexExpressions(_flutter);
await cleanProject();
});
test('flutter test expression evaluation - can evaluate expressions returning complex objects in a test', () async {
await initProject();
await _flutter.test(
withDebugger: true,
beforeStart: () => _flutter.addBreakpoint(_project.breakpointUri, _project.breakpointLine),
);
await _flutter.waitForPause();
await evaluateComplexReturningExpressions(_flutter);
await cleanProject();
});
} }
Future<void> evaluateTrivialExpressions(FlutterTestDriver flutter) async { Future<void> evaluateTrivialExpressions(FlutterTestDriver flutter) async {
...@@ -164,3 +173,8 @@ Future<void> evaluateComplexReturningExpressions(FlutterTestDriver flutter) asyn ...@@ -164,3 +173,8 @@ Future<void> evaluateComplexReturningExpressions(FlutterTestDriver flutter) asyn
final InstanceRef res = await flutter.evaluate(resp.id, r'"$year-$month-$day"'); final InstanceRef res = await flutter.evaluate(resp.id, r'"$year-$month-$day"');
expect(res.valueAsString, equals('${now.year}-${now.month}-${now.day}')); expect(res.valueAsString, equals('${now.year}-${now.month}-${now.day}'));
} }
void main() {
batch1();
batch2();
}
...@@ -2,11 +2,8 @@ ...@@ -2,11 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Integration tests which invoke flutter instead of unit testing the code import 'dart:io';
// will not produce meaningful coverage information - we can measure coverage
// from the isolate running the test, but not from the isolate started via
// the command line process.
@Tags(<String>['no_coverage'])
import 'package:file/file.dart'; import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart'; import 'package:flutter_tools/src/base/file_system.dart';
...@@ -33,35 +30,36 @@ void main() { ...@@ -33,35 +30,36 @@ void main() {
tryToDelete(tempDir); tryToDelete(tempDir);
}); });
group('attached process', () { test('writes pid-file', () async {
test('writes pid-file', () async { final File pidFile = tempDir.childFile('test.pid');
final File pidFile = tempDir.childFile('test.pid'); await _flutterRun.run(withDebugger: true);
await _flutterRun.run(withDebugger: true); await _flutterAttach.attach(
await _flutterAttach.attach( _flutterRun.vmServicePort,
_flutterRun.vmServicePort, pidFile: pidFile,
pidFile: pidFile, );
); expect(pidFile.existsSync(), isTrue);
expect(pidFile.existsSync(), isTrue); });
});
test('can hot reload', () async { test('can hot reload', () async {
await _flutterRun.run(withDebugger: true); await _flutterRun.run(withDebugger: true);
await _flutterAttach.attach(_flutterRun.vmServicePort); await _flutterAttach.attach(_flutterRun.vmServicePort);
await _flutterAttach.hotReload(); await _flutterAttach.hotReload();
}); });
test('can detach, reattach, hot reload', () async {
await _flutterRun.run(withDebugger: true); test('can detach, reattach, hot reload', () async {
await _flutterAttach.attach(_flutterRun.vmServicePort); await _flutterRun.run(withDebugger: true);
await _flutterAttach.detach(); await _flutterAttach.attach(_flutterRun.vmServicePort);
await _flutterAttach.attach(_flutterRun.vmServicePort); await _flutterAttach.detach();
await _flutterAttach.hotReload(); await _flutterAttach.attach(_flutterRun.vmServicePort);
}); await _flutterAttach.hotReload();
test('killing process behaves the same as detach ', () async { });
await _flutterRun.run(withDebugger: true);
await _flutterAttach.attach(_flutterRun.vmServicePort); test('killing process behaves the same as detach ', () async {
await _flutterAttach.quit(); await _flutterRun.run(withDebugger: true);
_flutterAttach = FlutterRunTestDriver(tempDir, logPrefix: 'ATTACH-2'); await _flutterAttach.attach(_flutterRun.vmServicePort);
await _flutterAttach.attach(_flutterRun.vmServicePort); await _flutterAttach.quit();
await _flutterAttach.hotReload(); _flutterAttach = FlutterRunTestDriver(tempDir, logPrefix: 'ATTACH-2');
}); await _flutterAttach.attach(_flutterRun.vmServicePort);
}, timeout: const Timeout.factor(10), tags: <String>['integration']); // The DevFS sync takes a really long time, so these tests can be slow. await _flutterAttach.hotReload();
});
} }
...@@ -2,11 +2,6 @@ ...@@ -2,11 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Integration tests which invoke flutter instead of unit testing the code
// will not produce meaningful coverage information - we can measure coverage
// from the isolate running the test, but not from the isolate started via
// the command line process.
@Tags(<String>['no_coverage'])
import 'package:file/file.dart'; import 'package:file/file.dart';
import 'package:flutter_tools/src/base/file_system.dart'; import 'package:flutter_tools/src/base/file_system.dart';
import 'package:flutter_tools/src/base/io.dart'; import 'package:flutter_tools/src/base/io.dart';
...@@ -18,47 +13,45 @@ import 'test_driver.dart'; ...@@ -18,47 +13,45 @@ import 'test_driver.dart';
import 'test_utils.dart'; import 'test_utils.dart';
void main() { void main() {
group('flutter_run', () { Directory tempDir;
Directory tempDir; final BasicProject _project = BasicProject();
final BasicProject _project = BasicProject(); FlutterRunTestDriver _flutter;
FlutterRunTestDriver _flutter;
setUp(() async {
setUp(() async { tempDir = createResolvedTempDirectorySync('run_test.');
tempDir = createResolvedTempDirectorySync('run_test.'); await _project.setUpIn(tempDir);
await _project.setUpIn(tempDir); _flutter = FlutterRunTestDriver(tempDir);
_flutter = FlutterRunTestDriver(tempDir); });
});
tearDown(() async {
tearDown(() async { await _flutter.stop();
await _flutter.stop(); tryToDelete(tempDir);
tryToDelete(tempDir); });
});
test('flutter run reports an error if an invalid device is supplied', () async {
test('reports an error if an invalid device is supplied', () async { // This test forces flutter to check for all possible devices to catch issues
// This test forces flutter to check for all possible devices to catch issues // like https://github.com/flutter/flutter/issues/21418 which were skipped
// like https://github.com/flutter/flutter/issues/21418 which were skipped // over because other integration tests run using flutter-tester which short-cuts
// over because other integration tests run using flutter-tester which short-cuts // some of the checks for devices.
// some of the checks for devices. final String flutterBin = fs.path.join(getFlutterRoot(), 'bin', 'flutter');
final String flutterBin = fs.path.join(getFlutterRoot(), 'bin', 'flutter');
const ProcessManager _processManager = LocalProcessManager();
const ProcessManager _processManager = LocalProcessManager(); final ProcessResult _proc = await _processManager.run(
final ProcessResult _proc = await _processManager.run( <String>[flutterBin, 'run', '-d', 'invalid-device-id'],
<String>[flutterBin, 'run', '-d', 'invalid-device-id'], workingDirectory: tempDir.path,
workingDirectory: tempDir.path, );
);
expect(_proc.stdout, isNot(contains('flutter has exited unexpectedly')));
expect(_proc.stdout, isNot(contains('flutter has exited unexpectedly'))); expect(_proc.stderr, isNot(contains('flutter has exited unexpectedly')));
expect(_proc.stderr, isNot(contains('flutter has exited unexpectedly'))); if (!_proc.stderr.toString().contains('Unable to locate a development')
if (!_proc.stderr.toString().contains('Unable to locate a development') && !_proc.stdout.toString().contains('No devices found with name or id matching')) {
&& !_proc.stdout.toString().contains('No devices found with name or id matching')) { fail("'flutter run -d invalid-device-id' did not produce the expected error");
fail("'flutter run -d invalid-device-id' did not produce the expected error"); }
} });
});
test('flutter run writes pid-file', () async {
test('writes pid-file', () async { final File pidFile = tempDir.childFile('test.pid');
final File pidFile = tempDir.childFile('test.pid'); await _flutter.run(pidFile: pidFile);
await _flutter.run(pidFile: pidFile); expect(pidFile.existsSync(), isTrue);
expect(pidFile.existsSync(), isTrue); });
});
}, timeout: const Timeout.factor(10), tags: <String>['integration']); // The DevFS sync takes a really long time, so these tests can be slow.
} }
...@@ -2,11 +2,6 @@ ...@@ -2,11 +2,6 @@
// Use of this source code is governed by a BSD-style license that can be // Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file. // found in the LICENSE file.
// Integration tests which invoke flutter instead of unit testing the code
// will not produce meaningful coverage information - we can measure coverage
// from the isolate running the test, but not from the isolate started via
// the command line process.
@Tags(<String>['no_coverage'])
import 'dart:async'; import 'dart:async';
import 'package:file/file.dart'; import 'package:file/file.dart';
...@@ -23,32 +18,30 @@ import 'test_utils.dart'; ...@@ -23,32 +18,30 @@ import 'test_utils.dart';
const Duration requiredLifespan = Duration(seconds: 5); const Duration requiredLifespan = Duration(seconds: 5);
void main() { void main() {
group('flutter run', () { final BasicProject _project = BasicProject();
final BasicProject _project = BasicProject(); FlutterRunTestDriver _flutter;
FlutterRunTestDriver _flutter; Directory tempDir;
Directory tempDir;
setUp(() async {
setUp(() async { tempDir = createResolvedTempDirectorySync('lifetime_test.');
tempDir = createResolvedTempDirectorySync('lifetime_test.'); await _project.setUpIn(tempDir);
await _project.setUpIn(tempDir); _flutter = FlutterRunTestDriver(tempDir);
_flutter = FlutterRunTestDriver(tempDir); });
});
tearDown(() async {
tearDown(() async { await _flutter.stop();
await _flutter.stop(); tryToDelete(tempDir);
tryToDelete(tempDir); });
});
test('flutter run does not terminate when a debugger is attached', () async {
test('does not terminate when a debugger is attached', () async { await _flutter.run(withDebugger: true);
await _flutter.run(withDebugger: true); await Future<void>.delayed(requiredLifespan);
await Future<void>.delayed(requiredLifespan); expect(_flutter.hasExited, equals(false));
expect(_flutter.hasExited, equals(false)); });
});
test('fluter run does not terminate when a debugger is attached and pause-on-exceptions', () async {
test('does not terminate when a debugger is attached and pause-on-exceptions', () async { await _flutter.run(withDebugger: true, pauseOnExceptions: true);
await _flutter.run(withDebugger: true, pauseOnExceptions: true); await Future<void>.delayed(requiredLifespan);
await Future<void>.delayed(requiredLifespan); expect(_flutter.hasExited, equals(false));
expect(_flutter.hasExited, equals(false)); });
});
}, timeout: const Timeout.factor(10), tags: <String>['integration']); // The DevFS sync takes a really long time, so these tests can be slow.
} }
...@@ -127,13 +127,6 @@ Future<String> createProject(Directory temp, { List<String> arguments }) async { ...@@ -127,13 +127,6 @@ Future<String> createProject(Directory temp, { List<String> arguments }) async {
return projectPath; return projectPath;
} }
/// Test case timeout for tests involving remote calls to `pub get` or similar.
const Timeout allowForRemotePubInvocation = Timeout.factor(10.0);
/// Test case timeout for tests involving creating a Flutter project with
/// `--no-pub`. Use [allowForRemotePubInvocation] when creation involves `pub`.
const Timeout allowForCreateFlutterProject = Timeout.factor(3.0);
Future<void> expectToolExitLater(Future<dynamic> future, Matcher messageMatcher) async { Future<void> expectToolExitLater(Future<dynamic> future, Matcher messageMatcher) async {
try { try {
await future; await future;
......
...@@ -48,7 +48,6 @@ typedef ContextInitializer = void Function(AppContext testContext); ...@@ -48,7 +48,6 @@ typedef ContextInitializer = void Function(AppContext testContext);
void testUsingContext( void testUsingContext(
String description, String description,
dynamic testMethod(), { dynamic testMethod(), {
Timeout timeout,
Map<Type, Generator> overrides = const <Type, Generator>{}, Map<Type, Generator> overrides = const <Type, Generator>{},
bool initializeFlutterRoot = true, bool initializeFlutterRoot = true,
String testOn, String testOn,
...@@ -137,8 +136,7 @@ void testUsingContext( ...@@ -137,8 +136,7 @@ void testUsingContext(
}, },
); );
}); });
}, timeout: timeout ?? const Timeout(Duration(seconds: 60)), }, testOn: testOn, skip: skip);
testOn: testOn, skip: skip);
} }
void _printBufferedErrors(AppContext testContext) { void _printBufferedErrors(AppContext testContext) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment