Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
16f7d401
Unverified
Commit
16f7d401
authored
Oct 16, 2018
by
Mehmet Fidanboylu
Committed by
GitHub
Oct 16, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unneeded flutter-assets-dir flag for the tester (#23125)
parent
9dff83f4
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
1 addition
and
36 deletions
+1
-36
flutter_platform.dart
packages/flutter_tools/lib/src/test/flutter_platform.dart
+1
-36
No files found.
packages/flutter_tools/lib/src/test/flutter_platform.dart
View file @
16f7d401
...
...
@@ -480,7 +480,6 @@ class _FlutterPlatform extends PlatformPlugin {
packages:
PackageMap
.
globalPackagesPath
,
enableObservatory:
enableObservatory
,
startPaused:
startPaused
,
bundlePath:
_getBundlePath
(
finalizers
,
ourTestCount
),
observatoryPort:
explicitObservatoryPort
,
serverPort:
server
.
port
,
);
...
...
@@ -712,37 +711,6 @@ class _FlutterPlatform extends PlatformPlugin {
return
listenerFile
.
path
;
}
String
_getBundlePath
(
List
<
_Finalizer
>
finalizers
,
int
ourTestCount
)
{
if
(
precompiledDillPath
!=
null
)
{
return
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
);
}
// bundlePath needs to point to a folder with `platform.dill` file.
final
Directory
tempBundleDirectory
=
fs
.
systemTempDirectory
.
createTempSync
(
'flutter_test_bundle.'
);
finalizers
.
add
(()
async
{
printTrace
(
'test
$ourTestCount
: deleting temporary bundle directory'
);
tempBundleDirectory
.
deleteSync
(
recursive:
true
);
});
// copy 'vm_platform_strong.dill' into 'platform_strong.dill'
final
File
vmPlatformStrongDill
=
fs
.
file
(
artifacts
.
getArtifactPath
(
Artifact
.
platformKernelDill
),
);
printTrace
(
'Copying platform_strong.dill file from
${vmPlatformStrongDill.path}
'
);
final
File
platformDill
=
vmPlatformStrongDill
.
copySync
(
tempBundleDirectory
.
childFile
(
'platform_strong.dill'
)
.
path
,
);
if
(!
platformDill
.
existsSync
())
{
printError
(
'unexpected error copying platform kernel file'
);
}
return
tempBundleDirectory
.
path
;
}
String
_generateTestMain
({
Uri
testUrl
,
})
{
...
...
@@ -813,7 +781,6 @@ class _FlutterPlatform extends PlatformPlugin {
String
executable
,
String
testPath
,
{
String
packages
,
String
bundlePath
,
bool
enableObservatory
=
false
,
bool
startPaused
=
false
,
int
observatoryPort
,
...
...
@@ -841,9 +808,7 @@ class _FlutterPlatform extends PlatformPlugin {
}
if
(
host
.
type
==
InternetAddressType
.
IPv6
)
command
.
add
(
'--ipv6'
);
if
(
bundlePath
!=
null
)
{
command
.
add
(
'--flutter-assets-dir=
$bundlePath
'
);
}
command
.
add
(
'--enable-checked-mode'
);
command
.
addAll
(<
String
>[
'--enable-software-rendering'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment