Unverified Commit 1667d0ca authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

rename port to web-port and hostname to web-hostname (#40370)

parent baa12b33
...@@ -289,8 +289,8 @@ class RunCommand extends RunCommandBase { ...@@ -289,8 +289,8 @@ class RunCommand extends RunCommandBase {
dumpSkpOnShaderCompilation: argResults['dump-skp-on-shader-compilation'], dumpSkpOnShaderCompilation: argResults['dump-skp-on-shader-compilation'],
observatoryPort: observatoryPort, observatoryPort: observatoryPort,
verboseSystemLogs: argResults['verbose-system-logs'], verboseSystemLogs: argResults['verbose-system-logs'],
hostname: featureFlags.isWebEnabled ? argResults['hostname'] : '', hostname: featureFlags.isWebEnabled ? argResults['web-hostname'] : '',
port: featureFlags.isWebEnabled ? argResults['port'] : '', port: featureFlags.isWebEnabled ? argResults['web-port'] : '',
); );
} }
} }
......
...@@ -133,12 +133,12 @@ abstract class FlutterCommand extends Command<void> { ...@@ -133,12 +133,12 @@ abstract class FlutterCommand extends Command<void> {
} }
void usesWebOptions({ bool hide = true }) { void usesWebOptions({ bool hide = true }) {
argParser.addOption('hostname', argParser.addOption('web-hostname',
defaultsTo: 'localhost', defaultsTo: 'localhost',
help: 'The hostname to serve web application on.', help: 'The hostname to serve web application on.',
hide: hide, hide: hide,
); );
argParser.addOption('port', argParser.addOption('web-port',
defaultsTo: null, defaultsTo: null,
help: 'The host port to serve the web application from. If not provided, the tool ' help: 'The host port to serve the web application from. If not provided, the tool '
'will select a random open port on the host.', 'will select a random open port on the host.',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment