Unverified Commit 159db5ca authored by Devon Carew's avatar Devon Carew Committed by GitHub

pass through preview-dart-2, strong, ipv6 in daemon mode (#14200)

* pass through preview-dart-2, strong, ipv6 in daemon mode

* ws change to kick the windows bot
parent a92110a2
...@@ -347,12 +347,16 @@ class AppDomain extends Domain { ...@@ -347,12 +347,16 @@ class AppDomain extends Domain {
Device device, String projectDirectory, String target, String route, Device device, String projectDirectory, String target, String route,
DebuggingOptions options, bool enableHotReload, { DebuggingOptions options, bool enableHotReload, {
String applicationBinary, String applicationBinary,
bool previewDart2: false,
bool strongMode: false,
String projectRootPath, String projectRootPath,
String packagesFilePath, String packagesFilePath,
String projectAssets, String projectAssets,
bool ipv6: false,
}) async { }) async {
if (await device.isLocalEmulator && !options.buildInfo.supportsEmulator) if (await device.isLocalEmulator && !options.buildInfo.supportsEmulator) {
throw '${toTitleCase(options.buildInfo.modeName)} mode is not supported for emulators.'; throw '${toTitleCase(options.buildInfo.modeName)} mode is not supported for emulators.';
}
// We change the current working directory for the duration of the `start` command. // We change the current working directory for the duration of the `start` command.
final Directory cwd = fs.currentDirectory; final Directory cwd = fs.currentDirectory;
...@@ -369,9 +373,12 @@ class AppDomain extends Domain { ...@@ -369,9 +373,12 @@ class AppDomain extends Domain {
debuggingOptions: options, debuggingOptions: options,
usesTerminalUI: false, usesTerminalUI: false,
applicationBinary: applicationBinary, applicationBinary: applicationBinary,
previewDart2: previewDart2,
strongMode: strongMode,
projectRootPath: projectRootPath, projectRootPath: projectRootPath,
packagesFilePath: packagesFilePath, packagesFilePath: packagesFilePath,
projectAssets: projectAssets, projectAssets: projectAssets,
ipv6: ipv6,
hostIsIde: true, hostIsIde: true,
); );
} else { } else {
...@@ -381,6 +388,9 @@ class AppDomain extends Domain { ...@@ -381,6 +388,9 @@ class AppDomain extends Domain {
debuggingOptions: options, debuggingOptions: options,
usesTerminalUI: false, usesTerminalUI: false,
applicationBinary: applicationBinary, applicationBinary: applicationBinary,
previewDart2: previewDart2,
strongMode: strongMode,
ipv6: ipv6,
); );
} }
......
...@@ -257,9 +257,12 @@ class RunCommand extends RunCommandBase { ...@@ -257,9 +257,12 @@ class RunCommand extends RunCommandBase {
devices.first, fs.currentDirectory.path, targetFile, route, devices.first, fs.currentDirectory.path, targetFile, route,
_createDebuggingOptions(), hotMode, _createDebuggingOptions(), hotMode,
applicationBinary: argResults['use-application-binary'], applicationBinary: argResults['use-application-binary'],
previewDart2: argResults['preview-dart-2'],
strongMode: argResults['strong'],
projectRootPath: argResults['project-root'], projectRootPath: argResults['project-root'],
packagesFilePath: argResults['packages'], packagesFilePath: argResults['packages'],
projectAssets: argResults['project-assets'] projectAssets: argResults['project-assets'],
ipv6: ipv6,
); );
} catch (error) { } catch (error) {
throwToolExit(error.toString()); throwToolExit(error.toString());
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment