Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
1541dd3f
Unverified
Commit
1541dd3f
authored
Mar 17, 2023
by
godofredoc
Committed by
GitHub
Mar 17, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Re-enable engine dependency proxy test. (#115511)
Re-enable engine dependency proxy test.
parent
c77f1ab1
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
80 additions
and
50 deletions
+80
-50
.ci.yaml
.ci.yaml
+19
-0
TESTOWNERS
TESTOWNERS
+38
-35
engine_dependency_proxy_test.dart
dev/devicelab/bin/tasks/engine_dependency_proxy_test.dart
+23
-15
No files found.
.ci.yaml
View file @
1541dd3f
...
...
@@ -343,6 +343,25 @@ targets:
-
bin/**
-
.ci.yaml
-
name
:
Linux engine_dependency_proxy_test
recipe
:
devicelab/devicelab_drone
bringup
:
true
# New target: https://github.com/flutter/flutter/pull/115511
timeout
:
60
properties
:
dependencies
:
>-
[
{"dependency": "android_sdk", "version": "version:33v6"},
{"dependency": "chrome_and_driver", "version": "version:96.2"},
{"dependency": "open_jdk", "version": "version:11"}
]
tags: >
["devicelab", "hostonly", "linux"]
task_name: engine_dependency_proxy_test
runIf
:
-
dev/**
-
bin/**
-
.ci.yaml
-
name
:
Linux firebase_abstract_method_smoke_test
recipe
:
firebaselab/firebaselab
timeout
:
60
...
...
TESTOWNERS
View file @
1541dd3f
This diff is collapsed.
Click to expand it.
dev/devicelab/bin/tasks/
android_
engine_dependency_proxy_test.dart
→
dev/devicelab/bin/tasks/engine_dependency_proxy_test.dart
View file @
1541dd3f
...
...
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'dart:convert'
;
import
'dart:io'
;
import
'package:flutter_devicelab/framework/apk_utils.dart'
;
...
...
@@ -29,7 +30,7 @@ Future<void> main() async {
await
inDirectory
(
path
.
join
(
flutterProject
.
rootPath
,
'android'
),
()
async
{
section
(
'Insert gradle testing script'
);
final
File
build
=
File
(
path
.
join
(
flutterProject
.
rootPath
,
'android'
,
'app'
,
'build.gradle'
));
flutterProject
.
rootPath
,
'android'
,
'app'
,
'build.gradle'
));
build
.
writeAsStringSync
(
'''
task printEngineMavenUrl() {
...
...
@@ -43,31 +44,38 @@ task printEngineMavenUrl() {
);
section
(
'Checking default maven URL'
);
String
mavenUrl
=
await
eval
(
String
gradleOutput
=
await
eval
(
gradlewExecutable
,
<
String
>[
'printEngineMavenUrl'
,
'-q'
],
);
const
LineSplitter
splitter
=
LineSplitter
();
List
<
String
>
outputLines
=
splitter
.
convert
(
gradleOutput
);
String
mavenUrl
=
outputLines
.
last
;
print
(
'Returned maven url:
$mavenUrl
'
);
if
(
mavenUrl
!=
'https://storage.googleapis.com/download.flutter.io'
)
{
throw
TaskResult
.
failure
(
'Expected Android engine maven dependency URL to '
'resolve to https://storage.googleapis.com/download.flutter.io. Got '
'
$mavenUrl
instead'
);
'resolve to https://storage.googleapis.com/download.flutter.io. Got '
'
$mavenUrl
instead'
);
}
section
(
'Checking overridden maven URL'
);
mavenUrl
=
await
eval
(
gradlewExecutable
,
<
String
>[
'printEngineMavenUrl'
,
'-q'
],
environment:
<
String
,
String
>{
'FLUTTER_STORAGE_BASE_URL'
:
'https://my.special.proxy'
,
}
);
gradleOutput
=
await
eval
(
gradlewExecutable
,
<
String
>[
'printEngineMavenUrl'
,
'-q'
],
environment:
<
String
,
String
>{
'FLUTTER_STORAGE_BASE_URL'
:
'https://my.special.proxy'
,
}
);
outputLines
=
splitter
.
convert
(
gradleOutput
);
mavenUrl
=
outputLines
.
last
;
if
(
mavenUrl
!=
'https://my.special.proxy/download.flutter.io'
)
{
throw
TaskResult
.
failure
(
'Expected overridden Android engine maven '
'dependency URL to resolve to proxy location '
'https://my.special.proxy/download.flutter.io. Got '
'
$mavenUrl
instead'
);
throw
TaskResult
.
failure
(
'Expected overridden Android engine maven '
'dependency URL to resolve to proxy location '
'https://my.special.proxy/download.flutter.io. Got '
'
$mavenUrl
instead'
);
}
});
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment