Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
13a30c0c
Commit
13a30c0c
authored
Jan 29, 2019
by
akindone
Committed by
xster
Jan 29, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix: cuertino dialog action background blur effect (#25076)
parent
ef276ffe
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
6 deletions
+7
-6
action_sheet.dart
packages/flutter/lib/src/cupertino/action_sheet.dart
+1
-1
dialog.dart
packages/flutter/lib/src/cupertino/dialog.dart
+2
-2
dialog_test.dart
packages/flutter/test/cupertino/dialog_test.dart
+4
-3
No files found.
packages/flutter/lib/src/cupertino/action_sheet.dart
View file @
13a30c0c
...
...
@@ -1185,7 +1185,7 @@ class _RenderCupertinoAlertActions extends RenderBox
final
Path
backgroundFillPath
=
Path
()
..
fillType
=
PathFillType
.
evenOdd
..
addRect
(
Rect
.
largest
);
..
addRect
(
Rect
.
fromLTWH
(
0.0
,
0.0
,
size
.
width
,
size
.
height
)
);
final
Path
pressedBackgroundFillPath
=
Path
();
...
...
packages/flutter/lib/src/cupertino/dialog.dart
View file @
13a30c0c
...
...
@@ -1578,7 +1578,7 @@ class _RenderCupertinoDialogActions extends RenderBox
// Create the button backgrounds path and paint it.
final
Path
backgroundFillPath
=
Path
()
..
fillType
=
PathFillType
.
evenOdd
..
addRect
(
Rect
.
largest
)
..
addRect
(
Rect
.
fromLTWH
(
0.0
,
0.0
,
size
.
width
,
size
.
height
)
)
..
addRect
(
verticalDivider
);
for
(
int
i
=
0
;
i
<
pressedButtonRects
.
length
;
i
+=
1
)
{
...
...
@@ -1616,7 +1616,7 @@ class _RenderCupertinoDialogActions extends RenderBox
final
Path
backgroundFillPath
=
Path
()
..
fillType
=
PathFillType
.
evenOdd
..
addRect
(
Rect
.
largest
);
..
addRect
(
Rect
.
fromLTWH
(
0.0
,
0.0
,
size
.
width
,
size
.
height
)
);
final
Path
pressedBackgroundFillPath
=
Path
();
...
...
packages/flutter/test/cupertino/dialog_test.dart
View file @
13a30c0c
...
...
@@ -678,14 +678,15 @@ void main() {
// the dividers also paints a white background the size of Rect.largest.
// That background ends up being clipped by the containing ScrollView.
//
// Here we test that the largest Rect is contained within the painted Path.
// Here we test that the Rect(0.0, 0.0, renderBox.size.width, renderBox.size.height)
// is contained within the painted Path.
// We don't test for exclusion because for some reason the Path is reporting
// that even points beyond Rect.largest are within the Path. That's not an
// issue for our use-case, so we don't worry about it.
expect
(
actionsSectionBox
,
paints
..
path
(
includes:
<
Offset
>[
Offset
(
Rect
.
largest
.
left
,
Rect
.
largest
.
top
),
Offset
(
Rect
.
largest
.
right
,
Rect
.
largest
.
bottom
),
const
Offset
(
0.0
,
0.0
),
Offset
(
actionsSectionBox
.
size
.
width
,
actionsSectionBox
.
size
.
height
),
],
));
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment