Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
10c861d6
Commit
10c861d6
authored
May 20, 2016
by
Ian Hickson
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Track number of pending dartdocs too (#4088)
parent
06d80f22
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
5 additions
and
4 deletions
+5
-4
analyze.dart
packages/flutter_tools/lib/src/commands/analyze.dart
+5
-4
No files found.
packages/flutter_tools/lib/src/commands/analyze.dart
View file @
10c861d6
...
...
@@ -230,7 +230,7 @@ class AnalyzeCommand extends FlutterCommand {
String
elapsed
=
(
stopwatch
.
elapsedMilliseconds
/
1000.0
).
toStringAsFixed
(
1
);
if
(
_isBenchmarking
)
_writeBenchmark
(
stopwatch
,
errorCount
);
_writeBenchmark
(
stopwatch
,
errorCount
,
membersMissingDocumentation
);
if
(
errorCount
>
0
)
{
if
(
membersMissingDocumentation
>
0
&&
argResults
[
'flutter-repo'
])
...
...
@@ -346,7 +346,7 @@ class AnalyzeCommand extends FlutterCommand {
printStatus
(
'
$errorsMessage
• analyzed
$files
,
$seconds
seconds'
);
if
(
firstAnalysis
&&
_isBenchmarking
)
{
_writeBenchmark
(
analysisTimer
,
issueCount
);
_writeBenchmark
(
analysisTimer
,
issueCount
,
-
1
);
// TODO(ianh): track members missing dartdocs instead of saying -1
server
.
dispose
().
then
((
_
)
=>
exit
(
0
));
}
...
...
@@ -370,11 +370,12 @@ class AnalyzeCommand extends FlutterCommand {
return
false
;
}
void
_writeBenchmark
(
Stopwatch
stopwatch
,
int
errorCount
)
{
void
_writeBenchmark
(
Stopwatch
stopwatch
,
int
errorCount
,
int
membersMissingDocumentation
)
{
final
String
benchmarkOut
=
'analysis_benchmark.json'
;
Map
<
String
,
dynamic
>
data
=
<
String
,
dynamic
>{
'time'
:
(
stopwatch
.
elapsedMilliseconds
/
1000.0
),
'issues'
:
errorCount
'issues'
:
errorCount
,
'missingDartDocs'
:
membersMissingDocumentation
};
new
File
(
benchmarkOut
).
writeAsStringSync
(
toPrettyJson
(
data
));
printStatus
(
'Analysis benchmark written to
$benchmarkOut
(
$data
).'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment