Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
0fef7a14
Unverified
Commit
0fef7a14
authored
Jan 06, 2022
by
crisboarna
Committed by
GitHub
Jan 06, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
feat(flutter_tools): Changed NoIdeValidator validation type from error to warning (#95492)
parent
f8e70a84
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
3 additions
and
2 deletions
+3
-2
doctor_validator.dart
packages/flutter_tools/lib/src/doctor_validator.dart
+2
-1
doctor_test.dart
...utter_tools/test/commands.shard/hermetic/doctor_test.dart
+1
-1
No files found.
packages/flutter_tools/lib/src/doctor_validator.dart
View file @
0fef7a14
...
@@ -285,7 +285,8 @@ class NoIdeValidator extends DoctorValidator {
...
@@ -285,7 +285,8 @@ class NoIdeValidator extends DoctorValidator {
@override
@override
Future
<
ValidationResult
>
validate
()
async
{
Future
<
ValidationResult
>
validate
()
async
{
return
ValidationResult
(
return
ValidationResult
(
ValidationType
.
missing
,
// Info hint to user they do not have a supported IDE installed
ValidationType
.
notAvailable
,
globals
.
userMessages
.
noIdeInstallationInfo
.
map
((
String
ideInfo
)
=>
ValidationMessage
(
ideInfo
)).
toList
(),
globals
.
userMessages
.
noIdeInstallationInfo
.
map
((
String
ideInfo
)
=>
ValidationMessage
(
ideInfo
)).
toList
(),
statusInfo:
globals
.
userMessages
.
noIdeStatusInfo
,
statusInfo:
globals
.
userMessages
.
noIdeStatusInfo
,
);
);
...
...
packages/flutter_tools/test/commands.shard/hermetic/doctor_test.dart
View file @
0fef7a14
...
@@ -88,7 +88,7 @@ void main() {
...
@@ -88,7 +88,7 @@ void main() {
testUsingContext
(
'No IDE Validator includes expected installation messages'
,
()
async
{
testUsingContext
(
'No IDE Validator includes expected installation messages'
,
()
async
{
final
ValidationResult
result
=
await
NoIdeValidator
().
validate
();
final
ValidationResult
result
=
await
NoIdeValidator
().
validate
();
expect
(
result
.
type
,
ValidationType
.
missing
);
expect
(
result
.
type
,
ValidationType
.
notAvailable
);
expect
(
expect
(
result
.
messages
.
map
((
ValidationMessage
vm
)
=>
vm
.
message
),
result
.
messages
.
map
((
ValidationMessage
vm
)
=>
vm
.
message
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment