Merge pull request #4559 from pq/missing_returns

Add missing returns.

examples/flutter_gallery/lib/demo/calculator/logic.dart

@@ -83,6 +83,8 @@ class OperationToken extends ExpressionToken {
       case Operation.Division:
         return '  \u00F7  ';
     }
+    assert(operation != null);
+    return null;
   }
 }
 
@@ -257,6 +259,8 @@ class CalcExpression {
       case ExpressionState.NumberWithPoint:
       case ExpressionState.Result:
         return appendOperation(Operation.Subtraction);
+      default:
+        return null;
     }
   }
 

examples/flutter_gallery/lib/demo/grid_list_demo.dart

@@ -130,6 +130,8 @@ class GridDemoPhotoItem extends StatelessWidget {
           child: image
         );
     }
+    assert(tileStyle != null);
+    return null;
   }
 }
 

examples/stocks/lib/main.dart

@@ -75,6 +75,8 @@ class StocksAppState extends State<StocksApp> {
           accentColor: Colors.redAccent[200]
         );
     }
+    assert(_configuration.stockMode != null);
+    return null;
   }
 
   Route<Null> _getRoute(RouteSettings settings) {

packages/flutter/lib/src/animation/animations.dart

@@ -287,6 +287,8 @@ class ReverseAnimation extends Animation<double>
       case AnimationStatus.completed: return AnimationStatus.dismissed;
       case AnimationStatus.dismissed: return AnimationStatus.completed;
     }
+    assert(status != null);
+    return null;
   }
 
   @override

packages/flutter/lib/src/cassowary/expression.dart

@@ -157,7 +157,6 @@ class Expression extends EquationMember {
     if (!m.isConstant) {
       throw new ParserException(
           'The divisor was not a constant expression', <EquationMember>[this, m]);
-      return null;
     }
 
     return this._applyMultiplicand(1.0 / m.value);

packages/flutter/lib/src/material/button.dart

@@ -227,6 +227,8 @@ class _MaterialButtonState extends State<MaterialButton> {
           return Colors.white30;
       }
     }
+    assert(_colorBrightness != null);
+    return null;
   }
 
   void _handleHighlightChanged(bool value) {

packages/flutter/lib/src/material/dialog.dart

@@ -57,12 +57,15 @@ class Dialog extends StatelessWidget {
   final List<Widget> actions;
 
   Color _getColor(BuildContext context) {
-    switch (Theme.of(context).brightness) {
+    Brightness brightness = Theme.of(context).brightness;
+    switch (brightness) {
       case Brightness.light:
         return Colors.white;
       case Brightness.dark:
         return Colors.grey[800];
     }
+    assert(brightness != null);
+    return null;
   }
 
   @override

packages/flutter/lib/src/material/drawer_item.dart

@@ -67,6 +67,8 @@ class DrawerItem extends StatelessWidget {
           return Colors.white30;
         return null; // use default icon theme colour unmodified
     }
+    assert(themeData.brightness != null);
+    return null;
   }
 
   TextStyle _getTextStyle(ThemeData themeData) {

packages/flutter/lib/src/material/icon.dart

@@ -65,6 +65,8 @@ class Icon extends StatelessWidget {
       case Brightness.light:
         return Colors.black;
     }
+    assert(brightness != null);
+    return null;
   }
 
   Color _getDefaultColor(BuildContext context) {

packages/flutter/lib/src/material/raised_button.dart

@@ -98,12 +98,15 @@ class RaisedButton extends StatelessWidget {
     } else {
       if (disabledColor != null)
         return disabledColor;
-      switch (Theme.of(context).brightness) {
+      Brightness brightness = Theme.of(context).brightness;
+      switch (brightness) {
         case Brightness.light:
           return Colors.black12;
         case Brightness.dark:
           return Colors.white12;
       }
+      assert(brightness != null);
+      return null;
     }
   }
 

packages/flutter/lib/src/material/text_selection.dart

@@ -186,4 +186,6 @@ Widget buildTextSelectionHandle(
         child: handle
       );
   }
+  assert(type != null);
+  return null;
 }

packages/flutter/lib/src/painting/box_painter.dart

@@ -1353,6 +1353,8 @@ class BoxDecoration extends Decoration {
         double distance = (position - center).distance;
         return distance <= math.min(size.width, size.height) / 2.0;
     }
+    assert(shape != null);
+    return null;
   }
 
   @override

packages/flutter/lib/src/painting/text_painter.dart

@@ -125,6 +125,8 @@ class TextPainter {
       case TextBaseline.ideographic:
         return _paragraph.ideographicBaseline;
     }
+    assert(baseline != null);
+    return null;
   }
 
   double _lastMinWidth;
@@ -211,6 +213,8 @@ class TextPainter {
             ?? _getOffsetFromUpstream(offset, caretPrototype)
             ?? emptyOffset;
     }
+    assert(position.affinity != null);
+    return null;
   }
 
   /// Returns a list of rects that bound the given selection.

packages/flutter/lib/src/rendering/box.dart

@@ -1125,7 +1125,6 @@ abstract class RenderBox extends RenderObject {
           'set a size and lay out any children, or, set sizedByParent to true '
           'so that performResize() sizes the render object.'
         );
-        return true;
       }
       return true;
     });

packages/flutter/lib/src/rendering/list.dart

@@ -82,6 +82,8 @@ class RenderList extends RenderVirtualViewport<ListParentData> {
       case Axis.horizontal:
         return padding.horizontal;
     }
+    assert(mainAxis != null);
+    return null;
   }
 
   double get _preferredExtent {
@@ -108,6 +110,8 @@ class RenderList extends RenderVirtualViewport<ListParentData> {
         assert(debugThrowIfNotCheckingIntrinsics());
         return 0.0;
     }
+    assert(mainAxis != null);
+    return null;
   }
 
   @override

packages/flutter/lib/src/rendering/viewport.dart

@@ -57,6 +57,8 @@ class ViewportDimensions {
       case ViewportAnchor.end:
         return paintOffset + (containerSize - contentSize);
     }
+    assert(anchor != null);
+    return null;
   }
 
   @override
@@ -108,6 +110,8 @@ class RenderViewportBase extends RenderBox {
       case Axis.vertical:
         return offset.dx == 0.0;
     }
+    assert(direction != null);
+    return null;
   }
 
   /// The offset at which to paint the child.

packages/flutter/lib/src/widgets/banner.dart

@@ -90,6 +90,8 @@ class BannerPainter extends CustomPainter {
       case BannerLocation.topLeft:
         return 0.0;
     }
+    assert(location != null);
+    return null;
   }
 
   double _translationY(double height) {
@@ -101,6 +103,8 @@ class BannerPainter extends CustomPainter {
       case BannerLocation.topLeft:
         return 0.0;
     }
+    assert(location != null);
+    return null;
   }
 
   double get _rotation {
@@ -112,6 +116,8 @@ class BannerPainter extends CustomPainter {
       case BannerLocation.topLeft:
         return -math.PI / 4.0;
     }
+    assert(location != null);
+    return null;
   }
 }
 

packages/flutter/lib/src/widgets/dismissable.dart

@@ -245,7 +245,6 @@ class _DismissableState extends State<Dismissable> {
           return vy > _kMinFlingVelocity;
       }
     }
-    return false;
   }
 
   void _handleDragEnd(DragEndDetails details) {

packages/flutter/lib/src/widgets/lazy_block.dart

@@ -731,6 +731,8 @@ class _LazyBlockElement extends RenderObjectElement {
       case Axis.vertical:
         return size.height;
     }
+    assert(widget.mainAxis != null);
+    return null;
   }
 
   Offset _getMainAxisOffsetForSize(Size size) {
@@ -740,6 +742,8 @@ class _LazyBlockElement extends RenderObjectElement {
       case Axis.vertical:
         return new Offset(0.0, size.height);
     }
+    assert(widget.mainAxis != null);
+    return null;
   }
 
   static RenderBox _getNextWithin(_RenderLazyBlock block, RenderBox child) {

packages/flutter/lib/src/widgets/pageable_list.dart

@@ -224,6 +224,8 @@ abstract class PageableState<T extends Pageable> extends ScrollableState<T> {
       case Axis.vertical:
         return box.size.height;
     }
+    assert(config.scrollDirection != null);
+    return null;
   }
 
   @override
@@ -248,6 +250,8 @@ abstract class PageableState<T extends Pageable> extends ScrollableState<T> {
       case ViewportAnchor.end:
         return (_itemCount - scrollIndex - 1) % itemCount;
     }
+    assert(config.scrollAnchor != null);
+    return null;
   }
 
   @override
@@ -324,6 +328,8 @@ abstract class PageableState<T extends Pageable> extends ScrollableState<T> {
       case PageableListFlingBehavior.stopAtNextPage:
         return _flingToAdjacentItem(scrollVelocity);
     }
+    assert(config.itemsSnapAlignment != null);
+    return null;
   }
 
   @override

packages/flutter/lib/src/widgets/scrollable.dart

@@ -285,6 +285,8 @@ class ScrollableState<T extends Scrollable> extends State<T> {
       case ViewportAnchor.end:
         return pixelOffset;
     }
+    assert(config.scrollAnchor != null);
+    return null;
   }
 
   /// Convert a scrollOffset value to the number of pixels to which it corresponds.

packages/flutter/lib/src/widgets/scrollable_list.dart

@@ -239,6 +239,8 @@ class _VirtualListViewport extends VirtualViewport {
         }
         break;
     }
+    assert(mainAxis != null);
+    return null;
   }
 
   @override

packages/flutter/lib/src/widgets/text_selection.dart

@@ -294,5 +294,7 @@ class _TextSelectionHandleOverlayState extends State<_TextSelectionHandleOverlay
       case TextDirection.rtl:
         return rtlType;
     }
+    assert(endpoint.direction != null);
+    return null;
   }
 }

packages/flutter/lib/src/widgets/virtual_viewport.dart

@@ -70,6 +70,8 @@ abstract class VirtualViewportElement extends RenderObjectElement {
       case ViewportAnchor.end:
         return scrollOffset;
     }
+    assert(renderObject.anchor != null);
+    return null;
   }
 
   /// Returns a two-dimensional representation of the scroll offset, accounting

packages/flutter/test/widget/render_object_widget_test.dart

@@ -23,12 +23,15 @@ class TestOrientedBox extends SingleChildRenderObjectWidget {
   TestOrientedBox({ Key key, Widget child }) : super(key: key, child: child);
 
   Decoration _getDecoration(BuildContext context) {
-    switch (MediaQuery.of(context).orientation) {
+    Orientation orientation = MediaQuery.of(context).orientation;
+    switch (orientation) {
       case Orientation.landscape:
         return new BoxDecoration(backgroundColor: const Color(0xFF00FF00));
       case Orientation.portrait:
         return new BoxDecoration(backgroundColor: const Color(0xFF0000FF));
     }
+    assert(orientation != null);
+    return null;
   }
 
   @override

packages/flutter_tools/lib/src/application_package.dart

@@ -134,6 +134,8 @@ ApplicationPackage getApplicationPackageForPlatform(TargetPlatform platform) {
     case TargetPlatform.linux_x64:
       return null;
   }
+  assert(platform != null);
+  return null;
 }
 
 class ApplicationPackageStore {
@@ -156,5 +158,6 @@ class ApplicationPackageStore {
       case TargetPlatform.linux_x64:
         return null;
     }
+    return null;
   }
 }

packages/flutter_tools/lib/src/build_info.dart

@@ -53,6 +53,7 @@ String getNameForHostPlatform(HostPlatform platform) {
       return 'linux-x64';
   }
   assert(false);
+  return null;
 }
 
 enum TargetPlatform {
@@ -80,6 +81,7 @@ String getNameForTargetPlatform(TargetPlatform platform) {
       return 'linux-x64';
   }
   assert(false);
+  return null;
 }
 
 TargetPlatform getTargetPlatformForName(String platform) {
@@ -97,6 +99,7 @@ TargetPlatform getTargetPlatformForName(String platform) {
     case 'linux-x64':
       return TargetPlatform.linux_x64;
   }
+  assert(platform != null);
   return null;
 }
 

packages/flutter_tools/lib/src/ios/devices.dart

@@ -349,7 +349,6 @@ class IOSDevice extends Device {
     } else {
       return false;
     }
-    return false;
   }
 
   @override