Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
0d7e90d5
Commit
0d7e90d5
authored
Sep 01, 2015
by
Ian Fischer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Make it possible to download trace files on rooted devices using sky_tool stop_trace
parent
99356d10
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
10 additions
and
0 deletions
+10
-0
sky_tool
packages/flutter/lib/sky_tool
+10
-0
No files found.
packages/flutter/lib/sky_tool
View file @
0d7e90d5
...
...
@@ -952,6 +952,16 @@ class StopTracing(object):
logging
.
info
(
'Downloading trace
%
s ...'
%
os
.
path
.
basename
(
device_path
))
if
device_path
:
cmd
=
[
ADB_PATH
,
'root'
]
logging
.
info
(
' '
.
join
(
cmd
))
output
=
subprocess
.
check_output
(
cmd
)
match
=
re
.
match
(
r'.*cannot run as root.*'
,
output
if
match
is
not
None
:
logging
.
error
(
'Unable to download trace file
%
s
\n
'
'You need to be able to run adb as root '
'on your android device'
%
device_path
)
return
2
cmd
=
[
ADB_PATH
,
'pull'
,
device_path
]
logging
.
info
(
' '
.
join
(
cmd
))
subprocess
.
check_output
(
cmd
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment