Unverified Commit 0c57b312 authored by Sam Rawlins's avatar Sam Rawlins Committed by GitHub

Ignore body_might_complete_normally_catch_error violations (#106563)

parent 6048e07f
...@@ -623,6 +623,9 @@ class HotRunner extends ResidentRunner { ...@@ -623,6 +623,9 @@ class HotRunner extends ResidentRunner {
continue; continue;
} }
operations.add(device.vmService!.service.kill(isolateRef.id!) operations.add(device.vmService!.service.kill(isolateRef.id!)
// TODO(srawlins): Fix this static issue,
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
.catchError((dynamic error, StackTrace stackTrace) { .catchError((dynamic error, StackTrace stackTrace) {
// Do nothing on a SentinelException since it means the isolate // Do nothing on a SentinelException since it means the isolate
// has already been killed. // has already been killed.
......
...@@ -683,7 +683,11 @@ class BrowserManager { ...@@ -683,7 +683,11 @@ class BrowserManager {
unawaited(chrome.onExit.then((int? browserExitCode) { unawaited(chrome.onExit.then((int? browserExitCode) {
throwToolExit('${runtime.name} exited with code $browserExitCode before connecting.'); throwToolExit('${runtime.name} exited with code $browserExitCode before connecting.');
}).catchError((Object error, StackTrace stackTrace) { })
// TODO(srawlins): Fix this static issue,
// https://github.com/flutter/flutter/issues/105750.
// ignore: body_might_complete_normally_catch_error
.catchError((Object error, StackTrace stackTrace) {
if (!completer.isCompleted) { if (!completer.isCompleted) {
completer.completeError(error, stackTrace); completer.completeError(error, stackTrace);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment