Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
0adf9671
Unverified
Commit
0adf9671
authored
Mar 18, 2022
by
Christopher Fujino
Committed by
GitHub
Mar 18, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_conductor] clone from remote upstream, and not local filesystem (#100335)
parent
a217bbb6
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
13 deletions
+12
-13
codesign.dart
dev/conductor/core/lib/src/codesign.dart
+2
-3
codesign_test.dart
dev/conductor/core/test/codesign_test.dart
+10
-10
No files found.
dev/conductor/core/lib/src/codesign.dart
View file @
0adf9671
...
...
@@ -73,9 +73,8 @@ class CodesignCommand extends Command<void> {
FrameworkRepository
?
_framework
;
FrameworkRepository
get
framework
{
return
_framework
??=
FrameworkRepository
.
localRepoAsUpstream
(
return
_framework
??=
FrameworkRepository
(
checkouts
,
upstreamPath:
flutterRoot
.
path
,
);
}
...
...
@@ -113,7 +112,7 @@ class CodesignCommand extends Command<void> {
}
else
{
revision
=
((
await
processManager
.
run
(
<
String
>[
'git'
,
'rev-parse'
,
'HEAD'
],
workingDirectory:
(
await
framework
.
checkoutDirectory
)
.
path
,
workingDirectory:
flutterRoot
.
path
,
)).
stdout
as
String
).
trim
();
assert
(
revision
.
isNotEmpty
);
}
...
...
dev/conductor/core/test/codesign_test.dart
View file @
0adf9671
...
...
@@ -103,13 +103,18 @@ void main() {
);
}
createRunner
(
commands:
<
FakeCommand
>[
const
FakeCommand
(
command:
<
String
>[
'git'
,
'rev-parse'
,
'HEAD'
,
],
stdout:
revision
),
const
FakeCommand
(
command:
<
String
>[
'git'
,
'clone'
,
'--origin'
,
'upstream'
,
'--'
,
'file://
$flutterRoot
/'
,
FrameworkRepository
.
defaultUpstream
,
'
${checkoutsParentDirectory}
flutter_conductor_checkouts/framework'
,
]),
const
FakeCommand
(
command:
<
String
>[
...
...
@@ -122,11 +127,6 @@ void main() {
'rev-parse'
,
'HEAD'
,
],
stdout:
revision
),
const
FakeCommand
(
command:
<
String
>[
'git'
,
'rev-parse'
,
'HEAD'
,
],
stdout:
revision
),
const
FakeCommand
(
command:
<
String
>[
'git'
,
'checkout'
,
...
...
@@ -198,7 +198,7 @@ void main() {
'--origin'
,
'upstream'
,
'--'
,
'file://
$flutterRoot
/'
,
FrameworkRepository
.
defaultUpstream
,
'
${checkoutsParentDirectory}
flutter_conductor_checkouts/framework'
,
]),
const
FakeCommand
(
command:
<
String
>[
...
...
@@ -291,7 +291,7 @@ void main() {
'--origin'
,
'upstream'
,
'--'
,
'file://
$flutterRoot
/'
,
FrameworkRepository
.
defaultUpstream
,
'
${checkoutsParentDirectory}
flutter_conductor_checkouts/framework'
,
]),
const
FakeCommand
(
command:
<
String
>[
...
...
@@ -383,7 +383,7 @@ void main() {
'--origin'
,
'upstream'
,
'--'
,
'file://
$flutterRoot
/'
,
FrameworkRepository
.
defaultUpstream
,
'
${checkoutsParentDirectory}
flutter_conductor_checkouts/framework'
,
]),
const
FakeCommand
(
command:
<
String
>[
...
...
@@ -447,7 +447,7 @@ void main() {
'--origin'
,
'upstream'
,
'--'
,
'file://
$flutterRoot
/'
,
FrameworkRepository
.
defaultUpstream
,
'
${checkoutsParentDirectory}
flutter_conductor_checkouts/framework'
,
]),
const
FakeCommand
(
command:
<
String
>[
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment