Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
0a2175f1
Unverified
Commit
0a2175f1
authored
Mar 27, 2019
by
Jonah Williams
Committed by
GitHub
Mar 27, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Pass FLUTTER_TOOL_ARGS to snapshot command. (#29938)
parent
76b9962f
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
14 additions
and
2 deletions
+14
-2
flutter
bin/flutter
+1
-1
flutter.bat
bin/flutter.bat
+5
-1
test.dart
dev/bots/test.dart
+8
-0
No files found.
bin/flutter
View file @
0a2175f1
...
@@ -121,7 +121,7 @@ function upgrade_flutter () {
...
@@ -121,7 +121,7 @@ function upgrade_flutter () {
retry_upgrade
retry_upgrade
"
$DART
"
--snapshot
=
"
$SNAPSHOT_PATH
"
--snapshot-kind
=
app-jit
--packages
=
"
$FLUTTER_TOOLS_DIR
/.packages"
"
$SCRIPT_PATH
"
training
"
$DART
"
$FLUTTER_TOOL_ARGS
--snapshot
=
"
$SNAPSHOT_PATH
"
--snapshot-kind
=
app-jit
--packages
=
"
$FLUTTER_TOOLS_DIR
/.packages"
"
$SCRIPT_PATH
"
training
echo
"
$revision
"
>
"
$STAMP_PATH
"
echo
"
$revision
"
>
"
$STAMP_PATH
"
fi
fi
# The exit here is duplicitous since the function is run in a subshell,
# The exit here is duplicitous since the function is run in a subshell,
...
...
bin/flutter.bat
View file @
0a2175f1
...
@@ -152,7 +152,11 @@ GOTO :after_subroutine
...
@@ -152,7 +152,11 @@ GOTO :after_subroutine
POPD
POPD
"%dart%" --snapshot="%snapshot_path%" --snapshot-kind=app-jit --packages="%flutter_tools_dir%\.packages" "%script_path%"
IF "%FLUTTER_TOOL_ARGS%" == "" (
"%dart%" --snapshot="%snapshot_path%" --snapshot-kind=app-jit --packages="%flutter_tools_dir%\.packages" "%script_path%"
) else (
"%dart%" "%FLUTTER_TOOL_ARGS%" --snapshot="%snapshot_path%" --snapshot-kind=app-jit --packages="%flutter_tools_dir%\.packages" "%script_path%"
)
IF "%ERRORLEVEL%" NEQ "0" (
IF "%ERRORLEVEL%" NEQ "0" (
ECHO Error: Unable to create dart snapshot for flutter tool.
ECHO Error: Unable to create dart snapshot for flutter tool.
SET exit_code=%ERRORLEVEL%
SET exit_code=%ERRORLEVEL%
...
...
dev/bots/test.dart
View file @
0a2175f1
...
@@ -180,16 +180,24 @@ Future<void> _runToolTests() async {
...
@@ -180,16 +180,24 @@ Future<void> _runToolTests() async {
final
bq
.
BigqueryApi
bigqueryApi
=
await
_getBigqueryApi
();
final
bq
.
BigqueryApi
bigqueryApi
=
await
_getBigqueryApi
();
await
_runSmokeTests
();
await
_runSmokeTests
();
// The flutter_tool will currently be snapshotted without asserts. We need
// to force it to be regenerated with them enabled.
if
(!
Platform
.
isWindows
)
{
File
(
path
.
join
(
flutterRoot
,
'bin'
,
'cache'
,
'flutter_tools.snapshot'
)).
deleteSync
();
File
(
path
.
join
(
flutterRoot
,
'bin'
,
'cache'
,
'flutter_tools.stamp'
)).
deleteSync
();
}
if
(
noUseBuildRunner
)
{
if
(
noUseBuildRunner
)
{
await
_pubRunTest
(
await
_pubRunTest
(
path
.
join
(
flutterRoot
,
'packages'
,
'flutter_tools'
),
path
.
join
(
flutterRoot
,
'packages'
,
'flutter_tools'
),
tableData:
bigqueryApi
?.
tabledata
,
tableData:
bigqueryApi
?.
tabledata
,
enableFlutterToolAsserts:
!
Platform
.
isWindows
,
);
);
}
else
{
}
else
{
await
_buildRunnerTest
(
await
_buildRunnerTest
(
path
.
join
(
flutterRoot
,
'packages'
,
'flutter_tools'
),
path
.
join
(
flutterRoot
,
'packages'
,
'flutter_tools'
),
flutterRoot
,
flutterRoot
,
tableData:
bigqueryApi
?.
tabledata
,
tableData:
bigqueryApi
?.
tabledata
,
enableFlutterToolAsserts:
!
Platform
.
isWindows
,
);
);
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment