Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
099ae9b4
Unverified
Commit
099ae9b4
authored
Oct 22, 2020
by
Alexander Brusher
Committed by
GitHub
Oct 22, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Re-enables tests previously failing due to new semantics flag. (#66916)
parent
22c502e3
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
9 additions
and
4 deletions
+9
-4
custom_paint.dart
packages/flutter/lib/src/rendering/custom_paint.dart
+3
-0
custom_painter_test.dart
packages/flutter/test/widgets/custom_painter_test.dart
+1
-1
semantics_test.dart
packages/flutter/test/widgets/semantics_test.dart
+1
-1
matchers.dart
packages/flutter_test/lib/src/matchers.dart
+2
-1
matchers_test.dart
packages/flutter_test/test/matchers_test.dart
+2
-1
No files found.
packages/flutter/lib/src/rendering/custom_paint.dart
View file @
099ae9b4
...
...
@@ -838,6 +838,9 @@ class RenderCustomPaint extends RenderProxyBox {
if
(
properties
.
textField
!=
null
)
{
config
.
isTextField
=
properties
.
textField
!;
}
if
(
properties
.
slider
!=
null
)
{
config
.
isSlider
=
properties
.
slider
!;
}
if
(
properties
.
readOnly
!=
null
)
{
config
.
isReadOnly
=
properties
.
readOnly
!;
}
...
...
packages/flutter/test/widgets/custom_painter_test.dart
View file @
099ae9b4
...
...
@@ -501,7 +501,7 @@ void _defineTests() {
);
expect
(
semantics
,
hasSemantics
(
expectedSemantics
,
ignoreRect:
true
,
ignoreTransform:
true
));
semantics
.
dispose
();
}
,
skip:
true
);
// TODO(abrusher): Enable once engine PR #20385 lands.
}
);
group
(
'diffing'
,
()
{
testWidgets
(
'complains about duplicate keys'
,
(
WidgetTester
tester
)
async
{
...
...
packages/flutter/test/widgets/semantics_test.dart
View file @
099ae9b4
...
...
@@ -541,7 +541,7 @@ void main() {
expect
(
semantics
,
hasSemantics
(
expectedSemantics
,
ignoreId:
true
));
semantics
.
dispose
();
}
,
skip:
true
);
// TODO(abrusher): Enable once engine PR #20385 lands.
}
);
testWidgets
(
'Actions can be replaced without triggering semantics update'
,
(
WidgetTester
tester
)
async
{
final
SemanticsTester
semantics
=
SemanticsTester
(
tester
);
...
...
packages/flutter_test/lib/src/matchers.dart
View file @
099ae9b4
...
...
@@ -449,6 +449,7 @@ Matcher matchesSemantics({
bool
isChecked
=
false
,
bool
isSelected
=
false
,
bool
isButton
=
false
,
bool
isSlider
=
false
,
bool
isLink
=
false
,
bool
isFocused
=
false
,
bool
isFocusable
=
false
,
...
...
@@ -468,7 +469,6 @@ Matcher matchesSemantics({
bool
hasToggledState
=
false
,
bool
isToggled
=
false
,
bool
hasImplicitScrolling
=
false
,
bool
isSlider
=
false
,
// Actions //
bool
hasTapAction
=
false
,
bool
hasLongPressAction
=
false
,
...
...
@@ -501,6 +501,7 @@ Matcher matchesSemantics({
if
(
isChecked
)
SemanticsFlag
.
isChecked
,
if
(
isSelected
)
SemanticsFlag
.
isSelected
,
if
(
isButton
)
SemanticsFlag
.
isButton
,
if
(
isSlider
)
SemanticsFlag
.
isSlider
,
if
(
isLink
)
SemanticsFlag
.
isLink
,
if
(
isTextField
)
SemanticsFlag
.
isTextField
,
if
(
isReadOnly
)
SemanticsFlag
.
isReadOnly
,
...
...
packages/flutter_test/test/matchers_test.dart
View file @
099ae9b4
...
...
@@ -573,6 +573,7 @@ void main() {
isChecked:
true
,
isSelected:
true
,
isButton:
true
,
isSlider:
true
,
isLink:
true
,
isTextField:
true
,
isReadOnly:
true
,
...
...
@@ -616,7 +617,7 @@ void main() {
hasDismissAction:
true
,
customActions:
<
CustomSemanticsAction
>[
action
],
));
}
,
skip:
true
);
// TODO(abrusher): Enable once engine PR #20385 lands.
}
);
testWidgets
(
'Can match child semantics'
,
(
WidgetTester
tester
)
async
{
final
SemanticsHandle
handle
=
tester
.
ensureSemantics
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment