Unverified Commit 099ae9b4 authored by Alexander Brusher's avatar Alexander Brusher Committed by GitHub

Re-enables tests previously failing due to new semantics flag. (#66916)

parent 22c502e3
...@@ -838,6 +838,9 @@ class RenderCustomPaint extends RenderProxyBox { ...@@ -838,6 +838,9 @@ class RenderCustomPaint extends RenderProxyBox {
if (properties.textField != null) { if (properties.textField != null) {
config.isTextField = properties.textField!; config.isTextField = properties.textField!;
} }
if (properties.slider != null) {
config.isSlider = properties.slider!;
}
if (properties.readOnly != null) { if (properties.readOnly != null) {
config.isReadOnly = properties.readOnly!; config.isReadOnly = properties.readOnly!;
} }
......
...@@ -501,7 +501,7 @@ void _defineTests() { ...@@ -501,7 +501,7 @@ void _defineTests() {
); );
expect(semantics, hasSemantics(expectedSemantics, ignoreRect: true, ignoreTransform: true)); expect(semantics, hasSemantics(expectedSemantics, ignoreRect: true, ignoreTransform: true));
semantics.dispose(); semantics.dispose();
}, skip: true); // TODO(abrusher): Enable once engine PR #20385 lands. });
group('diffing', () { group('diffing', () {
testWidgets('complains about duplicate keys', (WidgetTester tester) async { testWidgets('complains about duplicate keys', (WidgetTester tester) async {
......
...@@ -541,7 +541,7 @@ void main() { ...@@ -541,7 +541,7 @@ void main() {
expect(semantics, hasSemantics(expectedSemantics, ignoreId: true)); expect(semantics, hasSemantics(expectedSemantics, ignoreId: true));
semantics.dispose(); semantics.dispose();
}, skip: true); // TODO(abrusher): Enable once engine PR #20385 lands. });
testWidgets('Actions can be replaced without triggering semantics update', (WidgetTester tester) async { testWidgets('Actions can be replaced without triggering semantics update', (WidgetTester tester) async {
final SemanticsTester semantics = SemanticsTester(tester); final SemanticsTester semantics = SemanticsTester(tester);
......
...@@ -449,6 +449,7 @@ Matcher matchesSemantics({ ...@@ -449,6 +449,7 @@ Matcher matchesSemantics({
bool isChecked = false, bool isChecked = false,
bool isSelected = false, bool isSelected = false,
bool isButton = false, bool isButton = false,
bool isSlider = false,
bool isLink = false, bool isLink = false,
bool isFocused = false, bool isFocused = false,
bool isFocusable = false, bool isFocusable = false,
...@@ -468,7 +469,6 @@ Matcher matchesSemantics({ ...@@ -468,7 +469,6 @@ Matcher matchesSemantics({
bool hasToggledState = false, bool hasToggledState = false,
bool isToggled = false, bool isToggled = false,
bool hasImplicitScrolling = false, bool hasImplicitScrolling = false,
bool isSlider = false,
// Actions // // Actions //
bool hasTapAction = false, bool hasTapAction = false,
bool hasLongPressAction = false, bool hasLongPressAction = false,
...@@ -501,6 +501,7 @@ Matcher matchesSemantics({ ...@@ -501,6 +501,7 @@ Matcher matchesSemantics({
if (isChecked) SemanticsFlag.isChecked, if (isChecked) SemanticsFlag.isChecked,
if (isSelected) SemanticsFlag.isSelected, if (isSelected) SemanticsFlag.isSelected,
if (isButton) SemanticsFlag.isButton, if (isButton) SemanticsFlag.isButton,
if (isSlider) SemanticsFlag.isSlider,
if (isLink) SemanticsFlag.isLink, if (isLink) SemanticsFlag.isLink,
if (isTextField) SemanticsFlag.isTextField, if (isTextField) SemanticsFlag.isTextField,
if (isReadOnly) SemanticsFlag.isReadOnly, if (isReadOnly) SemanticsFlag.isReadOnly,
......
...@@ -573,6 +573,7 @@ void main() { ...@@ -573,6 +573,7 @@ void main() {
isChecked: true, isChecked: true,
isSelected: true, isSelected: true,
isButton: true, isButton: true,
isSlider: true,
isLink: true, isLink: true,
isTextField: true, isTextField: true,
isReadOnly: true, isReadOnly: true,
...@@ -616,7 +617,7 @@ void main() { ...@@ -616,7 +617,7 @@ void main() {
hasDismissAction: true, hasDismissAction: true,
customActions: <CustomSemanticsAction>[action], customActions: <CustomSemanticsAction>[action],
)); ));
}, skip: true); // TODO(abrusher): Enable once engine PR #20385 lands. });
testWidgets('Can match child semantics', (WidgetTester tester) async { testWidgets('Can match child semantics', (WidgetTester tester) async {
final SemanticsHandle handle = tester.ensureSemantics(); final SemanticsHandle handle = tester.ensureSemantics();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment