Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
08768e87
Unverified
Commit
08768e87
authored
Mar 17, 2020
by
Dan Field
Committed by
GitHub
Mar 17, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert repeater (#52752)
Reverts repeat filter logic for text formatter
parent
d1b99f43
Changes
2
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
318 deletions
+14
-318
editable_text.dart
packages/flutter/lib/src/widgets/editable_text.dart
+6
-23
editable_text_test.dart
packages/flutter/test/widgets/editable_text_test.dart
+8
-295
No files found.
packages/flutter/lib/src/widgets/editable_text.dart
View file @
08768e87
...
...
@@ -1230,9 +1230,6 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
// _lastFormattedUnmodifiedTextEditingValue tracks the last value
// that the formatter ran on and is used to prevent double-formatting.
TextEditingValue
_lastFormattedUnmodifiedTextEditingValue
;
// _lastFormattedValue tracks the last post-format value, so that it can be
// reused without rerunning the formatter when the input value is repeated.
TextEditingValue
_lastFormattedValue
;
// _receivedRemoteTextEditingValue is the direct value last passed in
// updateEditingValue. This value does not get updated with the formatted
// version.
...
...
@@ -1663,29 +1660,15 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
// Check if the new value is the same as the current local value, or is the same
// as the post-formatting value of the previous pass.
final
bool
textChanged
=
_value
?.
text
!=
value
?.
text
;
final
bool
isRepeatText
=
value
?.
text
==
_lastFormattedUnmodifiedTextEditingValue
?.
text
;
final
bool
isRepeatSelection
=
value
?.
selection
==
_lastFormattedUnmodifiedTextEditingValue
?.
selection
;
// Only format when the text has changed and there are available formatters.
if
(!
isRepeatText
&&
textChanged
&&
widget
.
inputFormatters
!=
null
&&
widget
.
inputFormatters
.
isNotEmpty
)
{
for
(
final
TextInputFormatter
formatter
in
widget
.
inputFormatters
)
{
final
bool
isRepeat
=
value
?.
text
==
_lastFormattedUnmodifiedTextEditingValue
?.
text
;
if
(
textChanged
&&
!
isRepeat
&&
widget
.
inputFormatters
!=
null
&&
widget
.
inputFormatters
.
isNotEmpty
)
{
for
(
final
TextInputFormatter
formatter
in
widget
.
inputFormatters
)
value
=
formatter
.
formatEditUpdate
(
_value
,
value
);
}
// Always pass the text through the whitespace directionality formatter to
// maintain expected behavior with carets on trailing whitespace.
value
=
_whitespaceFormatter
.
formatEditUpdate
(
_value
,
value
);
_lastFormattedValue
=
value
;
}
// If the text has changed or the selection has changed, we should update the
// locally stored TextEditingValue to the new one.
if
(!
isRepeatText
||
!
isRepeatSelection
)
{
_value
=
value
;
}
else
if
(
textChanged
&&
_lastFormattedValue
!=
null
)
{
_value
=
_lastFormattedValue
;
_updateRemoteEditingValueIfNeeded
();
}
else
{
_value
=
value
;
}
// Always attempt to send the value. If the value has changed, then it will send,
// otherwise, it will short-circuit.
_updateRemoteEditingValueIfNeeded
();
if
(
textChanged
&&
widget
.
onChanged
!=
null
)
widget
.
onChanged
(
value
.
text
);
_lastFormattedUnmodifiedTextEditingValue
=
_receivedRemoteTextEditingValue
;
...
...
packages/flutter/test/widgets/editable_text_test.dart
View file @
08768e87
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment