Revert "Remove TODOs added for HTTP abort() change in dart sdk (#63924)" (#63972)

This reverts commit b1c17313.

Revert "Remove TODOs added for HTTP abort() change in dart sdk (#63924)" (#63972)
This reverts commit b1c17313.
08254b21 · Jonah Williams · GitHub · b1c17313 · 08254b21 · 08254b21
Unverified Commit 08254b21 authored Aug 17, 2020 by Jonah Williams Committed by GitHub Aug 17, 2020
Hide whitespace changes
Inline Side-by-side

Showing with 4 additions and 0 deletions

_binding_io.dart packages/flutter_test/lib/src/_binding_io.dart +2 -0

testbed.dart packages/flutter_tools/test/src/testbed.dart +2 -0

No files found.
--- a/packages/flutter_test/lib/src/_binding_io.dart
+++ b/packages/flutter_test/lib/src/_binding_io.dart
@@ -228,7 +228,9 @@ class _MockHttpRequest extends HttpClientRequest {
    return Future<HttpClientResponse>.value(_MockHttpResponse());
  }

+  // TODO(zichangguo): remove the ignore after the change in dart:io lands.
  @override
+  // ignore: override_on_non_overriding_member
  void abort([Object exception, StackTrace stackTrace]) {}

  @override

--- a/packages/flutter_tools/test/src/testbed.dart
+++ b/packages/flutter_tools/test/src/testbed.dart
@@ -378,7 +378,9 @@ class FakeHttpClientRequest implements HttpClientRequest {
  @override
  void writeln([Object obj = '']) {}

+  // TODO(zichangguo): remove the ignore after the change in dart:io lands.
  @override
+  // ignore: override_on_non_overriding_member
  void abort([Object exception, StackTrace stackTrace]) {}
 }