Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
0736fac4
Commit
0736fac4
authored
Feb 17, 2017
by
Ian Hickson
Committed by
GitHub
Feb 17, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
DrivenScrollActivity._end didn't handle being already disposed (#8219)
parent
1bd7dbc2
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
1 deletion
+18
-1
scroll_position.dart
packages/flutter/lib/src/widgets/scroll_position.dart
+1
-1
scroll_controller_test.dart
packages/flutter/test/widgets/scroll_controller_test.dart
+17
-0
No files found.
packages/flutter/lib/src/widgets/scroll_position.dart
View file @
0736fac4
...
...
@@ -750,7 +750,7 @@ class DrivenScrollActivity extends ScrollActivity {
}
void
_end
()
{
position
.
beginBallisticActivity
(
velocity
);
position
?
.
beginBallisticActivity
(
velocity
);
}
@override
...
...
packages/flutter/test/widgets/scroll_controller_test.dart
View file @
0736fac4
...
...
@@ -143,4 +143,21 @@ void main() {
expect
(
controller
.
offset
,
equals
(
105.0
));
expect
(
realOffset
(),
equals
(
controller
.
offset
));
});
testWidgets
(
'DrivenScrollActivity ending after dispose'
,
(
WidgetTester
tester
)
async
{
ScrollController
controller
=
new
ScrollController
();
await
tester
.
pumpWidget
(
new
ListView
(
controller:
controller
,
children:
<
Widget
>[
new
Container
(
height:
200000.0
)
],
));
controller
.
animateTo
(
1000.0
,
duration:
const
Duration
(
seconds:
1
),
curve:
Curves
.
linear
);
await
tester
.
pump
();
// Start the animation.
// We will now change the tree on the same frame as the animation ends.
await
tester
.
pumpWidget
(
new
Container
(),
const
Duration
(
seconds:
2
));
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment