Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
07161e82
Unverified
Commit
07161e82
authored
Jan 08, 2020
by
Zachary Anderson
Committed by
GitHub
Jan 08, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tool] Don't use context in ProcessUtils (#48444)
parent
4e6d649f
Changes
6
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
227 additions
and
154 deletions
+227
-154
runner.dart
packages/flutter_tools/lib/runner.dart
+1
-1
gradle.dart
packages/flutter_tools/lib/src/android/gradle.dart
+1
-1
application_package.dart
packages/flutter_tools/lib/src/application_package.dart
+1
-1
process.dart
packages/flutter_tools/lib/src/base/process.dart
+115
-64
context_runner.dart
packages/flutter_tools/lib/src/context_runner.dart
+5
-1
process_test.dart
...s/flutter_tools/test/general.shard/base/process_test.dart
+104
-86
No files found.
packages/flutter_tools/lib/runner.dart
View file @
07161e82
...
@@ -255,7 +255,7 @@ Future<int> _exit(int code) async {
...
@@ -255,7 +255,7 @@ Future<int> _exit(int code) async {
}
}
// Run shutdown hooks before flushing logs
// Run shutdown hooks before flushing logs
await
runShutdownHooks
();
await
shutdownHooks
.
runShutdownHooks
();
final
Completer
<
void
>
completer
=
Completer
<
void
>();
final
Completer
<
void
>
completer
=
Completer
<
void
>();
...
...
packages/flutter_tools/lib/src/android/gradle.dart
View file @
07161e82
...
@@ -907,7 +907,7 @@ Directory _getLocalEngineRepo({
...
@@ -907,7 +907,7 @@ Directory _getLocalEngineRepo({
.
createTempSync
(
'flutter_tool_local_engine_repo.'
);
.
createTempSync
(
'flutter_tool_local_engine_repo.'
);
// Remove the local engine repo before the tool exits.
// Remove the local engine repo before the tool exits.
addShutdownHook
(
shutdownHooks
.
addShutdownHook
(
()
=>
localEngineRepo
.
deleteSync
(
recursive:
true
),
()
=>
localEngineRepo
.
deleteSync
(
recursive:
true
),
ShutdownStage
.
CLEANUP
,
ShutdownStage
.
CLEANUP
,
);
);
...
...
packages/flutter_tools/lib/src/application_package.dart
View file @
07161e82
...
@@ -288,7 +288,7 @@ abstract class IOSApp extends ApplicationPackage {
...
@@ -288,7 +288,7 @@ abstract class IOSApp extends ApplicationPackage {
}
else
{
}
else
{
// Try to unpack as an ipa.
// Try to unpack as an ipa.
final
Directory
tempDir
=
globals
.
fs
.
systemTempDirectory
.
createTempSync
(
'flutter_app.'
);
final
Directory
tempDir
=
globals
.
fs
.
systemTempDirectory
.
createTempSync
(
'flutter_app.'
);
addShutdownHook
(()
async
{
shutdownHooks
.
addShutdownHook
(()
async
{
await
tempDir
.
delete
(
recursive:
true
);
await
tempDir
.
delete
(
recursive:
true
);
},
ShutdownStage
.
STILL_RECORDING
);
},
ShutdownStage
.
STILL_RECORDING
);
os
.
unzip
(
globals
.
fs
.
file
(
applicationBinary
),
tempDir
);
os
.
unzip
(
globals
.
fs
.
file
(
applicationBinary
),
tempDir
);
...
...
packages/flutter_tools/lib/src/base/process.dart
View file @
07161e82
This diff is collapsed.
Click to expand it.
packages/flutter_tools/lib/src/context_runner.dart
View file @
07161e82
...
@@ -120,8 +120,12 @@ Future<T> runInContext<T>(
...
@@ -120,8 +120,12 @@ Future<T> runInContext<T>(
OperatingSystemUtils:
()
=>
OperatingSystemUtils
(),
OperatingSystemUtils:
()
=>
OperatingSystemUtils
(),
PersistentToolState:
()
=>
PersistentToolState
(),
PersistentToolState:
()
=>
PersistentToolState
(),
ProcessInfo:
()
=>
ProcessInfo
(),
ProcessInfo:
()
=>
ProcessInfo
(),
ProcessUtils:
()
=>
ProcessUtils
(),
ProcessUtils:
()
=>
ProcessUtils
(
processManager:
globals
.
processManager
,
logger:
globals
.
logger
,
),
Pub:
()
=>
const
Pub
(),
Pub:
()
=>
const
Pub
(),
ShutdownHooks:
()
=>
ShutdownHooks
(
logger:
globals
.
logger
),
Signals:
()
=>
Signals
(),
Signals:
()
=>
Signals
(),
SimControl:
()
=>
SimControl
(),
SimControl:
()
=>
SimControl
(),
Stdio:
()
=>
const
Stdio
(),
Stdio:
()
=>
const
Stdio
(),
...
...
packages/flutter_tools/test/general.shard/base/process_test.dart
View file @
07161e82
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment