Unverified Commit 05ce6ce5 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

[flutter_tools] remove mock from android studio test (#77158)

parent 67b2ca89
...@@ -11,7 +11,7 @@ import 'package:flutter_tools/src/base/platform.dart'; ...@@ -11,7 +11,7 @@ import 'package:flutter_tools/src/base/platform.dart';
import 'package:flutter_tools/src/base/version.dart'; import 'package:flutter_tools/src/base/version.dart';
import 'package:flutter_tools/src/globals.dart' as globals; import 'package:flutter_tools/src/globals.dart' as globals;
import 'package:flutter_tools/src/ios/plist_parser.dart'; import 'package:flutter_tools/src/ios/plist_parser.dart';
import 'package:mockito/mockito.dart'; import 'package:test/fake.dart';
import '../../src/common.dart'; import '../../src/common.dart';
import '../../src/context.dart'; import '../../src/context.dart';
...@@ -56,8 +56,6 @@ final Platform windowsPlatform = FakePlatform( ...@@ -56,8 +56,6 @@ final Platform windowsPlatform = FakePlatform(
} }
); );
class MockPlistUtils extends Mock implements PlistParser {}
Platform macPlatform() { Platform macPlatform() {
return FakePlatform( return FakePlatform(
operatingSystem: 'macos', operatingSystem: 'macos',
...@@ -100,10 +98,10 @@ void main() { ...@@ -100,10 +98,10 @@ void main() {
group('pluginsPath on Mac', () { group('pluginsPath on Mac', () {
FileSystemUtils fsUtils; FileSystemUtils fsUtils;
Platform platform; Platform platform;
MockPlistUtils plistUtils; FakePlistUtils plistUtils;
setUp(() { setUp(() {
plistUtils = MockPlistUtils(); plistUtils = FakePlistUtils();
platform = macPlatform(); platform = macPlatform();
fsUtils = FileSystemUtils( fsUtils = FileSystemUtils(
fileSystem: fileSystem, fileSystem: fileSystem,
...@@ -121,7 +119,7 @@ void main() { ...@@ -121,7 +119,7 @@ void main() {
globals.fs.directory(studioInApplicationPlistFolder).createSync(recursive: true); globals.fs.directory(studioInApplicationPlistFolder).createSync(recursive: true);
final String plistFilePath = globals.fs.path.join(studioInApplicationPlistFolder, 'Info.plist'); final String plistFilePath = globals.fs.path.join(studioInApplicationPlistFolder, 'Info.plist');
when(plistUtils.parseFile(plistFilePath)).thenReturn(macStudioInfoPlist4_1); plistUtils.fileContents[plistFilePath] = macStudioInfoPlist4_1;
final AndroidStudio studio = AndroidStudio.fromMacOSBundle( final AndroidStudio studio = AndroidStudio.fromMacOSBundle(
globals.fs.directory(studioInApplicationPlistFolder)?.parent?.path, globals.fs.directory(studioInApplicationPlistFolder)?.parent?.path,
); );
...@@ -154,7 +152,7 @@ void main() { ...@@ -154,7 +152,7 @@ void main() {
globals.fs.directory(studioInApplicationPlistFolder).createSync(recursive: true); globals.fs.directory(studioInApplicationPlistFolder).createSync(recursive: true);
final String plistFilePath = globals.fs.path.join(studioInApplicationPlistFolder, 'Info.plist'); final String plistFilePath = globals.fs.path.join(studioInApplicationPlistFolder, 'Info.plist');
when(plistUtils.parseFile(plistFilePath)).thenReturn(macStudioInfoPlist); plistUtils.fileContents[plistFilePath] = macStudioInfoPlist;
final AndroidStudio studio = AndroidStudio.fromMacOSBundle( final AndroidStudio studio = AndroidStudio.fromMacOSBundle(
globals.fs.directory(studioInApplicationPlistFolder)?.parent?.path, globals.fs.directory(studioInApplicationPlistFolder)?.parent?.path,
); );
...@@ -186,7 +184,7 @@ void main() { ...@@ -186,7 +184,7 @@ void main() {
globals.fs.directory(studioInApplicationPlistFolder).createSync(recursive: true); globals.fs.directory(studioInApplicationPlistFolder).createSync(recursive: true);
final String plistFilePath = globals.fs.path.join(studioInApplicationPlistFolder, 'Info.plist'); final String plistFilePath = globals.fs.path.join(studioInApplicationPlistFolder, 'Info.plist');
when(plistUtils.parseFile(plistFilePath)).thenReturn(macStudioInfoPlist); plistUtils.fileContents[plistFilePath] = macStudioInfoPlist;
final AndroidStudio studio = AndroidStudio.fromMacOSBundle( final AndroidStudio studio = AndroidStudio.fromMacOSBundle(
globals.fs.directory(studioInApplicationPlistFolder)?.parent?.path, globals.fs.directory(studioInApplicationPlistFolder)?.parent?.path,
); );
...@@ -226,7 +224,7 @@ void main() { ...@@ -226,7 +224,7 @@ void main() {
jetbrainsStudioInApplicationPlistFolder, jetbrainsStudioInApplicationPlistFolder,
'Info.plist', 'Info.plist',
); );
when(plistUtils.parseFile(jetbrainsPlistFilePath)).thenReturn(jetbrainsInfoPlist); plistUtils.fileContents[jetbrainsPlistFilePath] = jetbrainsInfoPlist;
final String studioInApplicationPlistFolder = globals.fs.path.join( final String studioInApplicationPlistFolder = globals.fs.path.join(
globals.fs.path.join(homeMac,'Library','Application Support'), globals.fs.path.join(homeMac,'Library','Application Support'),
...@@ -243,7 +241,7 @@ void main() { ...@@ -243,7 +241,7 @@ void main() {
studioInApplicationPlistFolder, studioInApplicationPlistFolder,
'Info.plist', 'Info.plist',
); );
when(plistUtils.parseFile(studioPlistFilePath)).thenReturn(macStudioInfoPlist); plistUtils.fileContents[studioPlistFilePath] = macStudioInfoPlist;
final AndroidStudio studio = AndroidStudio.fromMacOSBundle( final AndroidStudio studio = AndroidStudio.fromMacOSBundle(
globals.fs.directory(jetbrainsStudioInApplicationPlistFolder)?.parent?.path, globals.fs.directory(jetbrainsStudioInApplicationPlistFolder)?.parent?.path,
...@@ -382,3 +380,12 @@ void main() { ...@@ -382,3 +380,12 @@ void main() {
}); });
}); });
} }
class FakePlistUtils extends Fake implements PlistParser {
final Map<String, Map<String, dynamic>> fileContents = <String, Map<String, dynamic>>{};
@override
Map<String, dynamic> parseFile(String plistFilePath) {
return fileContents[plistFilePath];
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment