Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
055268ea
Commit
055268ea
authored
Mar 29, 2016
by
Adam Barth
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #2965 from abarth/rm_analyze_regexp
Remove two `flutter analyze` regular expressions
parents
574b26c7
522030bd
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
18 additions
and
2 deletions
+18
-2
object.dart
packages/flutter/lib/src/rendering/object.dart
+6
-0
viewport.dart
packages/flutter/lib/src/rendering/viewport.dart
+12
-0
analyze.dart
packages/flutter_tools/lib/src/commands/analyze.dart
+0
-2
No files found.
packages/flutter/lib/src/rendering/object.dart
View file @
055268ea
...
...
@@ -942,6 +942,12 @@ abstract class RenderObject extends AbstractNode implements HitTestTarget {
@override
PipelineOwner
get
owner
=>
super
.
owner
;
// Workaround for https://github.com/dart-lang/sdk/issues/25232
@override
void
attach
(
PipelineOwner
owner
)
{
super
.
attach
(
owner
);
}
bool
_needsLayout
=
true
;
/// Whether this render object's layout information is dirty.
bool
get
needsLayout
=>
_needsLayout
;
...
...
packages/flutter/lib/src/rendering/viewport.dart
View file @
055268ea
...
...
@@ -336,6 +336,12 @@ class RenderViewport extends RenderViewportBase with RenderObjectWithChildMixin<
return
null
;
}
// Workaround for https://github.com/dart-lang/sdk/issues/25232
@override
void
applyPaintTransform
(
RenderBox
child
,
Matrix4
transform
)
{
super
.
applyPaintTransform
(
child
,
transform
);
}
@override
bool
hitTestChildren
(
HitTestResult
result
,
{
Point
position
})
{
if
(
child
!=
null
)
{
...
...
@@ -401,6 +407,12 @@ abstract class RenderVirtualViewport<T extends ContainerBoxParentDataMixin<Rende
@override
Rect
describeApproximatePaintClip
(
RenderObject
child
)
=>
Point
.
origin
&
size
;
// Workaround for https://github.com/dart-lang/sdk/issues/25232
@override
void
applyPaintTransform
(
RenderBox
child
,
Matrix4
transform
)
{
super
.
applyPaintTransform
(
child
,
transform
);
}
@override
void
debugFillDescription
(
List
<
String
>
description
)
{
super
.
debugFillDescription
(
description
);
...
...
packages/flutter_tools/lib/src/commands/analyze.dart
View file @
055268ea
...
...
@@ -346,8 +346,6 @@ class AnalyzeCommand extends FlutterCommand {
'Analyzing [
${mainFile.path}
]...'
,
new
RegExp
(
'^
\\
[(hint|error)
\\
] Unused import
\\
(
${mainFile.path}
,'
),
new
RegExp
(
r'^\[.+\] .+ \(.+/\.pub-cache/.+'
),
new
RegExp
(
'
\\
[warning
\\
] Missing concrete implementation of
\'
RenderObject
\\
.applyPaintTransform
\'
'
),
// https://github.com/dart-lang/sdk/issues/25232
new
RegExp
(
'
\\
[warning
\\
] Missing concrete implementation of
\'
AbstractNode
\\
.attach
\'
'
),
// https://github.com/dart-lang/sdk/issues/25232
new
RegExp
(
r'[0-9]+ (error|warning|hint|lint).+found\.'
),
new
RegExp
(
r'^$'
),
];
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment