Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
04fe25e6
Unverified
Commit
04fe25e6
authored
May 08, 2020
by
Zachary Anderson
Committed by
GitHub
May 08, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] Don't try to execute gradle wrapper out of /tmp (#56706)
parent
d5634982
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
6 deletions
+12
-6
cache.dart
packages/flutter_tools/lib/src/cache.dart
+7
-4
cache_test.dart
packages/flutter_tools/test/general.shard/cache_test.dart
+5
-2
No files found.
packages/flutter_tools/lib/src/cache.dart
View file @
04fe25e6
...
@@ -111,7 +111,7 @@ class Cache {
...
@@ -111,7 +111,7 @@ class Cache {
_artifacts
.
add
(
MaterialFonts
(
this
));
_artifacts
.
add
(
MaterialFonts
(
this
));
_artifacts
.
add
(
GradleWrapper
(
this
));
_artifacts
.
add
(
GradleWrapper
(
this
));
_artifacts
.
add
(
AndroidMavenArtifacts
());
_artifacts
.
add
(
AndroidMavenArtifacts
(
this
));
_artifacts
.
add
(
AndroidGenSnapshotArtifacts
(
this
));
_artifacts
.
add
(
AndroidGenSnapshotArtifacts
(
this
));
_artifacts
.
add
(
AndroidInternalBuildArtifacts
(
this
));
_artifacts
.
add
(
AndroidInternalBuildArtifacts
(
this
));
...
@@ -990,12 +990,15 @@ class AndroidInternalBuildArtifacts extends EngineCachedArtifact {
...
@@ -990,12 +990,15 @@ class AndroidInternalBuildArtifacts extends EngineCachedArtifact {
/// A cached artifact containing the Maven dependencies used to build Android projects.
/// A cached artifact containing the Maven dependencies used to build Android projects.
class
AndroidMavenArtifacts
extends
ArtifactSet
{
class
AndroidMavenArtifacts
extends
ArtifactSet
{
AndroidMavenArtifacts
()
:
super
(
DevelopmentArtifact
.
androidMaven
);
AndroidMavenArtifacts
(
this
.
cache
)
:
super
(
DevelopmentArtifact
.
androidMaven
);
final
Cache
cache
;
@override
@override
Future
<
void
>
update
()
async
{
Future
<
void
>
update
()
async
{
final
Directory
tempDir
=
final
Directory
tempDir
=
cache
.
getRoot
().
createTempSync
(
globals
.
fs
.
systemTempDirectory
.
createTempSync
(
'flutter_gradle_wrapper.'
);
'flutter_gradle_wrapper.'
,
);
gradleUtils
.
injectGradleWrapperIfNeeded
(
tempDir
);
gradleUtils
.
injectGradleWrapperIfNeeded
(
tempDir
);
final
Status
status
=
globals
.
logger
.
startProgress
(
'Downloading Android Maven dependencies...'
,
final
Status
status
=
globals
.
logger
.
startProgress
(
'Downloading Android Maven dependencies...'
,
...
...
packages/flutter_tools/test/general.shard/cache_test.dart
View file @
04fe25e6
...
@@ -370,12 +370,15 @@ void main() {
...
@@ -370,12 +370,15 @@ void main() {
});
});
test
(
'development artifact'
,
()
async
{
test
(
'development artifact'
,
()
async
{
final
AndroidMavenArtifacts
mavenArtifacts
=
AndroidMavenArtifacts
();
final
AndroidMavenArtifacts
mavenArtifacts
=
AndroidMavenArtifacts
(
mockCache
);
expect
(
mavenArtifacts
.
developmentArtifact
,
DevelopmentArtifact
.
androidMaven
);
expect
(
mavenArtifacts
.
developmentArtifact
,
DevelopmentArtifact
.
androidMaven
);
});
});
testUsingContext
(
'update'
,
()
async
{
testUsingContext
(
'update'
,
()
async
{
final
AndroidMavenArtifacts
mavenArtifacts
=
AndroidMavenArtifacts
();
final
Directory
cacheRoot
=
globals
.
fs
.
directory
(
'/bin/cache'
)
..
createSync
(
recursive:
true
);
when
(
mockCache
.
getRoot
()).
thenReturn
(
cacheRoot
);
final
AndroidMavenArtifacts
mavenArtifacts
=
AndroidMavenArtifacts
(
mockCache
);
expect
(
mavenArtifacts
.
isUpToDate
(),
isFalse
);
expect
(
mavenArtifacts
.
isUpToDate
(),
isFalse
);
final
Directory
gradleWrapperDir
=
globals
.
fs
.
systemTempDirectory
.
createTempSync
(
'flutter_cache_test_gradle_wrapper.'
);
final
Directory
gradleWrapperDir
=
globals
.
fs
.
systemTempDirectory
.
createTempSync
(
'flutter_cache_test_gradle_wrapper.'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment