Commit 03393510 authored by xster's avatar xster Committed by GitHub

address comments (#10786)

parent 5ae6b7b9
...@@ -209,11 +209,10 @@ class FlutterVersion { ...@@ -209,11 +209,10 @@ class FlutterVersion {
if (beenAWhileSinceWarningWasPrinted && installationSeemsOutdated && await newerFrameworkVersionAvailable()) { if (beenAWhileSinceWarningWasPrinted && installationSeemsOutdated && await newerFrameworkVersionAvailable()) {
printStatus(versionOutOfDateMessage(frameworkAge), emphasis: true); printStatus(versionOutOfDateMessage(frameworkAge), emphasis: true);
final Future<Null> saveWarningStampFuture = stamp.store(
newTimeWarningWasPrinted: _clock.now(),
);
await Future.wait<Null>(<Future<Null>>[ await Future.wait<Null>(<Future<Null>>[
saveWarningStampFuture, stamp.store(
newTimeWarningWasPrinted: _clock.now(),
),
new Future<Null>.delayed(kPauseToLetUserReadTheMessage), new Future<Null>.delayed(kPauseToLetUserReadTheMessage),
]); ]);
} }
...@@ -257,9 +256,7 @@ class FlutterVersion { ...@@ -257,9 +256,7 @@ class FlutterVersion {
try { try {
final String branch = _channel == 'alpha' ? 'alpha' : 'master'; final String branch = _channel == 'alpha' ? 'alpha' : 'master';
final DateTime remoteFrameworkCommitDate = DateTime.parse(await FlutterVersion.fetchRemoteFrameworkCommitDate(branch)); final DateTime remoteFrameworkCommitDate = DateTime.parse(await FlutterVersion.fetchRemoteFrameworkCommitDate(branch));
// fire and forget since nothing subsequent depends on it. Hope there's a flush/sync mechanism. await versionCheckStamp.store(
// ignore: unawaited_futures
versionCheckStamp.store(
newTimeVersionWasChecked: _clock.now(), newTimeVersionWasChecked: _clock.now(),
newKnownRemoteVersion: remoteFrameworkCommitDate, newKnownRemoteVersion: remoteFrameworkCommitDate,
); );
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment