Unverified Commit 02dc0ab3 authored by Jenn Magder's avatar Jenn Magder Committed by GitHub

Remove unnecessary BuildableIOSApp from "build ios-framework" (#49659)

parent d85ea513
...@@ -9,7 +9,6 @@ import 'package:meta/meta.dart'; ...@@ -9,7 +9,6 @@ import 'package:meta/meta.dart';
import 'package:platform/platform.dart'; import 'package:platform/platform.dart';
import '../aot.dart'; import '../aot.dart';
import '../application_package.dart';
import '../artifacts.dart'; import '../artifacts.dart';
import '../base/common.dart'; import '../base/common.dart';
import '../base/file_system.dart'; import '../base/file_system.dart';
...@@ -159,16 +158,15 @@ class BuildIOSFrameworkCommand extends BuildSubCommand { ...@@ -159,16 +158,15 @@ class BuildIOSFrameworkCommand extends BuildSubCommand {
throwToolExit('--output is required.'); throwToolExit('--output is required.');
} }
final BuildableIOSApp iosProject = await applicationPackages.getPackageForPlatform(TargetPlatform.ios) as BuildableIOSApp; if (!_project.ios.existsSync()) {
throwToolExit('Module does not support iOS');
if (iosProject == null) {
throwToolExit("Module's iOS folder missing");
} }
final Directory outputDirectory = globals.fs.directory(globals.fs.path.absolute(globals.fs.path.normalize(outputArgument))); final Directory outputDirectory = globals.fs.directory(globals.fs.path.absolute(globals.fs.path.normalize(outputArgument)));
final String productBundleIdentifier = await _project.ios.productBundleIdentifier;
for (final BuildMode mode in buildModes) { for (final BuildMode mode in buildModes) {
globals.printStatus('Building frameworks for $iosProject in ${getNameForBuildMode(mode)} mode...'); globals.printStatus('Building frameworks for $productBundleIdentifier in ${getNameForBuildMode(mode)} mode...');
final String xcodeBuildConfiguration = toTitleCase(getNameForBuildMode(mode)); final String xcodeBuildConfiguration = toTitleCase(getNameForBuildMode(mode));
final Directory modeDirectory = outputDirectory.childDirectory(xcodeBuildConfiguration); final Directory modeDirectory = outputDirectory.childDirectory(xcodeBuildConfiguration);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment