Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
020bf31c
Unverified
Commit
020bf31c
authored
Mar 04, 2022
by
Mathieu Dubois-Briand
Committed by
GitHub
Mar 04, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix custom-device default forwardPortSuccessRegex (#97719)
parent
163a7ac1
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
547 additions
and
8 deletions
+547
-8
custom_devices.dart
packages/flutter_tools/lib/src/commands/custom_devices.dart
+3
-2
custom_device_config.dart
...er_tools/lib/src/custom_devices/custom_device_config.dart
+3
-2
custom_devices_test.dart
...ols/test/commands.shard/hermetic/custom_devices_test.dart
+541
-4
No files found.
packages/flutter_tools/lib/src/commands/custom_devices.dart
View file @
020bf31c
...
...
@@ -736,11 +736,12 @@ class CustomDevicesAddCommand extends CustomDevicesCommandBase {
'-o'
,
'ExitOnForwardFailure=yes'
,
if
(
ipv6
)
'-6'
,
'-L'
,
'
$formattedLoopbackIp
:
\
${hostPort}
:
$formattedLoopbackIp
:
\
${devicePort}
'
,
sshTarget
sshTarget
,
"echo 'Port forwarding success'; read"
]
:
null
,
forwardPortSuccessRegex:
usePortForwarding
?
RegExp
(
'
Linux
'
)
?
RegExp
(
'
Port forwarding success
'
)
:
null
,
screenshotCommand:
screenshotCommand
.
isNotEmpty
...
...
packages/flutter_tools/lib/src/custom_devices/custom_device_config.dart
View file @
020bf31c
...
...
@@ -264,8 +264,9 @@ class CustomDeviceConfig {
'-o'
,
'ExitOnForwardFailure=yes'
,
'-L'
,
r'127.0.0.1:${hostPort}:127.0.0.1:${devicePort}'
,
'pi@raspberrypi'
,
"echo 'Port forwarding success'; read"
,
],
forwardPortSuccessRegex:
RegExp
(
'
Linux
'
),
forwardPortSuccessRegex:
RegExp
(
'
Port forwarding success
'
),
screenshotCommand:
const
<
String
>[
'ssh'
,
'-o'
,
'BatchMode=yes'
,
...
...
@@ -472,7 +473,7 @@ class CustomDeviceConfig {
_kEnabled:
enabled
,
_kPingCommand:
pingCommand
,
_kPingSuccessRegex:
pingSuccessRegex
?.
pattern
,
_kPostBuildCommand:
postBuildCommand
,
_kPostBuildCommand:
(
postBuildCommand
?.
length
??
0
)
>
0
?
postBuildCommand
:
null
,
_kInstallCommand:
installCommand
,
_kUninstallCommand:
uninstallCommand
,
_kRunDebugCommand:
runDebugCommand
,
...
...
packages/flutter_tools/test/commands.shard/hermetic/custom_devices_test.dart
View file @
020bf31c
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment