Unverified Commit 01f779e9 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

Fix NPE in Chrome Device (#42813)

parent fbbc4fa8
...@@ -61,7 +61,7 @@ class ChromeDevice extends Device { ...@@ -61,7 +61,7 @@ class ChromeDevice extends Device {
@override @override
DeviceLogReader getLogReader({ApplicationPackage app}) { DeviceLogReader getLogReader({ApplicationPackage app}) {
return NoOpDeviceLogReader(app.name); return NoOpDeviceLogReader(app?.name);
} }
@override @override
......
...@@ -42,6 +42,7 @@ void main() { ...@@ -42,6 +42,7 @@ void main() {
expect(chromeDevice.supportsScreenshot, false); expect(chromeDevice.supportsScreenshot, false);
expect(await chromeDevice.isLocalEmulator, false); expect(await chromeDevice.isLocalEmulator, false);
expect(chromeDevice.getLogReader(app: mockWebApplicationPackage), isInstanceOf<NoOpDeviceLogReader>()); expect(chromeDevice.getLogReader(app: mockWebApplicationPackage), isInstanceOf<NoOpDeviceLogReader>());
expect(chromeDevice.getLogReader(), isInstanceOf<NoOpDeviceLogReader>());
expect(await chromeDevice.portForwarder.forward(1), 1); expect(await chromeDevice.portForwarder.forward(1), 1);
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment