• William Hesse's avatar
    [testing] Make the FLUTTER_STORAGE_BASE_URL warning non-fatal (#128335) · 0d39f646
    William Hesse authored
    Presubmit testing and CI testing of Flutter using a custom storage location for engine artifacts must be able to use the --fatal-warnings flag without failing due to the custom artifact location.
    
    This change adds an option that makes this warning non-fatal. The new --no-fatal-storage-url-warning flag makes the --fatal-warnings flag ignore the warning that a custom artifact download URL is being used by setting the environment variable FLUTTER_STORAGE_BASE_URL.
    
    Bug: #127683
    
    - [X ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
    - [X ] I read the [Tree Hygiene] wiki page, which explains my responsibilities.
    - [X ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
    - [X ] I signed the [CLA].
    - [X ] I listed at least one issue that this PR fixes in the description above.
    - [X ] I updated/added relevant documentation (doc comments with `///`).
    0d39f646
attach_test.dart 51.5 KB