Commits · ff3b6dc02cb64c80e3e9b60f4c260ccaed8bea25 · abdullh.alsoleman / Front-End

05 Mar, 2024 18 commits

Enable asset transformation feature in hot reload workflow (excluding Web) (#144161) · ff3b6dc0

Andrew Kolos authored Mar 05, 2024

Partial implementation of https://github.com/flutter/flutter/issues/143348

This enables asset transformation during hot reload (except for web, because that has its own implementation of `DevFS` ð). Asset transformers will be reapplied after changing any asset and performing a hot reload during `flutter run`.

ff3b6dc0

Roll Flutter Engine from 3e8b0deffe4e to 49bc1577f317 (5 revisions) (#144639) · 15e8d324

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/engine/compare/3e8b0deffe4e...49bc1577f317

2024-03-05 zanderso@users.noreply.github.com Fix typo in githook message (flutter/engine#51205)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 453cb0d04584 to 875b356e4d96 (2 revisions) (flutter/engine#51202)
2024-03-05 john@johnmccutchan.com Add device selection to `et run` (flutter/engine#51184)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from de108a9c8b54 to 453cb0d04584 (2 revisions) (flutter/engine#51201)
2024-03-05 zanderso@users.noreply.github.com Adds githooks that reminds to run `gclient sync -D` (flutter/engine#51156)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

15e8d324

Updated the smiley TextButton example again (#144630) · 52961f76

Hans Muller authored Mar 05, 2024

Improved the smiley image TextButton example a little. Handling the case where the `Future.delayed` object that represents the button's one second long action is superseded by a second button press that triggers a new one-second action. This does complicate the example - just a little - but it's a little more robust. In case someone copy-and-pastes the code.

The TextButton example was recently updated: https://github.com/flutter/flutter/pull/144583

52961f76

Adds missing `style` to `PopupMenuButton` (#143392) · 311c0064
Tirth authored Mar 05, 2024
```
Adds missing `style` to `PopupMenuButton`.

Fixes: #114709
```
311c0064

Roll Flutter Engine from a7c785884903 to 3e8b0deffe4e (1 revision) (#144629) · bb8fc6e9

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/engine/compare/a7c785884903...3e8b0deffe4e

2024-03-05 zanderso@users.noreply.github.com Folds concurrent job calculation into `tools/gn` (flutter/engine#51193)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

bb8fc6e9

Add regression test for TabBar crash (#144627) · 2aa1efcf

Michael Goderbauer authored Mar 05, 2024

This is a regression test for https://github.com/flutter/flutter/issues/144087 and https://github.com/flutter/flutter/issues/138588.

To be submitted after https://github.com/flutter/flutter/pull/144579.

2aa1efcf

Roll Packages from 06258277070f to 2aa6e3f6bafe (5 revisions) (#144628) · ba7749a3

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/packages/compare/06258277070f...2aa6e3f6bafe

2024-03-05 gabriel@terwesten.net [in_app_purchase_storekit] Fix type of error code returned from native code in `SKReceiptManager.retrieveReceiptData` (flutter/packages#6265)
2024-03-05 slowhand0309@gmail.com [video_player] Fix typo in readme (flutter/packages#6264)
2024-03-05 10687576+bparrishMines@users.noreply.github.com [pigeon] Separates message call code generation into separate methods in the SwiftGenerator (flutter/packages#5959)
2024-03-05 5384625+pzierahn@users.noreply.github.com [flutter_markdown] Fix WidgetSpan Support in MarkdownElementBuilder (flutter/packages#6225)
2024-03-04 stuartmorgan@google.com [webview_flutter] Make WebKitWebViewWidget unit tests stateless (flutter/packages#6228)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

ba7749a3

remove unused `firstBuildTime` parameter in `DevFS::update` (#144576) · 4e6de2be
Andrew Kolos authored Mar 05, 2024
```
The title says it all. This parameter is unused and serves no apparent purpose.
```
4e6de2be

Roll Flutter Engine from 8916bb32b7b8 to a7c785884903 (1 revision) (#144624) · 4e71b4d8

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/engine/compare/8916bb32b7b8...a7c785884903

2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 10058142c8a2 to de108a9c8b54 (4 revisions) (flutter/engine#51199)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4e71b4d8

Revert "_DefaultTabControllerState should dispose all created TabContoller... · d93f24ab

Michael Goderbauer authored Mar 05, 2024

Revert "_DefaultTabControllerState should dispose all created TabContoller instances. (#136608)" (#144579)

This reverts commit 9fa9fd36.

Fixes https://github.com/flutter/flutter/issues/144087.
Fixes https://github.com/flutter/flutter/issues/138588.

This crash has been reported previously from a customer in google3 in https://github.com/flutter/flutter/issues/138588, but we weren't able to track it down. Thankfully, a repro was now provided in https://github.com/flutter/flutter/issues/144087#issuecomment-1968257383 which traced the crash down to a change made in #136608. This PR reverts that change to fix that crash for now. I will post a new PR shortly that will add a test to cover the use case that caused the crash with #136608 to make sure we don't re-introduce the crash in the future.

d93f24ab

Roll Flutter Engine from 17a4b66e0729 to 8916bb32b7b8 (1 revision) (#144615) · 3b5a2ecf

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/engine/compare/17a4b66e0729...8916bb32b7b8

2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 5839a94bf28b to 10058142c8a2 (2 revisions) (flutter/engine#51197)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3b5a2ecf

Roll Flutter Engine from d514a302cdff to 17a4b66e0729 (8 revisions) (#144607) · a47af891

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/engine/compare/d514a302cdff...17a4b66e0729

2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from a577399ed6fb to 5839a94bf28b (1 revision) (flutter/engine#51194)
2024-03-05 bdero@google.com [Impeller] Turn off StC. (flutter/engine#51191)
2024-03-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Reland: [macOS] Use CVDisplayLink to drive repaint (#51126)" (flutter/engine#51192)
2024-03-05 skia-flutter-autoroll@skia.org Roll Skia from 9c62e7b382cf to a577399ed6fb (1 revision) (flutter/engine#51190)
2024-03-05 31859944+LongCatIsLooong@users.noreply.github.com Reland "Remove migration flag and unused header files #50216" (flutter/engine#50259)
2024-03-05 zanderso@users.noreply.github.com Shift git version fetching to tools/gn (flutter/engine#51175)
2024-03-05 1889916+miguelfrde@users.noreply.github.com [fuchsia] Remove now unnecessary diagnostics directory (flutter/engine#51180)
2024-03-05 bdero@google.com [Impeller] Enable depth buffer clipping & Stencil-then-Cover path rendering. (flutter/engine#50856)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a47af891

Do not shorten native assets framework names (#144568) · df2b3604

Matej Knopp authored Mar 05, 2024

Previously the name was shortened to 15 characters, which doesn't seem
to be necessary.
[CFBundleName](https://developer.apple.com/documentation/bundleresources/information_property_list/cfbundlename)
documentation mentions 15 character length, but that does not seem to be
relevant to framework bundles.

Flutter plugins already have framework bundles with names longer than 15
characters and it is not causing any issues.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

df2b3604

Restorable CupertinoTextFormFieldRow (#144541) · 67e6cad0

Bruno Leroux authored Mar 05, 2024

## Description

This PR makes `CupertinoTextFormFieldRow` restorable.
The implementation is based on https://github.com/flutter/flutter/pull/78835 which made `FormField` and `TextFormField` restorable.

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144504.

## Tests

Adds 4 tests.

67e6cad0

Updated the TextButton image button example artwork (#144583) · e73e7e2e

Hans Muller authored Mar 05, 2024

Updated the "smiley" TextButton example with new images from Nancy Hu @google.  I also made the example a little more complicated, per the new artwork: now it displays a different image while the button's action pretends to run for a second.

https://github.com/flutter/flutter/assets/1377460/b631a484-4b4f-4e01-ad52-a877fb46ef72

e73e7e2e

Roll Flutter Engine from 728aa4ef05d4 to d514a302cdff (2 revisions) (#144581) · 111a5e7a

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/engine/compare/728aa4ef05d4...d514a302cdff

2024-03-04 jason-simmons@users.noreply.github.com [Impeller] Fix string comparison in MockGLES.CanInitialize test (flutter/engine#51181)
2024-03-04 34871572+gmackall@users.noreply.github.com [Re-land] Remove WindowManager reflection in SingleViewPresentation.java (flutter/engine#50890)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

111a5e7a

Roll Flutter Engine from 62cf93be60b2 to 728aa4ef05d4 (3 revisions) (#144578) · fd9905d5

engine-flutter-autoroll authored Mar 05, 2024

https://github.com/flutter/engine/compare/62cf93be60b2...728aa4ef05d4

2024-03-04 ianloic@google.com [fuchsia] Prepare for @transitional removal (flutter/engine#51185)
2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from 9ab297bf1c34 to 9c62e7b382cf (1 revision) (flutter/engine#51182)
2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from f65ecbdfb09c to 9ab297bf1c34 (4 revisions) (flutter/engine#51178)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

fd9905d5

Disable super flakey impeller test. (#144573) · 89b5f3a7
Jonah Williams authored Mar 05, 2024
```
Until we figure out why this is unstable on Impeller swiftshader, disable it.
```
89b5f3a7

04 Mar, 2024 17 commits

Roll Flutter Engine from 40018811ec0e to 62cf93be60b2 (1 revision) (#144572) · 3f7028ea

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/engine/compare/40018811ec0e...62cf93be60b2

2024-03-04 bdero@google.com [Impeller] Fix the clip replay mechanism. (flutter/engine#51173)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3f7028ea

Roll Flutter Engine from 0d8588b1de7a to 40018811ec0e (6 revisions) (#144570) · 8707a755

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/engine/compare/0d8588b1de7a...40018811ec0e

2024-03-04 matej.knopp@gmail.com Reland: [macOS] Use CVDisplayLink to drive repaint (flutter/engine#51126)
2024-03-04 jason-simmons@users.noreply.github.com Support gtest-parallel when running Impeller unit tests (flutter/engine#51079)
2024-03-04 matanlurey@users.noreply.github.com Scenario App: Adds a `run_{count}.{backend}.` file prefix to every run (on CI) (flutter/engine#51102)
2024-03-04 matanlurey@users.noreply.github.com Use Instrumentation.waitForIdleSync() after rotation requests. (flutter/engine#51169)
2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from 9c7d13c05e77 to f65ecbdfb09c (1 revision) (flutter/engine#51170)
2024-03-04 dnfield@google.com Guard against API 22 (flutter/engine#51167)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

8707a755

Print warning and exit when iOS device is unpaired (#144551) · 9b442b27

Jenn Magder authored Mar 04, 2024

Explicitly handle the case where the iOS device is not paired.  On `flutter run` show an error and bail instead of trying and failing to launch on the device.

On this PR:
```
$ flutter run -d 00008110-0009588C2651401E
'iPhone' is not paired. Open Xcode and trust this computer when prompted.
$
```

Fixes https://github.com/flutter/flutter/issues/144447
Closes https://github.com/flutter/flutter/pull/144095

9b442b27

Roll Flutter Engine from a31209171949 to 0d8588b1de7a (1 revision) (#144558) · d9eea796

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/engine/compare/a31209171949...0d8588b1de7a

2024-03-04 30870216+gaaclarke@users.noreply.github.com [Impeller] implements blur styles inner and outer (flutter/engine#51018)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d9eea796

Remove unnecessary (and the only) `RenderObject.markParentNeedsLayout` override (#144466) · de0ccf39
LongCatIsLooong authored Mar 04, 2024
```
Nobody calls it except for `markNeedsLayout`, and the render object is a guaranteed relayout boundary.
```
de0ccf39

Fix text color for default CupertinoContextMenuAction (#144542) · 16d122db

Bruno Leroux authored Mar 04, 2024

## Description

This PR fix the text color for the default action in a CupertiniContextMenu.
Previously the dynamic color was not resolved which leads to text being blacks when theme brightness was dark.

| Before | After |
|--------|--------|
| ![Capture dâeÌcran 2024-03-04 aÌ 14 58 45](https://github.com/flutter/flutter/assets/840911/6a06715d-b2b8-49e1-b6de-37c03b96b627) |  ![Capture dâeÌcran 2024-03-04 aÌ 15 00 27](https://github.com/flutter/flutter/assets/840911/ed7c71ec-96f2-46ca-a5f6-ba3890732e33) |

## Related Issue

Fixes https://github.com/flutter/flutter/issues/144492.

## Tests

Adds 1 test, updates 1.

16d122db

Add missing parameter to `TableBorder.symmetric`, and improve class constructors (#144279) · 1a0dc8f1

Nate authored Mar 04, 2024

Originally, my aim was just to refactor (as per usual), but while messing around with the `TableBorder.symmetric` constructor, I realized that `borderRadius` was missing!

This pull request makes a few class constructors more efficient, and it fixes #144277 by adding the missing parameter.

<br>

1a0dc8f1

Fix build mode not propagated in android native asset build (#144550) · 1d7f4a9a

Matej Knopp authored Mar 04, 2024

This fixes bug where build mode is hardcoded to debug while building
native assets for Android.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#overview
[Tree Hygiene]: https://github.com/flutter/flutter/wiki/Tree-hygiene
[test-exempt]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/wiki/Style-guide-for-Flutter-repo#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/wiki/Tree-hygiene#handling-breaking-changes
[Discord]: https://github.com/flutter/flutter/wiki/Chat
[Data Driven Fixes]:
https://github.com/flutter/flutter/wiki/Data-driven-Fixes

1d7f4a9a

Roll Packages from a9c68b83356b to 06258277070f (3 revisions) (#144556) · 6e7e4f3c

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/packages/compare/a9c68b83356b...06258277070f

2024-03-02 engine-flutter-autoroll@skia.org Roll Flutter from ba719bc5 to 65cd84b5 (5 revisions) (flutter/packages#6239)
2024-03-01 engine-flutter-autoroll@skia.org Roll Flutter from e92bca3f to ba719bc5 (37 revisions) (flutter/packages#6235)
2024-03-01 sergeydesenko@gmail.com [camera_avfoundation] Set highest available resolution for ResolutionPreset.Max (flutter/packages#5245)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6e7e4f3c

Roll Flutter Engine from afd2d9f9421d to a31209171949 (1 revision) (#144554) · d3aa7aab

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/engine/compare/afd2d9f9421d...a31209171949

2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from ff3199348aab to 9c7d13c05e77 (5 revisions) (flutter/engine#51168)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d3aa7aab

Doc fix for `DropdownButtonFormField.value` (#144427) · 7c50267f
Qun Cheng authored Mar 04, 2024
```
Fixes https://github.com/flutter/flutter/issues/144135

This PR is just a doc fix.
```
7c50267f
Fix Small Typo in Skia_Client Doc Comment (#144490) · 35863b75
Tirth authored Mar 04, 2024
```
Fix Small Typo in Skia_Client Doc Comment.
```
35863b75

Roll Flutter Engine from 2338a557e018 to afd2d9f9421d (1 revision) (#144549) · a47548ba

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/engine/compare/2338a557e018...afd2d9f9421d

2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from 4b98d7b3ff2d to ff3199348aab (1 revision) (flutter/engine#51162)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a47548ba

[Windows] Update keyboard modifiers link (#144426) · cc740eb5
Loïc Sharma authored Mar 04, 2024
```
Updates link to the new location. No tests as this only changes a comment.
```
cc740eb5

Roll Flutter Engine from 9cbca80e2196 to 2338a557e018 (2 revisions) (#144545) · 9a957b3d

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/engine/compare/9cbca80e2196...2338a557e018

2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from dfd933f9930c to 4b98d7b3ff2d (2 revisions) (flutter/engine#51160)
2024-03-04 skia-flutter-autoroll@skia.org Roll Skia from a57372ca2e66 to dfd933f9930c (1 revision) (flutter/engine#51158)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

9a957b3d

Roll Flutter Engine from c52b3033eca6 to 9cbca80e2196 (1 revision) (#144523) · b7b289cd

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/engine/compare/c52b3033eca6...9cbca80e2196

2024-03-04 liama@google.com Experimental platform isolates API (flutter/engine#48551)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

b7b289cd

Roll Flutter Engine from 024ea680ceed to c52b3033eca6 (1 revision) (#144522) · d3c274b2

engine-flutter-autoroll authored Mar 04, 2024

https://github.com/flutter/engine/compare/024ea680ceed...c52b3033eca6

2024-03-04 robert.ancell@canonical.com Fix custom FlValue API not being exported (flutter/engine#51154)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d3c274b2

03 Mar, 2024 1 commit

Roll Flutter Engine from 2706c732b22a to 024ea680ceed (1 revision) (#144519) · dab0d189

engine-flutter-autoroll authored Mar 03, 2024

https://github.com/flutter/engine/compare/2706c732b22a...024ea680ceed

2024-03-03 zanderso@users.noreply.github.com Fold the GN dart_pkg template into its only use (flutter/engine#51151)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

dab0d189

02 Mar, 2024 2 commits

Roll Flutter Engine from 8ef8543d6001 to 2706c732b22a (1 revision) (#144493) · 65cd84b5

engine-flutter-autoroll authored Mar 02, 2024

https://github.com/flutter/engine/compare/8ef8543d6001...2706c732b22a

2024-03-01 jason-simmons@users.noreply.github.com [Impeller] ASAN/LSAN fixes for the mock Vulkan implementation (flutter/engine#51115)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

65cd84b5

[github actions] rewrite cherry pick template (#144065) · 09b7a1c7

Xilai Zhang authored Mar 02, 2024

Context: @godofredoc pointed out that the fields in the PR template could be simplified and redesigned. Synced with @itsjustkevin and Kevin come up with [changes in this doc](https://docs.google.com/document/d/1Slppqq32toSwwxUyYTX1t6dGUQpyi0xEWxw4niGWspc/edit?resourcekey=0-v6U_9XVsMFSx0Fvx1rANhg&tab=t.0) which would improve the cherry pick template.

Github only supports a limited number of formatting options. This PR uses some workarounds and makes the following changes:
1. use divider to replace text area since Github markdown doesn't support text area
2. remove \<pre\> tags so texts can wrap around
3. use headings over bold
4. use task lists to identify the starting points of user answers

An example cherry pick template would [look like this](https://github.com/flutter/flutter/pull/143785) after the change.

09b7a1c7

01 Mar, 2024 2 commits

Roll Flutter Engine from 2a5a9a6dead0 to 8ef8543d6001 (1 revision) (#144480) · 18712edc

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/engine/compare/2a5a9a6dead0...8ef8543d6001

2024-03-01 skia-flutter-autoroll@skia.org Roll Skia from b44ad3d40f54 to a57372ca2e66 (1 revision) (flutter/engine#51122)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

18712edc

Roll Packages from 6d02f0359368 to a9c68b83356b (5 revisions) (#144477) · d93f5b7e

engine-flutter-autoroll authored Mar 01, 2024

https://github.com/flutter/packages/compare/6d02f0359368...a9c68b83356b

2024-03-01 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.24.5 to 3.24.6 (flutter/packages#6234)
2024-02-29 stuartmorgan@google.com [various] Standardize Obj-C doc comment style (flutter/packages#6232)
2024-02-29 joonas.kerttula@codemate.com [google_maps_flutter] Add support for marker clustering - platform interface (flutter/packages#6158)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter (stable) from abb292a07e20 to 7482962148e8 (1 revision) (flutter/packages#6230)
2024-02-29 engine-flutter-autoroll@skia.org Roll Flutter from d00bfe82 to e92bca3f (15 revisions) (flutter/packages#6227)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

d93f5b7e