- 15 Feb, 2023 9 commits
-
-
LouiseHsu authored
* add default case to prep for engine pr * combine unknown w default * fixed todo comment not inline with flutter standards
-
Loïc Sharma authored
Reverts flutter/flutter#114468 by @fzyzcjy Example failure: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8789140722059256001/+/u/run_test.dart_for_tool_integration_tests_shard_and_subshard_1_4/test_stdout
-
LongCatIsLooong authored
-
Viren Khatri authored
-
Ian Hickson authored
...and various other minor cleanup: * Moved "FLUTTER_STORAGE_BASE_URL" into a constant throughout the code. There are other strings that we should do that to but this one was relevant to the code I was changing. * Fixed the logger's handling of slow warnings. Previously it deleted too much text. Fixed the test for that to actually verify it entirely, too. * Made the logger delete the slow warning when it's finished. * Fixed 'Please choose one (To quit, press "q/Q")' message to be the cleaner 'Please choose one (or "q" to quit)'. * Added a debug toString to ValidationResult for debugging purposes (not used). * In http_host_validator: - Shortened constant names to be clearer (e.g. kPubDevHttpHost -> kPubDev). - Added GitHub as a tested host since when you run `flutter` we hit that immediately. - Renamed the check "Network resources". - Updated the `slowWarning` of the check to say which hosts are pending. - Removed all timeout logic. Timeouts violate our style guide. - Removed `int.parse(... ?? '10')`; passing a constant to `int.parse` is inefficient. - Replaced the `_HostValidationResult` class with `String?` for simplicity. - Improved the error messages to be more detailed. - Removed all checks that dependened on the stringification of exceptions. That's very brittle. - Added a warning specifically for HandshakeException that talks about the implications (MITM attacks). - Replaced exception-message-parsing logic with just calling `Uri.tryParse` and validating the result. - Replaced a lot of list-filtering logic with just a single for loop to check the results. - Replaced code that added a constant to a known-empty list with just returning a constant list. - Revamped the logic for deciding which hosts to check to just use a single chain of if/else blocks instead of getters, lists literals with `if` expressions, `??`, functions, etc spread over multiple places in the code.
-
godofredoc authored
* Move linux-x64-flutter-gtk.zip to linux-x64-debug location. linux-x64-flutter-gtk.zip is being uploaded twice to linux-x64-debug and linux-x64 as part of making a soft transition to use linux-x64-debug location. This PR starts using the copy inside linux-x64-debug to later remove the duplicated upload. * Also move arm64. * Do not override output dir.
-
engine-flutter-autoroll authored
d86089252 Roll Fuchsia Mac SDK from OeUljRQOmJwgDhNOo... to EFcCpAxOuQllDqP0F... (flutter/engine#39621) (#120702)
-
Loïc Sharma authored
-
fzyzcjy authored
* move _verifyInvariants * fix * fix (mimic import test_api.dart) * fix * Update binding.dart * add tests * try to move * Revert "try to move" This reverts commit d3c466d226cc1abe195af83a2630c70f08e25d7d. * Update binding.dart
-
- 14 Feb, 2023 10 commits
-
-
Nils Reichardt authored
* [integration_test] Fix link to integration test for web section in `README.md` * Update packages/integration_test/README.md * Update packages/integration_test/README.md
-
Loïc Sharma authored
This target recently caused the tree to close due to a timeout: https://ci.chromium.org/ui/p/flutter/builders/prod/Linux%20docs_publish/8906/overview This target consistently takes ~55 minutes, which is very close to its current timeout of 60 minutes. This increases the timeout to make timeouts less likely.
-
Loïc Sharma authored
Fixes this PR: https://github.com/flutter/flutter/pull/120628 Reverting was rejected due to merge conflicts(?): https://github.com/flutter/flutter/pull/120705
-
Flutter GitHub Bot authored
-
engine-flutter-autoroll authored
-
engine-flutter-autoroll authored
* f1a3fea7f Update GCLOUD_FIREBASE_TESTLAB_KEY (flutter/plugins#7176) * 9c312d4d2 [camera] flip/change camera while recording (split out PR for cam_avfoundation and cam_android) (flutter/plugins#7109)
-
Eilidh Southren authored
* add actionOverflowThreshold param * analyzer tings * https://www.youtube.com/watch?v=NPwyyjtxlzU * remove erroneous switch changes * rename test * remove unwanted switch.dart diff * remove redundant values * review changes
-
engine-flutter-autoroll authored
* 22177253a Roll Skia from 38e363bbf0e4 to 53f66167d9cb (4 revisions) (flutter/engine#39615) * cbb7fc020 Roll Skia from 53f66167d9cb to bb7b22f3f444 (1 revision) (flutter/engine#39616)
-
engine-flutter-autoroll authored
* 3b5c47d4d Revert "[ios_platform_view] MaskView pool to reuse maskViews." (flutter/engine#39608) * 170a4a31e Roll Skia from f27efe15433d to 38e363bbf0e4 (8 revisions) (flutter/engine#39611) * 632b5985a Roll Fuchsia Mac SDK from 6hbPQq6ED0PkuQiKM... to OeUljRQOmJwgDhNOo... (flutter/engine#39610) * 6a3aaefc0 Roll Fuchsia Linux SDK from 5b_BYTPWG1E7qx1I8... to mWwKhmxRlXNJATVmu... (flutter/engine#39613) * 17ab09d38 Remove bringup from builds. (flutter/engine#39605)
-
engine-flutter-autoroll authored
* 8cd648d1d Roll Dart SDK from f80c5db8736a to ea59504416a8 (1 revision) (flutter/engine#39594) * 9ac09ced1 [Impeller] Fix unsafe access for clip stencil coverage (flutter/engine#39595) * 99a81a81f Add support for double tap action from Apple Pencil 2 (flutter/engine#39267) * 89d41d13e Add unique device id for trackpad on web (flutter/engine#39260) * f7dfb2b63 remove use of SkCanvas and DLCanvasRecorder from ui.Canvas native code (flutter/engine#39599) * c2e165e36 Fix multi-function compute (flutter/engine#39603) * c4f51bc78 Revert "Add support for double tap action from Apple Pencil 2 (#39267)" (flutter/engine#39607)
-
- 13 Feb, 2023 21 commits
-
-
Ian Hickson authored
-
Loïc Sharma authored
-
Taha Tesser authored
-
engine-flutter-autoroll authored
* 7f0aac5af [Impeller] Fix grammatical issues in faq.md. (flutter/engine#39582) * 31a4648cb Roll Skia from 9cc86b2a4f27 to f27efe15433d (17 revisions) (flutter/engine#39593)
-
Tae Hyung Kim authored
* init * fix error handling * fix issue * lint? * error handling tests * lint
-
gaaclarke authored
* Added integration test for wide gamut support. * cleaned up * deleted files that can be generated * switched back to standard flutter in the shell script * added devicelab task * removed analysis options * analyzer * Fixed task * made local_run.sh not executable * analyzer * removed the logo asset * added task to ci * updated pubspec * analysis errors fixed * updated pubspec
-
xubaolin authored
-
engine-flutter-autoroll authored
d28cbf402 [Impeller] Return entity from filters instead of a snapshot (flutter/engine#39560) (#120625)
-
Jenn Magder authored
-
Qun Cheng authored
-
engine-flutter-autoroll authored
* 9a1b7d113 Change run_tests.sh to use python3 (flutter/engine#39586) * a023d4f63 Remove Libtxt and Minikin (flutter/engine#39499) * a7c9cc58a [Impeller] Get rid of message about prototype status. (flutter/engine#39566) * 97dcf3e62 Reland [macOS] Make FlutterEngine support multiple views (flutter/engine#39576)
-
Taha Tesser authored
* Remove `prefer_equal_for_default_values` lint rule * Remove prefer_equal_for_default_values line
-
Ben Konyi authored
Observatory is being deprecated for Dart 3.0 so it should no longer be referenced in tooling messaging / flags. See https://github.com/dart-lang/sdk/issues/50233
-
Flutter GitHub Bot authored
-
Tomasz Gucio authored
--------- Co-authored-by: schectman <schectman@google.com>
-
Qun Cheng authored
-
engine-flutter-autoroll authored
* 8cacce9e8 Roll Skia from d85501fa487d to 9cc86b2a4f27 (2 revisions) (flutter/engine#39589) * df0ffe42b Roll Fuchsia Linux SDK from R6oclCbqlvHdyGgut... to 5b_BYTPWG1E7qx1I8... (flutter/engine#39590)
-
Flutter GitHub Bot authored
-
engine-flutter-autoroll authored
fb8840578 Roll Dart SDK from 1caf3a9ad101 to f80c5db8736a (1 revision) (flutter/engine#39588) (#120606)
-
engine-flutter-autoroll authored
60c8532d6 Roll Fuchsia Mac SDK from NZAnfCkpbswhYplty... to 6hbPQq6ED0PkuQiKM... (flutter/engine#39587) (#120602)
-
engine-flutter-autoroll authored
* f47f74051 [file_selector] Relax xdg_directories constraint (flutter/plugins#7157) * f3bc6f1eb [various] Raise JVM limit in example builds (flutter/plugins#7155)
-