Commits · fa5869a4624a3b4c504c871a55626def6fc28693 · abdullh.alsoleman / Front-End

14 Jul, 2023 33 commits

Clarify docs on WidgetsBindingObserver (#130621) · fa5869a4
Ian Hickson authored Jul 14, 2023
```
Fixes https://github.com/flutter/flutter/issues/56102
```
fa5869a4

Bump github/codeql-action from 2.2.9 to 2.20.4 (#130618) · 7064b4e9

dependabot[bot] authored Jul 14, 2023

Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.2.9 to 2.20.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>CodeQL Bundle</h2>
<p>Bundles CodeQL CLI v2.14.0</p>
<ul>
<li>(<a href="https://github.com/github/codeql-cli-binaries/blob/HEAD/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql-cli-binaries/releases/tag/v2.14.0">release</a>)</li>
</ul>
<p>Includes the following CodeQL language packs from <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0"><code>github/codeql@codeql-cli/v2.14.0</code></a>:</p>
<ul>
<li><code>codeql/cpp-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/cpp/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/cpp/ql/src">source</a>)</li>
<li><code>codeql/cpp-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/cpp/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/cpp/ql/lib">source</a>)</li>
<li><code>codeql/csharp-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/csharp/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/csharp/ql/src">source</a>)</li>
<li><code>codeql/csharp-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/csharp/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/csharp/ql/lib">source</a>)</li>
<li><code>codeql/go-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/go/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/go/ql/src">source</a>)</li>
<li><code>codeql/go-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/go/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/go/ql/lib">source</a>)</li>
<li><code>codeql/java-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/java/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/java/ql/src">source</a>)</li>
<li><code>codeql/java-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/java/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/java/ql/lib">source</a>)</li>
<li><code>codeql/javascript-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/javascript/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/javascript/ql/src">source</a>)</li>
<li><code>codeql/javascript-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/javascript/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/javascript/ql/lib">source</a>)</li>
<li><code>codeql/python-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/python/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/python/ql/src">source</a>)</li>
<li><code>codeql/python-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/python/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/python/ql/lib">source</a>)</li>
<li><code>codeql/ruby-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/ruby/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/ruby/ql/src">source</a>)</li>
<li><code>codeql/ruby-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/ruby/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/ruby/ql/lib">source</a>)</li>
<li><code>codeql/swift-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/swift/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/swift/ql/src">source</a>)</li>
<li><code>codeql/swift-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/swift/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.14.0/swift/ql/lib">source</a>)</li>
</ul>
<h2>CodeQL Bundle</h2>
<p>Bundles CodeQL CLI v2.13.5</p>
<ul>
<li>(<a href="https://github.com/github/codeql-cli-binaries/blob/HEAD/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql-cli-binaries/releases/tag/v2.13.5">release</a>)</li>
</ul>
<p>Includes the following CodeQL language packs from <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5"><code>github/codeql@codeql-cli/v2.13.5</code></a>:</p>
<ul>
<li><code>codeql/cpp-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/cpp/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/cpp/ql/src">source</a>)</li>
<li><code>codeql/cpp-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/cpp/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/cpp/ql/lib">source</a>)</li>
<li><code>codeql/csharp-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/csharp/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/csharp/ql/src">source</a>)</li>
<li><code>codeql/csharp-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/csharp/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/csharp/ql/lib">source</a>)</li>
<li><code>codeql/go-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/go/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/go/ql/src">source</a>)</li>
<li><code>codeql/go-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/go/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/go/ql/lib">source</a>)</li>
<li><code>codeql/java-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/java/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/java/ql/src">source</a>)</li>
<li><code>codeql/java-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/java/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/java/ql/lib">source</a>)</li>
<li><code>codeql/javascript-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/javascript/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/javascript/ql/src">source</a>)</li>
<li><code>codeql/javascript-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/javascript/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/javascript/ql/lib">source</a>)</li>
<li><code>codeql/python-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/python/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/python/ql/src">source</a>)</li>
<li><code>codeql/python-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/python/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/python/ql/lib">source</a>)</li>
<li><code>codeql/ruby-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/ruby/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/ruby/ql/src">source</a>)</li>
<li><code>codeql/ruby-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/ruby/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/ruby/ql/lib">source</a>)</li>
<li><code>codeql/swift-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/swift/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/swift/ql/src">source</a>)</li>
<li><code>codeql/swift-all</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/swift/ql/lib/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.5/swift/ql/lib">source</a>)</li>
</ul>
<h2>CodeQL Bundle</h2>
<p>Bundles CodeQL CLI v2.13.4</p>
<ul>
<li>(<a href="https://github.com/github/codeql-cli-binaries/blob/HEAD/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql-cli-binaries/releases/tag/v2.13.4">release</a>)</li>
</ul>
<p>Includes the following CodeQL language packs from <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4"><code>github/codeql@codeql-cli/v2.13.4</code></a>:</p>
<ul>
<li><code>codeql/cpp-queries</code> (<a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/cpp/ql/src/CHANGELOG.md">changelog</a>, <a href="https://github.com/github/codeql/tree/codeql-cli/v2.13.4/cpp/ql/src">source</a>)</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/blob/main/CHANGELOG.md">github/codeql-action's changelog</a>.</em></p>
<blockquote>
<h1>CodeQL Action Changelog</h1>
<h2>[UNRELEASED]</h2>
<p>No user facing changes.</p>
<p>See the <a href="https://github.com/github/codeql-action/releases">releases page</a> for the relevant changes to the CodeQL CLI and language packs.</p>
<h2>2.20.4 - 14 Jul 2023</h2>
<ul>
<li>This is the last release of the Action that supports CodeQL CLI versions 2.8.5 to 2.9.3. These versions of the CodeQL CLI were deprecated on June 20, 2023 alongside GitHub Enterprise Server 3.5 and will not be supported by the next release of the CodeQL Action (2.21.0).
<ul>
<li>If you are using one of these versions, please update to CodeQL CLI version 2.9.4 or later. For instance, if you have specified a custom version of the CLI using the 'tools' input to the 'init' Action, you can remove this input to use the default version.</li>
<li>Alternatively, if you want to continue using a version of the CodeQL CLI between 2.8.5 and 2.9.3, you can replace 'github/codeql-action/<em><a href="https://github.com/v2"><code>@âv2</code></a>' by 'github/codeql-action/</em><a href="https://github.com/v2"><code>@âv2</code></a>.20.4' in your code scanning workflow to ensure you continue using this version of the CodeQL Action.</li>
</ul>
</li>
<li>We are rolling out a feature in July 2023 that will slightly reduce the default amount of RAM used for query execution, in proportion to the runner's total memory. This will help to avoid out-of-memory failures on larger runners. <a href="https://redirect.github.com/github/codeql-action/pull/1760">#1760</a></li>
<li>Update default CodeQL bundle version to 2.14.0. <a href="https://redirect.github.com/github/codeql-action/pull/1762">#1762</a></li>
</ul>
<h2>2.20.3 - 06 Jul 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.5. <a href="https://redirect.github.com/github/codeql-action/pull/1743">#1743</a></li>
</ul>
<h2>2.20.2 - 03 Jul 2023</h2>
<p>No user facing changes.</p>
<h2>2.20.1 - 21 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.4. <a href="https://redirect.github.com/github/codeql-action/pull/1721">#1721</a></li>
<li>Experimental: add a new <code>resolve-environment</code> action which attempts to infer a configuration for the build environment that is required to build a given project. Do not use this in production as it is part of an internal experiment and subject to change at any time.</li>
</ul>
<h2>2.20.0 - 13 Jun 2023</h2>
<ul>
<li>Bump the version of the Action to 2.20.0. This ensures that users who received a Dependabot upgrade to <a href="https://github.com/github/codeql-action/commit/cdcdbb579706841c47f7063dda365e292e5cad7a"><code>cdcdbb5</code></a>, which was mistakenly marked as Action version 2.13.4, continue to receive updates to the CodeQL Action. Full details in <a href="https://redirect.github.com/github/codeql-action/pull/1729">#1729</a></li>
</ul>
<h2>2.3.6 - 01 Jun 2023</h2>
<ul>
<li>Update default CodeQL bundle version to 2.13.3. <a href="https://redirect.github.com/github/codeql-action/pull/1698">#1698</a></li>
</ul>
<h2>2.3.5 - 25 May 2023</h2>
<ul>
<li>Allow invalid URIs to be used as values to <code>artifactLocation.uri</code> properties. This reverses a change from <a href="https://redirect.github.com/github/codeql-action/pull/1668">#1668</a> that inadvertently led to stricter validation of some URI values. <a href="https://redirect.github.com/github/codeql-action/pull/1705">#1705</a></li>
<li>Gracefully handle invalid URIs when fingerprinting. <a href="https://redirect.github.com/github/codeql-action/pull/1694">#1694</a></li>
</ul>
<h2>2.3.4 - 24 May 2023</h2>
<ul>
<li>Updated the SARIF 2.1.0 JSON schema file to the latest from <a href="https://github.com/oasis-tcs/sarif-spec/blob/123e95847b13fbdd4cbe2120fa5e33355d4a042b/Schemata/sarif-schema-2.1.0.json">oasis-tcs/sarif-spec</a>. <a href="https://redirect.github.com/github/codeql-action/pull/1668">#1668</a></li>
<li>We are rolling out a feature in May 2023 that will disable Python dependency installation for new users of the CodeQL Action. This improves the speed of analysis while having only a very minor impact on results. <a href="https://redirect.github.com/github/codeql-action/pull/1676">#1676</a></li>
<li>We are improving the way that <a href="https://github.com/github/codeql-action/releases">CodeQL bundles</a> are tagged to make it possible to easily identify bundles by their CodeQL semantic version. <a href="https://redirect.github.com/github/codeql-action/pull/1682">#1682</a>
<ul>
<li>As of CodeQL CLI 2.13.4, CodeQL bundles will be tagged using semantic versions, for example <code>codeql-bundle-v2.13.4</code>, instead of timestamps, like <code>codeql-bundle-20230615</code>.</li>
<li>This change does not affect the majority of workflows, and we will not be changing tags for existing bundle releases.</li>
<li>Some workflows with custom logic that depends on the specific format of the CodeQL bundle tag may need to be updated. For example, if your workflow matches CodeQL bundle tag names against a <code>codeql-bundle-yyyymmdd</code> pattern, you should update it to also recognize <code>codeql-bundle-vx.y.z</code> tags.</li>
</ul>
</li>
</ul>
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/github/codeql-action/commit/489225d82a57396c6f426a40e66d461b16b3461d"><code>489225d</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1777">#1777</a> from github/update-v2.20.4-a148c5807</li>
<li><a href="https://github.com/github/codeql-action/commit/1b6383d6bebf0c5eef2c5b116b57e65305f1e68e"><code>1b6383d</code></a> Update changelog for v2.20.4</li>
<li><a href="https://github.com/github/codeql-action/commit/a148c5807597c04d85de6c6284841298d2196b26"><code>a148c58</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1776">#1776</a> from github/aeisenberg/changelog-releases</li>
<li><a href="https://github.com/github/codeql-action/commit/50527c5dba2698a586a3876acd5d77190081f84a"><code>50527c5</code></a> Add link to releases page in changelog</li>
<li><a href="https://github.com/github/codeql-action/commit/814b2edab6babf4a3e6c26347ab7f808e3c8dfca"><code>814b2ed</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1762">#1762</a> from github/update-bundle/codeql-bundle-v2.14.0</li>
<li><a href="https://github.com/github/codeql-action/commit/d2baed4b69c087359dd772379773b7c71176593e"><code>d2baed4</code></a> Merge branch 'main' into update-bundle/codeql-bundle-v2.14.0</li>
<li><a href="https://github.com/github/codeql-action/commit/c5526174a564f5a5444d71884af87163f19cf394"><code>c552617</code></a> Merge pull request <a href="https://redirect.github.com/github/codeql-action/issues/1774">#1774</a> from github/dependabot/npm_and_yarn/npm-a34e423e98</li>
<li><a href="https://github.com/github/codeql-action/commit/c1f49580cf4d0ff9c5138f90285149e7f577a446"><code>c1f4958</code></a> Fix dependency incompatibilities</li>
<li><a href="https://github.com/github/codeql-action/commit/40a500c743e951b52d1804a1b9b0ff1e3073cd0a"><code>40a500c</code></a> Update checked-in dependencies</li>
<li><a href="https://github.com/github/codeql-action/commit/4fad06f4382599943ac05e9d91ac49700375f9b9"><code>4fad06f</code></a> Bump the npm group with 21 updates</li>
<li>Additional commits viewable in <a href="https://github.com/github/codeql-action/compare/04df1262e6247151b5ac09cd2c303ac36ad3f62b...489225d82a57396c6f426a40e66d461b16b3461d">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github/codeql-action&package-manager=github_actions&previous-version=2.2.9&new-version=2.20.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

7064b4e9

Roll Flutter Engine from 21b8e6831be9 to 403866d16137 (2 revisions) (#130626) · 86726cde

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/21b8e6831be9...403866d16137

2023-07-14 jonahwilliams@google.com [Impeller] defer construction of VkCommandBuffer until encoding begins. (flutter/engine#43605)
2023-07-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from LZPMbHnVPFdbXndcX... to DEENqWMCYI1SMYsYH... (flutter/engine#43702)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from LZPMbHnVPFdb to DEENqWMCYI1S

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC rmistry@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

86726cde

Remove duplicated dart:ui imports (#130606) · 5654bfe8
Michael Goderbauer authored Jul 14, 2023
```
Small clean up. A file probably doesn't need multiple way to refer to dart:ui concepts.
```
5654bfe8

Roll Flutter Engine from 2fabf4e5c9ed to 21b8e6831be9 (2 revisions) (#130620) · 3132b3a7

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/2fabf4e5c9ed...21b8e6831be9

2023-07-14 kjlubick@users.noreply.github.com Remove calls to SkCanvas::flush() (flutter/engine#43684)
2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from c14fda1cb615 to 315c7f08c731 (3 revisions) (flutter/engine#43700)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

3132b3a7

Roll Flutter Engine from 63e9cbe7baa3 to 2fabf4e5c9ed (3 revisions) (#130615) · 6d8dc198

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/63e9cbe7baa3...2fabf4e5c9ed

2023-07-14 jonahwilliams@google.com [Impeller] remove requests for dedicated allocations. (flutter/engine#43686)
2023-07-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 3701605e0abf to d1fcadf22aad (1 revision) (flutter/engine#43692)
2023-07-14 jason-simmons@users.noreply.github.com More fixes for the new clang-tidy roll on iOS targets (flutter/engine#43688)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

6d8dc198

Use the new rounding hack migration flag in TextPainter (#130548) · f2574ba1
LongCatIsLooong authored Jul 14, 2023

f2574ba1
Remove unused imports (#130603) · d5c724eb
Michael Goderbauer authored Jul 14, 2023

d5c724eb

Roll Packages from aa1eace00188 to 369ee7e1a1cb (10 revisions) (#130605) · 41d137f3

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/packages/compare/aa1eace00188...369ee7e1a1cb

2023-07-14 reidbaker@google.com [Tool] New tool to download android dependencies (flutter/packages#4408)
2023-07-14 zaldypagaduanjr@gmail.com [video_player] added iOS exception on incorrect asset path (flutter/packages#4318)
2023-07-14 joonas.kerttula@codemate.com [google_maps_flutter_platform_interface] Add support for cloud-based map styling (flutter/packages#4141)
2023-07-14 10687576+bparrishMines@users.noreply.github.com [webview_flutter] Adds support for receiving a url with WebResourceError (flutter/packages#3884)
2023-07-14 stuartmorgan@google.com [xdg_directories] Remove `process` dependency (flutter/packages#4460)
2023-07-13 stuartmorgan@google.com [various] Update Pigeon in Swift plugins (flutter/packages#4461)
2023-07-13 engine-flutter-autoroll@skia.org Roll Flutter from 544d30db to c40173f1 (10 revisions) (flutter/packages#4457)
2023-07-13 engine-flutter-autoroll@skia.org Roll Flutter (stable) from 796c8ef79279 to f468f3366c26 (2 revisions) (flutter/packages#4456)
2023-07-13 bisor0627@gmail.com Fix Router Config Issues #4300 (go_router_builder/example) (flutter/packages#4369)
2023-07-13 10687576+bparrishMines@users.noreply.github.com [webview_flutter_platform_interface] Adds url to `WebResourceError` (flutter/packages#4439)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com,rmistry@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

41d137f3

[web] remove unnecessary awaits from flutter.js (#130204) · 1c1c273b

Pavel Mazhnik authored Jul 14, 2023

Fixed types for `_getNewServiceWorker` and `_waitForServiceWorkerActivation` functions.  
These functions currently expect a Promise as an argument, but we're actually passing in an already resolved value:
```js
.then(this._getNewServiceWorker)
.then(this._waitForServiceWorkerActivation);
```

1c1c273b

Roll Flutter Engine from c8dbd8a45f79 to 63e9cbe7baa3 (3 revisions) (#130601) · 847d1f04

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/c8dbd8a45f79...63e9cbe7baa3

2023-07-14 kjlubick@users.noreply.github.com Add missing Skia #includes (flutter/engine#43680)
2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from de6099518f90 to c14fda1cb615 (1 revision) (flutter/engine#43689)
2023-07-14 flar@google.com Fix DisplayListMatrixClipTracker handling of diff clips (flutter/engine#43664)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

847d1f04

Roll pub packages (#130348) · 56b5cc90
flutter-pub-roller-bot authored Jul 14, 2023
```
This PR was generated by `flutter update-packages --force-upgrade`.
```
56b5cc90

Roll Flutter Engine from 805162c18b32 to c8dbd8a45f79 (2 revisions) (#130596) · 934d2086

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/805162c18b32...c8dbd8a45f79

2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from b4b9c76206f3 to de6099518f90 (4 revisions) (flutter/engine#43687)
2023-07-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from J0oxaSt651gKgDreU... to Z-1lzZAOYHvVrdjQ8... (flutter/engine#43685)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from J0oxaSt651gK to Z-1lzZAOYHvV

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

934d2086

Test cover some leak-free code. (#130543) · d5e7f407
Polina Cherkasova authored Jul 14, 2023

d5e7f407

Add an android migrator to upgrade minSdkVersions 16,17,18 to flutter.minSdkVersion (#129729) · 93919232

gmackall authored Jul 14, 2023

This migrator will upgrade the minSdkVersion used in the [module-level build.gradle](https://developer.android.com/build#module-level) file to flutter.minSdkVersion.

The PR also makes a small refactor to `AndroidProject` to add a getter for the module level build.gradle file, and uses that getter in places where we were getting that file (previously it was being gotten directly via `hostAppGradleRoot.childDirectory('app').childFile('build.gradle')`.

Part of the work for deprecating support for the Jelly Bean android apis.

93919232

Add verbose engine logs for iOS start up tests (#130511) · a903f1de

Victoria Ashworth authored Jul 14, 2023

Added to be able to view logs from https://github.com/flutter/engine/pull/43616.

Added to debug https://github.com/flutter/flutter/issues/129836

a903f1de

Roll Flutter Engine from 6df061859ac7 to 805162c18b32 (1 revision) (#130589) · 79119dfc

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/6df061859ac7...805162c18b32

2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from 7990401d716a to b4b9c76206f3 (1 revision) (flutter/engine#43681)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

79119dfc

Fix StateError during hot reload when no Dart isolates found (#130537) · b91aedb1
Christopher Fujino authored Jul 14, 2023
```
Fixes https://github.com/flutter/flutter/issues/116262
```
b91aedb1

Roll Flutter Engine from 3a1b12a2fa09 to 6df061859ac7 (2 revisions) (#130583) · f5a5581f

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/3a1b12a2fa09...6df061859ac7

2023-07-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 8e4eac435b49 to 3701605e0abf (1 revision) (flutter/engine#43679)
2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from 8192de1efc1b to 7990401d716a (1 revision) (flutter/engine#43678)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f5a5581f

Roll Flutter Engine from 427ceaf089bd to 3a1b12a2fa09 (1 revision) (#130577) · 5cbccc4d

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/427ceaf089bd...3a1b12a2fa09

2023-07-14 kustermann@google.com Use utf8.encode() instead of longer const Utf8Encoder.convert() (flutter/engine#43675)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

5cbccc4d

Fix finish translation for tab labels (#130333) · ef312048

Bruno Leroux authored Jul 14, 2023

## Description

This PR update the finnish translations for tab label.

## Related Issue

fixes https://github.com/flutter/flutter/issues/110451

## Tests

Adds 2 tests.

ef312048

Revert "Update `DialogTheme` tests for M2/M3" (#130578) · b8fa9233

Zachary Anderson authored Jul 14, 2023

Reverts flutter/flutter#130414

Skia gold failures https://ci.chromium.org/ui/p/flutter/builders/prod/Mac%20framework_tests_libraries/11972/overview

b8fa9233

Roll Flutter Engine from fcecec871aae to 427ceaf089bd (3 revisions) (#130563) · a65e7394

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/fcecec871aae...427ceaf089bd

2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from 2848267f631d to 8192de1efc1b (1 revision) (flutter/engine#43672)
2023-07-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 8f49edfb6989 to 8e4eac435b49 (1 revision) (flutter/engine#43671)
2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from ffed127e8974 to 2848267f631d (3 revisions) (flutter/engine#43670)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a65e7394

Update `DialogTheme` tests for M2/M3 (#130414) · feab8545

Taha Tesser authored Jul 14, 2023

Updated unit tests for `DialogTheme` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/pull/128725

feab8545

Roll Flutter Engine from 0428c9d53e99 to fcecec871aae (1 revision) (#130561) · 4320abbd

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/0428c9d53e99...fcecec871aae

2023-07-14 skia-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from -csWUV7Dv3hETOoDw... to LZPMbHnVPFdbXndcX... (flutter/engine#43669)

Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from -csWUV7Dv3hE to LZPMbHnVPFdb

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4320abbd

Tap on button behind snack bar defined by margin (#127959) · c3cd0166

lsaudon authored Jul 14, 2023

If the margin is used, set the `HitTestBehavior` to `deferToChild`. 

*List which issues are fixed by this PR. You must list at least one issue.*
#78537 
#114810 

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*

c3cd0166

Roll Flutter Engine from 8d14461f7bc3 to 0428c9d53e99 (1 revision) (#130556) · e90f980f

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/8d14461f7bc3...0428c9d53e99

2023-07-14 skia-flutter-autoroll@skia.org Roll Fuchsia Mac SDK from rRUd41Mv9NI0n3Iyc... to J0oxaSt651gKgDreU... (flutter/engine#43667)

Also rolling transitive DEPS:
fuchsia/sdk/core/mac-amd64 from rRUd41Mv9NI0 to J0oxaSt651gK

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

e90f980f

Roll Flutter Engine from 2262a871c10a to 8d14461f7bc3 (1 revision) (#130555) · 4c0c8c30

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/2262a871c10a...8d14461f7bc3

2023-07-14 skia-flutter-autoroll@skia.org Roll Skia from 9e4f5cc3aeb4 to ffed127e8974 (1 revision) (flutter/engine#43666)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

4c0c8c30

Roll Flutter Engine from 77d8ec0a096c to 2262a871c10a (1 revision) (#130551) · a6fb2e0a

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/77d8ec0a096c...2262a871c10a

2023-07-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 9506d0c9f5ef to 8f49edfb6989 (1 revision) (flutter/engine#43665)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a6fb2e0a

Roll Flutter Engine from 601f0c173b8e to 77d8ec0a096c (2 revisions) (#130549) · 90ed1dfa

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/601f0c173b8e...77d8ec0a096c

2023-07-14 ian@hixie.ch Add more points to [MediaQuery]. (flutter/engine#43649)
2023-07-14 ian@hixie.ch Remove unimplemented API call saveCompilationTrace (flutter/engine#43656)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

90ed1dfa

Mention saveLayer in the CustomPainter docs. (#130520) · 46125d07
Ian Hickson authored Jul 14, 2023
```
Fixes https://github.com/flutter/flutter/issues/11002
```
46125d07

Roll Flutter Engine from 8a42bfc80e3a to 601f0c173b8e (1 revision) (#130544) · c01d2b7f

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/8a42bfc80e3a...601f0c173b8e

2023-07-13 jason-simmons@users.noreply.github.com Fix a clang-tidy warning about a potentially nil value in the editingState dictionary (flutter/engine#43660)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

c01d2b7f

Roll Flutter Engine from 0f0436b28430 to 8a42bfc80e3a (6 revisions) (#130538) · a7a353ca

engine-flutter-autoroll authored Jul 14, 2023

https://github.com/flutter/engine/compare/0f0436b28430...8a42bfc80e3a

2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 52613fcc0780 to 9e4f5cc3aeb4 (1 revision) (flutter/engine#43659)
2023-07-13 jonahwilliams@google.com [Impeller] no-op fragment program on Android until it works. (flutter/engine#43657)
2023-07-13 31859944+LongCatIsLooong@users.noreply.github.com Reland #43118 "Add a flag to ParagraphBuilder for rounding hack migration" (flutter/engine#43647)
2023-07-13 ychris@google.com Unmerge threads if the current merger is the only one that's merged. (flutter/engine#43652)
2023-07-13 dnfield@google.com Revert https://github.com/flutter/engine/pull/43533 (flutter/engine#43654)
2023-07-13 skia-flutter-autoroll@skia.org Roll Skia from 743ad92f5de2 to 52613fcc0780 (9 revisions) (flutter/engine#43655)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

a7a353ca

13 Jul, 2023 7 commits

Fix `timeOfDayFormat` for Danish (#130437) · bd18e78c

Tae Hyung Kim authored Jul 13, 2023

See title. According to
[CLDR](https://icu4c-demos.unicode.org/icu-bin/locexp?_=da_DK&d_=en&_l=da),
proper time of day format should be `HH.mm`.

Fixes https://github.com/flutter/flutter/issues/130234.

bd18e78c

Upgrade leak_tracker. (#130528) · 26a17a4c
Polina Cherkasova authored Jul 13, 2023

26a17a4c

Roll Flutter Engine from 1867efbf2936 to 0f0436b28430 (1 revision) (#130526) · 7abdb866

engine-flutter-autoroll authored Jul 13, 2023

https://github.com/flutter/engine/compare/1867efbf2936...0f0436b28430

2023-07-13 jason-simmons@users.noreply.github.com Fix a Fuchsia formatter type mismatch flagged by the pending Clang roll (flutter/engine#43651)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

7abdb866

Always escape when writing pubspec.yaml's 'description' field. (#130096) · 03749051

Matan Lurey authored Jul 13, 2023

Closes https://github.com/flutter/flutter/issues/80013.

**Before**:

```
$ flutter create test1 --description "a: b"
Creating project test1...
Error detected in pubspec.yaml:
Error on line 2, column 15: Mapping values are not allowed here. Did you miss a colon earlier?
  â·
2 â description: a: b
  â               ^
  âµ
Please correct the pubspec.yaml file at /Users/matan/Developer/scratch/test1/pubspec.yaml
```

**After**:

```
$ flutter create test1 --description "a: b"
Creating project test1...
Resolving dependencies in test1... 
Got dependencies in test1.
Wrote 129 files.

All done!
You can find general documentation for Flutter at: https://docs.flutter.dev/
Detailed API documentation is available at: https://api.flutter.dev/
If you prefer video documentation, consider: https://www.youtube.com/c/flutterdev

In order to run your application, type:

  $ cd test1
  $ flutter run

Your application code is in test1/lib/main.dart.
```

---

It's worth noting that this _always_ escapes a non-empty project description, which means that descriptions that were not previously wrapped in `"`s' will be. I'm not sure how worth it is to do a _conditional_ escape (i.e. only escape if not escaping would cause a problem), but willing to change.

Side-note: I had no idea where to list this test in the (very large) `create_test.dart`, so I did my best :)

03749051

Update `CardTheme`, `DrawerTheme`, `NavigationBar`, and `NavigationRailTheme`... · 7fc49906

Qun Cheng authored Jul 13, 2023

Update `CardTheme`, `DrawerTheme`, `NavigationBar`, and `NavigationRailTheme` tests for M2/M3 (#130047)

Updated unit tests for `CardTheme`, `DrawerTheme`, `NavigationBar`, and `NavigationRailTheme` to have M2 and M3 versions.

More info in https://github.com/flutter/flutter/issues/127064

7fc49906

Move straggling Android Impeller test to staging. (#130529) · e1d025ae
Zachary Anderson authored Jul 13, 2023

e1d025ae

Roll Flutter Engine from c31cfc517274 to 1867efbf2936 (1 revision) (#130517) · f8c91165

engine-flutter-autoroll authored Jul 13, 2023

https://github.com/flutter/engine/compare/c31cfc517274...1867efbf2936

2023-07-13 skia-flutter-autoroll@skia.org Roll Dart SDK from 16ddfe8d08e0 to 9506d0c9f5ef (1 revision) (flutter/engine#43646)

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

f8c91165